Skip to contentSkip to conversation

xf86-video-intel: configure.ac

DISCUSSION Julien Cristau 8 participants 14 messages Jul 27, 2010 – Jul 28, 2010 7 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

A message that is not in the archive (sent off-list or not yet received): 20100726234447.62A4410057-PlYeExAEIo6UevrW7tnuMEsOKLKoXr+P@public.gmane.org

#2 lore raw
Quoted 18 lines · Jesse Barnes
 configure.ac |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3

Author: Jesse Barnes <[email protected]>
Date:   Mon Jul 26 16:44:19 2010 -0700

configure.ac: add xi and gl requirements

Could probably be earlier versions, but having these here makes packaging easier.

configure.ac +0 -0
index d5989a6..4edd07b 100644

configure.ac XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto) · line 88

Quoted 8 lines
configure.ac +2 -0
@@ -81,6 +81,8 @@ XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
 PKG_CHECK_MODULES(XORG, [xorg-server >= 1.6 xproto fontsproto $REQUIRED_MODULES])
 PKG_CHECK_MODULES(DRM, [libdrm >= 2.4.21])
 PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
+PKG_CHECK_MODULES(XI, [xi >= 1.3])
+PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
 
 sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
 

May I ask why? None of these seem necessary…

Cheers,
Julien

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

A message that is not in the archive (sent off-list or not yet received): 20100727134135.GE10843-EvlgUWGjKCFw609as50hi2D2FQJk+8+b@public.gmane.org

#4 lore raw
Quoted 8 lines · Julien Cristau

Review

Quoted 5 lines
(quoted diff) +2 -0
+PKG_CHECK_MODULES(XI, [xi >= 1.3])
+PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
 
 sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`

May I ask why? None of these seem necessary…

Jesse,

Will the --disable-dri option still work now that the module cannot be configured without the gl package?

Will xi version 1.3 version be "too recent" when built against a 1.6 server?
The 1.6 server does not depend on libXi.

It's great to have accurate dependencies checking. Just by looking at the configuration of this driver,
it has an explicit requirement to support server 1.6 and later, and to work without dri.

Gaetan

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

#5 lore raw
Quoted 17 lines · On Tue, 27 Jul 2010 10:50:24 -0400 Gaetan Nadon <[email protected]> wrote:
Quoted 8 lines · Julien Cristau

Review

Quoted 5 lines
(quoted diff) +2 -0
+PKG_CHECK_MODULES(XI, [xi >= 1.3])
+PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
 
 sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`

May I ask why? None of these seem necessary…

Jesse,

Will the --disable-dri option still work now that the module cannot be configured without the gl package?

Quoted 8 lines

Will xi version 1.3 version be "too recent" when built against a 1.6 server?
The 1.6 server does not depend on libXi.

It's great to have accurate dependencies checking. Just by looking at the configuration of this driver,
it has an explicit requirement to support server 1.6 and later, and to work without dri.

I didn't test with the --disable-dri option, we could put the pkg requirement under a DRI check if needed.

I also haven't tried building against a 1.6 server for a long time, if we need changes to support that I can make them as well.

Signature · 5 lines
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel
#6 lore raw
In reply to Julien Cristau
Quoted 26 lines · On Tue, 27 Jul 2010 15:41:35 +0200 Julien Cristau <[email protected]> wrote:
Quoted 24 lines · Jesse Barnes
 configure.ac |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit d580fa82a1cf339d2d1fd1055d137c0b23cd04f3

Author: Jesse Barnes <[email protected]>
Date:   Mon Jul 26 16:44:19 2010 -0700

configure.ac: add xi and gl requirements

Could probably be earlier versions, but having these here makes packaging easier.

configure.ac +2 -0
index d5989a6..4edd07b 100644
@@ -81,6 +81,8 @@ XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
 PKG_CHECK_MODULES(XORG, [xorg-server >= 1.6 xproto fontsproto $REQUIRED_MODULES])
 PKG_CHECK_MODULES(DRM, [libdrm >= 2.4.21])
 PKG_CHECK_MODULES(PCIACCESS, [pciaccess >= 0.10])
+PKG_CHECK_MODULES(XI, [xi >= 1.3])
+PKG_CHECK_MODULES(GL, [gl >= 7.7.0])
 
Quoted 4 lines

configure.ac XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto) · line 88

Quoted 2 lines
configure.ac +0 -0
 sdkdir=`$PKG_CONFIG --variable=sdkdir xorg-server`
 

May I ask why? None of these seem necessary…

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

Signature · 5 lines
Jesse Barnes, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
#7 lore raw
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

Cheers,
Julien

A message that is not in the archive (sent off-list or not yet received): 20100727154439.GM12476-mjqoj5/V/[email protected]

#9 lore raw

Hi,

Quoted 6 lines · Julien Cristau
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

That's pretty awesome. In either case, xi is almost certainly the wrong module. If the requirement is to have X11/extensions/XI.h and friends for server headers, then not only should that dep be in the server rather than a driver which blatantly has nothing to do with input, but you want inputproto rather than xi, which is libXi.

Cheers,
Daniel

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

#10 lore raw
Quoted 7 lines · On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone <[email protected]> wrote:

Hi,

Quoted 4 lines · Julien Cristau
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

Quoted 8 lines
Quoted 2 lines

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

That's pretty awesome. In either case, xi is almost certainly the wrong module. If the requirement is to have X11/extensions/XI.h and friends for server headers, then not only should that dep be in the server rather than a driver which blatantly has nothing to do with input, but you want inputproto rather than xi, which is libXi.

Agreed, since Arjan requested this I just pinged him about why he thinks xi belongs here. We don't directly include files from either package, so putting the requirement on the server side makes more sense.

And I think the dep on glproto should be sufficient for the GL stuff we use...

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#11 lore raw
In reply to Daniel Stone
Quoted 7 lines · On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone <[email protected]> wrote:

Hi,

Quoted 4 lines · Julien Cristau
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

Quoted 8 lines
Quoted 2 lines

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

That's pretty awesome. In either case, xi is almost certainly the wrong module. If the requirement is to have X11/extensions/XI.h and friends for server headers, then not only should that dep be in the server rather than a driver which blatantly has nothing to do with input, but you want inputproto rather than xi, which is libXi.

Yep, sorry, my fault. I should have checked these out more; Arjan showed me the logs and it looks like the server is missing a dep on xi:

<arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,

<arjan>                  from /usr/include/xorg/xf86str.h:39,
<arjan>                  from /usr/include/xorg/xf86.h:46,
<arjan>                  from uxa-priv.h:37,
<arjan>                  from uxa.c:37:

<arjan> /usr/include/xorg/dix.h:57:31: fatal error:
X11/extensions/XI.h: No such file or directory

and glproto is missing a dep on GL:

<arjan> In file included from i810.h:60:0,
<arjan> from i810_accel.c:41:
<arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

So we'll have to fix those instead.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center

A message that is not in the archive (sent off-list or not yet received): [email protected]

#13 lore raw
Quoted 19 lines · Jesse Barnes
Quoted 5 lines · On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone…
Quoted 4 lines · Julien Cristau
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

Quoted 8 lines
Quoted 2 lines

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

That's pretty awesome. In either case, xi is almost certainly the wrong module. If the requirement is to have X11/extensions/XI.h and friends for server headers, then not only should that dep be in the server rather than a driver which blatantly has nothing to do with input, but you want inputproto rather than xi, which is libXi.

Yep, sorry, my fault. I should have checked these out more; Arjan showed me the logs and it looks like the server is missing a dep on xi:

Quoted 7 lines

<arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,

<arjan>                  from /usr/include/xorg/xf86str.h:39,
<arjan>                  from /usr/include/xorg/xf86.h:46,
<arjan>                  from uxa-priv.h:37,
<arjan>                  from uxa.c:37:

<arjan> /usr/include/xorg/dix.h:57:31: fatal error:
X11/extensions/XI.h: No such file or directory

That would be a dep on inputproto. :) xi only gives you XInput.h and XInput2.h, both client-only headers.

Cheers,
Daniel

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

A message that is not in the archive (sent off-list or not yet received): 20100727163911.GI2802-rLtY4a/8tF1rovVCs/[email protected]

#15 lore raw
Quoted 11 lines · Daniel Stone
Quoted 7 lines

<arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,

<arjan>                  from /usr/include/xorg/xf86str.h:39,
<arjan>                  from /usr/include/xorg/xf86.h:46,
<arjan>                  from uxa-priv.h:37,
<arjan>                  from uxa.c:37:

<arjan> /usr/include/xorg/dix.h:57:31: fatal error:
X11/extensions/XI.h: No such file or directory

That would be a dep on inputproto. :) xi only gives you XInput.h and XInput2.h, both client-only headers.

And it's already fixed.

http://cgit.freedesktop.org/xorg/xserver/commit/?id=32c706c4ffd7433dbfc79dba8785b1510d2f053f

The GL one is more annoying.

Cheers,
Julien
_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

A message that is not in the archive (sent off-list or not yet received): 20100727164751.GA3096-mjqoj5/V/[email protected]

#17 lore raw
Quoted 2 lines · Julien Cristau

The GL one is more annoying.

glproto includes gl.h which is in the mesa source. The mesa package depends on glproto.
This will become a circular dependency if glproto is fixed to depend on gl. I was surprised to see a protocol
including a header file from it's package implementation.

The patch is not responsible for this situation, but it shows that the packager cannot rely
on configuration dependencies alone to function properly. Not to mention there are
most likely missing dependencies. Build tool chain dependencies are one thing,
but running dependencies are another.

_______________________________________________
[email protected]: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: http://lists.x.org/mailman/listinfo/xorg-devel

#18 lore raw
In reply to Daniel Stone
Quoted 28 lines · On Tue, 27 Jul 2010 17:39:11 +0100 Daniel Stone <[email protected]> wrote:
Quoted 19 lines · Jesse Barnes
Quoted 5 lines · On Tue, 27 Jul 2010 17:00:28 +0100 Daniel Stone <[email protected]> wrote:
Quoted 4 lines · Julien Cristau
Quoted 2 lines · Jesse Barnes

Apparently MeeGo does automatic packaging based on configure.ac, so Arjan requested that these be added to make that easier.

Quoted 8 lines
Quoted 2 lines

So we're adding fictional dependencies based on meego brokenness? Do you have more details on the issues they were having?

That's pretty awesome. In either case, xi is almost certainly the wrong module. If the requirement is to have X11/extensions/XI.h and friends for server headers, then not only should that dep be in the server rather than a driver which blatantly has nothing to do with input, but you want inputproto rather than xi, which is libXi.

Yep, sorry, my fault. I should have checked these out more; Arjan showed me the logs and it looks like the server is missing a dep on xi:

Quoted 7 lines

<arjan> In file included from /usr/include/xorg/scrnintstr.h:58:0,

<arjan>                  from /usr/include/xorg/xf86str.h:39,
<arjan>                  from /usr/include/xorg/xf86.h:46,
<arjan>                  from uxa-priv.h:37,
<arjan>                  from uxa.c:37:

<arjan> /usr/include/xorg/dix.h:57:31: fatal error:
X11/extensions/XI.h: No such file or directory

Quoted 2 lines

That would be a dep on inputproto. :) xi only gives you XInput.h and XInput2.h, both client-only headers.

Right, and the server already has this, so either Arjan has an old server or his autopackager is broken.

Signature · 1 line
Jesse Barnes, Intel Open Source Technology Center
#19 lore raw
In reply to Jesse Barnes
Quoted 7 lines · Jesse Barnes

and glproto is missing a dep on GL:

<arjan> In file included from i810.h:60:0,
<arjan> from i810_accel.c:41:
<arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

From memory, I think this is just a bit of idiocacy in the driver

inappropriately using a GL type, i.e. for a variable unconnected with any of the GL interfaces.

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#20 lore raw
Quoted 10 lines · Chris Wilson
Quoted 5 lines · Jesse Barnes

and glproto is missing a dep on GL:

<arjan> In file included from i810.h:60:0,
<arjan>                  from i810_accel.c:41:
<arjan> /usr/include/GL/glxint.h:36:19: fatal error: GL/gl.h: No such file or directory

From memory, I think this is just a bit of idiocacy in the driver inappropriately using a GL type, i.e. for a variable unconnected with any of the GL interfaces.

There was a few gratuitous uses of GLuint in the core driver that I just removed. Then the legacy i810 driver still had the code to create and set GLX visuals, which hasn't been used for years now (we
get the configs from the dri driver even for dri1 since 2007). I
removed that chunk of code, which means that the legacy driver wont work with X server before 2007, but the purpose of the legacy code is to run the old driver on new servers anyway (right?).

Kristian
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx