S5PV210: Move OneNAND platform data to plat-s5p

PATCH New Kyungmin Park 3 participants 6 messages Jul 28, 2010

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Kyungmin Park

author

2010-07-28 01:17 UTC #0 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

From: Kyungmin Park <[email protected]>

S5PV310 has the same OneNAND controller and can use it commonly.

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/Kconfig            |    5 ---
 arch/arm/mach-s5pv210/Makefile           |    1 -
 arch/arm/mach-s5pv210/include/mach/map.h |    3 --
 arch/arm/plat-s5p/Makefile               |    2 +-
 arch/arm/plat-s5p/dev-onenand.c          |   52 ++++++++++++++++++++++++++++++
 5 files changed, 53 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm/plat-s5p/dev-onenand.c

arch/arm/mach-s5pv210/Kconfig +0 -5

index 0761eac..96f4d9b 100644
@@ -62,11 +62,6 @@ config MACH_GONI
 	  Machine support for Samsung GONI board
 	  S5PC110(MCP) is one of package option of S5PV210
 
-config S5PC110_DEV_ONENAND
-	bool
-	help
-	  Compile in platform device definition for OneNAND1 controller
-
 config MACH_SMDKV210
 	bool "SMDKV210"
 	select CPU_S5PV210

arch/arm/mach-s5pv210/Makefile +0 -1

index 30be9a6..6a6dea1 100644
@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
 
 obj-y				+= dev-audio.o
 obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
-obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
 
 obj-$(CONFIG_S5PV210_SETUP_FB_24BPP)	+= setup-fb-24bpp.o
 obj-$(CONFIG_S5PV210_SETUP_I2C1) 	+= setup-i2c1.o

arch/arm/mach-s5pv210/include/mach/map.h +0 -3

index 34eb168..3a44e1e 100644
@@ -16,9 +16,6 @@
 #include <plat/map-base.h>
 #include <plat/map-s5p.h>
 
-#define S5PC110_PA_ONENAND	(0xB0000000)
-#define S5PC110_PA_ONENAND_DMA	(0xB0600000)
-
 #define S5PV210_PA_CHIPID	(0xE0000000)
 #define S5P_PA_CHIPID		S5PV210_PA_CHIPID

arch/arm/plat-s5p/Makefile +1 -1

index 39c242b..d9f6890 100644
@@ -12,7 +12,7 @@ obj-				:=
 
 # Core files
 
-obj-y				+= dev-uart.o
+obj-y				+= dev-uart.o dev-onenand.o
 obj-y				+= cpu.o
 obj-y				+= clock.o
 obj-y				+= irq.o

arch/arm/plat-s5p/dev-onenand.c new file +52 -0

52 lines not on this page · raw message

Signature · 1 line

1.5.3.3

Kukjin Kim

2010-07-28 06:23 UTC #1 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

Quoted 5 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>
S5PV310 has the same OneNAND controller and can use it commonly.

Quoted 8 lines

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s5pv210/Kconfig            |    5 ---
 arch/arm/mach-s5pv210/Makefile           |    1 -
 arch/arm/mach-s5pv210/include/mach/map.h |    3 --
 arch/arm/plat-s5p/Makefile               |    2 +-
 arch/arm/plat-s5p/dev-onenand.c          |   52

++++++++++++++++++++++++++++++

Is this just moving dev-onenand.c from mach-s5pv210 to plat-s5p to support further SoC?
So...where is removing 'mach-s5pv210/dev-onenand.c'...I found just adding dev-onenand.c to plat-s5p.

Review

Quoted 20 lines

 5 files changed, 53 insertions(+), 10 deletions(-)
 create mode 100644 arch/arm/plat-s5p/dev-onenand.c

arch/arm/mach-s5pv210/Kconfig +0 -5

index 0761eac..96f4d9b 100644
@@ -62,11 +62,6 @@ config MACH_GONI
 	  Machine support for Samsung GONI board
 	  S5PC110(MCP) is one of package option of S5PV210
 
-config S5PC110_DEV_ONENAND
-	bool
-	help
-	  Compile in platform device definition for OneNAND1 controller
-
 config MACH_SMDKV210
 	bool "SMDKV210"
 	select CPU_S5PV210

(quoted diff) +0 -0

b/arch/arm/mach-s5pv210/Makefile

Quoted 31 lines

index 30be9a6..6a6dea1 100644

arch/arm/mach-s5pv210/Makefile +0 -1

@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI)		+= mach-goni.o
 
 obj-y				+= dev-audio.o
 obj-$(CONFIG_S3C64XX_DEV_SPI)	+= dev-spi.o
-obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
 
 obj-$(CONFIG_S5PV210_SETUP_FB_24BPP)	+= setup-fb-24bpp.o
 obj-$(CONFIG_S5PV210_SETUP_I2C1) 	+= setup-i2c1.o

arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/map.h +0 -0

s5pv210/include/mach/map.h
index 34eb168..3a44e1e 100644

arch/arm/mach-s5pv210/include/mach/map.h +0 -3

@@ -16,9 +16,6 @@
 #include <plat/map-base.h>
 #include <plat/map-s5p.h>
 
-#define S5PC110_PA_ONENAND	(0xB0000000)
-#define S5PC110_PA_ONENAND_DMA	(0xB0600000)
-
 #define S5PV210_PA_CHIPID	(0xE0000000)
 #define S5P_PA_CHIPID		S5PV210_PA_CHIPID

arch/arm/plat-s5p/Makefile +0 -0

index 39c242b..d9f6890 100644

arch/arm/plat-s5p/Makefile obj- := · line 15

Quoted 5 lines

arch/arm/plat-s5p/Makefile +1 -1

@@ -12,7 +12,7 @@ obj-				:=
 
 # Core files
 
-obj-y				+= dev-uart.o
+obj-y				+= dev-uart.o dev-onenand.o

Really, always need building dev-onenand for all S5P SoCs?

Review

Quoted 4 lines

arch/arm/plat-s5p/Makefile +0 -0
 obj-y				+= cpu.o
 obj-y				+= clock.o
 obj-y				+= irq.o
(quoted diff) +0 -0

b/arch/arm/plat-s5p/dev-onenand.c

Quoted 17 lines

new file mode 100644
index 0000000..00facbe

arch/arm/plat-s5p/dev-onenand.c new file +12 -0

@@ -0,0 +1,52 @@
+/*
+ * linux/arch/arm/plat-s5p/dev-onenand.c
+ *
+ *  Copyright (c) 2008-2010 Samsung Electronics
+ *  Kyungmin Park <[email protected]>
+ *
+ * S5PC110 series device definition for OneNAND devices
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */

arch/arm/plat-s5p/dev-onenand.c line 22

Quoted 10 lines

arch/arm/plat-s5p/dev-onenand.c new file +10 -0

+
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/mtd.h>
+#include <linux/mtd/onenand.h>
+
+#include <mach/irqs.h>
+
+#define S5PC110_PA_ONENAND		(0xB0000000)
+#define S5PC110_PA_ONENAND_DMA		(0xB0600000)

Should be in relevant map.h not here.

arch/arm/plat-s5p/dev-onenand.c line 24

Quoted 2 lines

arch/arm/plat-s5p/dev-onenand.c new file +2 -0
+
+static struct resource s5pc110_onenand_resources[] = {

It would be nice if could use s5p_ prefix in here.

arch/arm/plat-s5p/dev-onenand.c line 27

Quoted 3 lines

arch/arm/plat-s5p/dev-onenand.c new file +3 -0
+	[0] = {
+		.start	= S5PC110_PA_ONENAND,
+		.end	= S5PC110_PA_ONENAND + SZ_128K - 1,

Same.

Quoted 25 lines

arch/arm/plat-s5p/dev-onenand.c new file +21 -0

+		.flags	= IORESOURCE_MEM,
+	},
+	[1] = {
+		.start	= S5PC110_PA_ONENAND_DMA,
+		.end	= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+		.flags	= IORESOURCE_MEM,
+	},
+};
+
+struct platform_device s5pc110_device_onenand = {
+	.name		= "s5pc110-onenand",
+	.id		= -1,
+	.num_resources	= ARRAY_SIZE(s5pc110_onenand_resources),
+	.resource	= s5pc110_onenand_resources,
+};
+
+void s5pc110_onenand_set_platdata(struct onenand_platform_data *pdata)
+{
+	struct onenand_platform_data *pd;
+
+	pd = kmemdup(pdata, sizeof(struct onenand_platform_data),

GFP_KERNEL);

arch/arm/plat-s5p/dev-onenand.c new file +2 -0

+	if (!pd)
+		printk(KERN_ERR "%s: no memory for platform data\n",

__func__);

arch/arm/plat-s5p/dev-onenand.c

Quoted 3 lines

arch/arm/plat-s5p/dev-onenand.c new file +2 -1
+	s5pc110_device_onenand.dev.platform_data = pd;
+}
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

author

2010-07-28 07:44 UTC #2 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

Quoted 15 lines · Kukjin Kim

Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
S5PV310 has the same OneNAND controller and can use it commonly.
Quoted 8 lines
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv210/Kconfig ? ? ? ? ? ?| ? ?5 ---
?arch/arm/mach-s5pv210/Makefile ? ? ? ? ? | ? ?1 -
?arch/arm/mach-s5pv210/include/mach/map.h | ? ?3 --
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? | ? ?2 +-
?arch/arm/plat-s5p/dev-onenand.c ? ? ? ? ?| ? 52
++++++++++++++++++++++++++++++

Quoted 4 lines

Is this just moving dev-onenand.c from mach-s5pv210 to plat-s5p to support further SoC?
So...where is removing 'mach-s5pv210/dev-onenand.c'...I found just adding dev-onenand.c to plat-s5p.

Right, will fix it.

Quoted 54 lines

Quoted 20 lines
?5 files changed, 53 insertions(+), 10 deletions(-) ?create mode 100644 arch/arm/plat-s5p/dev-onenand.c
arch/arm/mach-s5pv210/Kconfig +0 -0
index 0761eac..96f4d9b 100644
@@ -62,11 +62,6 @@ config MACH_GONI
? ? ? ? Machine support for Samsung GONI board ? ? ? ? S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/Kconfig +0 -5
-config S5PC110_DEV_ONENAND
- ? ? bool
- ? ? help
- ? ? ? Compile in platform device definition for OneNAND1 controller
-
?config MACH_SMDKV210
? ? ? bool "SMDKV210"
? ? ? select CPU_S5PV210
Review
Quoted 1 line
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/Makefile
Quoted 32 lines
index 30be9a6..6a6dea1 100644
arch/arm/mach-s5pv210/Makefile +0 -0
@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? += mach-goni.o
 
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-audio.o ?obj-$(CONFIG_S3C64XX_DEV_SPI) ? ? ? ?+= dev-spi.o -obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
?obj-$(CONFIG_S5PV210_SETUP_FB_24BPP) += setup-fb-24bpp.o ?obj-$(CONFIG_S5PV210_SETUP_I2C1) ? ? += setup-i2c1.o
arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/map.h +0 -0
s5pv210/include/mach/map.h
index 34eb168..3a44e1e 100644
arch/arm/mach-s5pv210/include/mach/map.h +0 -0
@@ -16,9 +16,6 @@
?#include <plat/map-base.h>
?#include <plat/map-s5p.h>
arch/arm/mach-s5pv210/include/mach/map.h +0 -3
-#define S5PC110_PA_ONENAND ? (0xB0000000)
-#define S5PC110_PA_ONENAND_DMA ? ? ? (0xB0600000)
-
?#define S5PV210_PA_CHIPID ? ?(0xE0000000) ?#define S5P_PA_CHIPID ? ? ? ? ? ? ? ?S5PV210_PA_CHIPID
arch/arm/plat-s5p/Makefile +0 -0
index 39c242b..d9f6890 100644
@@ -12,7 +12,7 @@ obj- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?:=
 

Quoted 6 lines

arch/arm/plat-s5p/Makefile
Quoted 4 lines
?# Core files
arch/arm/plat-s5p/Makefile +1 -1
-obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o
+obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o dev-onenand.o
Really, always need building dev-onenand for all S5P SoCs?

will be handled in dev-onenand.c file.

Quoted 27 lines

Review
Quoted 5 lines
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= cpu.o
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= clock.o
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= irq.o
(quoted diff) +0 -0
b/arch/arm/plat-s5p/dev-onenand.c
Quoted 21 lines
new file mode 100644
index 0000000..00facbe
arch/arm/plat-s5p/dev-onenand.c new file +16 -0
@@ -0,0 +1,52 @@
+/*
+ * linux/arch/arm/plat-s5p/dev-onenand.c
+ *
+ * ?Copyright (c) 2008-2010 Samsung Electronics
+ * ?Kyungmin Park <[email protected]>
+ *
+ * S5PC110 series device definition for OneNAND devices
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ */
+
+#include <linux/kernel.h>
+#include <linux/platform_device.h>
+#include <linux/mtd/mtd.h>

Quoted 8 lines

arch/arm/plat-s5p/dev-onenand.c
Quoted 6 lines
arch/arm/plat-s5p/dev-onenand.c new file +6 -0
+#include <linux/mtd/onenand.h>
+
+#include <mach/irqs.h>
+
+#define S5PC110_PA_ONENAND ? ? ? ? ? (0xB0000000)
+#define S5PC110_PA_ONENAND_DMA ? ? ? ? ? ? ? (0xB0600000)
Should be in relevant map.h not here.

It's only used at dev-onenand.c so I think not big problem. I don't want to define it at all SoCs.
I hope only one macro or defined used one place. just define it at one file it's easy to read.

Quoted 51 lines

arch/arm/plat-s5p/dev-onenand.c line 24
Quoted 3 lines
arch/arm/plat-s5p/dev-onenand.c new file +2 -0
+
+static struct resource s5pc110_onenand_resources[] = {
It would be nice if could use s5p_ prefix in here.
arch/arm/plat-s5p/dev-onenand.c line 27
Quoted 3 lines
arch/arm/plat-s5p/dev-onenand.c new file +3 -0
+ ? ? [0] = {
+ ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND,
+ ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND + SZ_128K - 1,
Same.
Quoted 21 lines
arch/arm/plat-s5p/dev-onenand.c new file +21 -0
+ ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
+ ? ? },
+ ? ? [1] = {
+ ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA,
+ ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1,
+ ? ? ? ? ? ? .flags ?= IORESOURCE_MEM,
+ ? ? },
+};
+
+struct platform_device s5pc110_device_onenand = {
+ ? ? .name ? ? ? ? ? = "s5pc110-onenand",
+ ? ? .id ? ? ? ? ? ? = -1,
+ ? ? .num_resources ?= ARRAY_SIZE(s5pc110_onenand_resources),
+ ? ? .resource ? ? ? = s5pc110_onenand_resources,
+};
+
+void s5pc110_onenand_set_platdata(struct onenand_platform_data *pdata)
+{
+ ? ? struct onenand_platform_data *pd;
+
+ ? ? pd = kmemdup(pdata, sizeof(struct onenand_platform_data),
Quoted 7 lines
GFP_KERNEL);
+ ? ? if (!pd)
+ ? ? ? ? ? ? printk(KERN_ERR "%s: no memory for platform data\n", __func__);
+ ? ? s5pc110_device_onenand.dev.platform_data = pd;
+}
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Marek Szyprowski

2010-07-28 07:49 UTC #3 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

Hello,

Quoted 78 lines · Kukjin Kim

Quoted 15 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
S5PV310 has the same OneNAND controller and can use it commonly.
Quoted 8 lines
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv210/Kconfig ? ? ? ? ? ?| ? ?5 ---
?arch/arm/mach-s5pv210/Makefile ? ? ? ? ? | ? ?1 -
?arch/arm/mach-s5pv210/include/mach/map.h | ? ?3 --
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? | ? ?2 +-
?arch/arm/plat-s5p/dev-onenand.c ? ? ? ? ?| ? 52
++++++++++++++++++++++++++++++
Quoted 1 line
Is this just moving dev-onenand.c from mach-s5pv210 to plat-s5p to
support
Quoted 3 lines
further SoC?
So...where is removing 'mach-s5pv210/dev-onenand.c'...I found just adding dev-onenand.c to plat-s5p.
Right, will fix it.
Quoted 5 lines
arch/arm/mach-
Quoted 5 lines
?5 files changed, 53 insertions(+), 10 deletions(-) ?create mode 100644 arch/arm/plat-s5p/dev-onenand.c
arch/arm/mach- renamed from arch/arm/mach-s5pv210/Kconfig +0 -0
s5pv210/Kconfig
Quoted 49 lines
Quoted 15 lines
index 0761eac..96f4d9b 100644
arch/arm/mach-s5pv210/Kconfig +0 -0
@@ -62,11 +62,6 @@ config MACH_GONI
? ? ? ? Machine support for Samsung GONI board ? ? ? ? S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/Kconfig +0 -5
-config S5PC110_DEV_ONENAND
- ? ? bool
- ? ? help
- ? ? ? Compile in platform device definition for OneNAND1 controller
-
?config MACH_SMDKV210
? ? ? bool "SMDKV210"
? ? ? select CPU_S5PV210
Review
Quoted 1 line
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/Makefile
Quoted 32 lines
index 30be9a6..6a6dea1 100644
arch/arm/mach-s5pv210/Makefile +0 -0
@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? += mach-goni.o
 
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-audio.o ?obj-$(CONFIG_S3C64XX_DEV_SPI) ? ? ? ?+= dev-spi.o -obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
?obj-$(CONFIG_S5PV210_SETUP_FB_24BPP) += setup-fb-24bpp.o ?obj-$(CONFIG_S5PV210_SETUP_I2C1) ? ? += setup-i2c1.o
arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/map.h +0 -0
s5pv210/include/mach/map.h
index 34eb168..3a44e1e 100644
arch/arm/mach-s5pv210/include/mach/map.h +0 -0
@@ -16,9 +16,6 @@
?#include <plat/map-base.h>
?#include <plat/map-s5p.h>
arch/arm/mach-s5pv210/include/mach/map.h +0 -3
-#define S5PC110_PA_ONENAND ? (0xB0000000)
-#define S5PC110_PA_ONENAND_DMA ? ? ? (0xB0600000)
-
?#define S5PV210_PA_CHIPID ? ?(0xE0000000) ?#define S5P_PA_CHIPID ? ? ? ? ? ? ? ?S5PV210_PA_CHIPID
arch/arm/plat-s5p/Makefile +0 -0
index 39c242b..d9f6890 100644
@@ -12,7 +12,7 @@ obj- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?:=
 

Quoted 8 lines

Quoted 6 lines
arch/arm/plat-s5p/Makefile
Quoted 4 lines
?# Core files
arch/arm/plat-s5p/Makefile +1 -1
-obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o
+obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o dev-onenand.o
Really, always need building dev-onenand for all S5P SoCs?
will be handled in dev-onenand.c file.

I would also prefer common style over all file. ifdefs in .c files should be avoided. Just move&rename S5PC110_DEV_ONENAND KConfig entry from mach-s5pv210/Kconfig to plat-s5p/KConfig and use for conditional compilation.

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

Kyungmin Park

author

2010-07-28 07:57 UTC #4 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

2010/7/28 Marek Szyprowski <[email protected]>:

Quoted 89 lines

Hello,
Quoted 85 lines · Kukjin Kim
Quoted 15 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
S5PV310 has the same OneNAND controller and can use it commonly.
Quoted 8 lines
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv210/Kconfig ? ? ? ? ? ?| ? ?5 ---
?arch/arm/mach-s5pv210/Makefile ? ? ? ? ? | ? ?1 -
?arch/arm/mach-s5pv210/include/mach/map.h | ? ?3 --
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? | ? ?2 +-
?arch/arm/plat-s5p/dev-onenand.c ? ? ? ? ?| ? 52
++++++++++++++++++++++++++++++
Quoted 1 line
Is this just moving dev-onenand.c from mach-s5pv210 to plat-s5p to
support
Quoted 3 lines
further SoC?
So...where is removing 'mach-s5pv210/dev-onenand.c'...I found just adding dev-onenand.c to plat-s5p.
Right, will fix it.
Quoted 5 lines
arch/arm/mach-
Quoted 5 lines
?5 files changed, 53 insertions(+), 10 deletions(-) ?create mode 100644 arch/arm/plat-s5p/dev-onenand.c
arch/arm/mach- renamed from arch/arm/mach-s5pv210/Kconfig +0 -0
s5pv210/Kconfig
Quoted 55 lines
Quoted 15 lines
index 0761eac..96f4d9b 100644
arch/arm/mach-s5pv210/Kconfig +0 -0
@@ -62,11 +62,6 @@ config MACH_GONI
? ? ? ? Machine support for Samsung GONI board ? ? ? ? S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/Kconfig +0 -5
-config S5PC110_DEV_ONENAND
- ? ? bool
- ? ? help
- ? ? ? Compile in platform device definition for OneNAND1 controller
-
?config MACH_SMDKV210
? ? ? bool "SMDKV210"
? ? ? select CPU_S5PV210
Review
Quoted 1 line
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/Makefile
Quoted 34 lines
index 30be9a6..6a6dea1 100644
arch/arm/mach-s5pv210/Makefile +0 -0
@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? += mach-goni.o
 
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-audio.o ?obj-$(CONFIG_S3C64XX_DEV_SPI) ? ? ? ?+= dev-spi.o -obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
?obj-$(CONFIG_S5PV210_SETUP_FB_24BPP) += setup-fb-24bpp.o ?obj-$(CONFIG_S5PV210_SETUP_I2C1) ? ? += setup-i2c1.o
arch/arm/mach- renamed from arch/arm/mach-s5pv210/include/mach/map.h +0 -0
s5pv210/include/mach/map.h
index 34eb168..3a44e1e 100644
arch/arm/mach-s5pv210/include/mach/map.h +0 -0
@@ -16,9 +16,6 @@
?#include <plat/map-base.h>
?#include <plat/map-s5p.h>
arch/arm/mach-s5pv210/include/mach/map.h +0 -3
-#define S5PC110_PA_ONENAND ? (0xB0000000)
-#define S5PC110_PA_ONENAND_DMA ? ? ? (0xB0600000)
-
?#define S5PV210_PA_CHIPID ? ?(0xE0000000) ?#define S5P_PA_CHIPID ? ? ? ? ? ? ? ?S5PV210_PA_CHIPID
arch/arm/plat-s5p/Makefile +0 -0
index 39c242b..d9f6890 100644
@@ -12,7 +12,7 @@ obj- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?:=
 
?# Core files
arch/arm/plat-s5p/Makefile
Quoted 2 lines
arch/arm/plat-s5p/Makefile +1 -1
-obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o
+obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o dev-onenand.o
Really, always need building dev-onenand for all S5P SoCs?

Quoted 6 lines

Quoted 1 line
will be handled in dev-onenand.c file.
I would also prefer common style over all file. ifdefs in .c files should be avoided. Just move&rename S5PC110_DEV_ONENAND KConfig entry from mach-s5pv210/Kconfig to plat-s5p/KConfig and use for conditional compilation.

Then how to handle if we use the single kernel for c110 and c210. I can make a single onenand platform resource. then how to handle it at single kernel case?

Okay find an another way.

Thank you,
Kyungmin Park

Quoted 8 lines

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center

Marek Szyprowski

2010-07-28 08:16 UTC #5 lore raw

PATCH 1/1 S5PV210: Move OneNAND platform data to plat-s5p

Hello,

Quoted 95 lines · Kyungmin Park

2010/7/28 Marek Szyprowski <[email protected]>:
Quoted 5 lines
Hello,
Quoted 1 line · Kukjin Kim
On Wed, Jul 28, 2010 at 3:23 PM, Kukjin Kim <[email protected]>
Quoted 15 lines · wrote:
Quoted 15 lines
Quoted 15 lines
Quoted 13 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
S5PV310 has the same OneNAND controller and can use it commonly.
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s5pv210/Kconfig ? ? ? ? ? ?| ? ?5 ---
?arch/arm/mach-s5pv210/Makefile ? ? ? ? ? | ? ?1 -
?arch/arm/mach-s5pv210/include/mach/map.h | ? ?3 --
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? | ? ?2 +-
?arch/arm/plat-s5p/dev-onenand.c ? ? ? ? ?| ? 52
++++++++++++++++++++++++++++++
Quoted 4 lines
Quoted 4 lines
Quoted 1 line
Is this just moving dev-onenand.c from mach-s5pv210 to plat-s5p to
support
Quoted 2 lines
further SoC?
So...where is removing 'mach-s5pv210/dev-onenand.c'...I found just
adding
Quoted 31 lines
Quoted 31 lines
Quoted 1 line
dev-onenand.c to plat-s5p.
Right, will fix it.
Quoted 5 lines
arch/arm/mach-
Quoted 5 lines
?5 files changed, 53 insertions(+), 10 deletions(-) ?create mode 100644 arch/arm/plat-s5p/dev-onenand.c
arch/arm/mach- renamed from arch/arm/mach-s5pv210/Kconfig +0 -0
s5pv210/Kconfig
Quoted 22 lines
Quoted 15 lines
index 0761eac..96f4d9b 100644
arch/arm/mach-s5pv210/Kconfig +0 -0
@@ -62,11 +62,6 @@ config MACH_GONI
? ? ? ? Machine support for Samsung GONI board ? ? ? ? S5PC110(MCP) is one of package option of S5PV210
arch/arm/mach-s5pv210/Kconfig +0 -5
-config S5PC110_DEV_ONENAND
- ? ? bool
- ? ? help
- ? ? ? Compile in platform device definition for OneNAND1 controller
-
?config MACH_SMDKV210
? ? ? bool "SMDKV210"
? ? ? select CPU_S5PV210
Review
Quoted 1 line
(quoted diff) +0 -0
b/arch/arm/mach-s5pv210/Makefile
Quoted 5 lines
index 30be9a6..6a6dea1 100644
arch/arm/mach-s5pv210/Makefile +0 -0
@@ -26,7 +26,6 @@ obj-$(CONFIG_MACH_GONI) ? ? ? ? ? ? += mach-goni.o
 
Quoted 7 lines
Quoted 7 lines
Quoted 7 lines
Review
Quoted 7 lines
?obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-audio.o ?obj-$(CONFIG_S3C64XX_DEV_SPI) ? ? ? ?+= dev-spi.o -obj-$(CONFIG_S5PC110_DEV_ONENAND) += dev-onenand.o
?obj-$(CONFIG_S5PV210_SETUP_FB_24BPP) += setup-fb-24bpp.o ?obj-$(CONFIG_S5PV210_SETUP_I2C1) ? ? += setup-i2c1.o
(quoted diff) +0 -0
b/arch/arm/mach-
Quoted 29 lines
Quoted 28 lines
Quoted 20 lines
Quoted 20 lines
s5pv210/include/mach/map.h
index 34eb168..3a44e1e 100644
arch/arm/mach-s5pv210/include/mach/map.h +0 -0
@@ -16,9 +16,6 @@
?#include <plat/map-base.h>
?#include <plat/map-s5p.h>
arch/arm/mach-s5pv210/include/mach/map.h +0 -3
-#define S5PC110_PA_ONENAND ? (0xB0000000)
-#define S5PC110_PA_ONENAND_DMA ? ? ? (0xB0600000)
-
?#define S5PV210_PA_CHIPID ? ?(0xE0000000) ?#define S5P_PA_CHIPID ? ? ? ? ? ? ? ?S5PV210_PA_CHIPID
arch/arm/plat-s5p/Makefile +0 -0
index 39c242b..d9f6890 100644
@@ -12,7 +12,7 @@ obj- ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?:=
 
Quoted 6 lines
arch/arm/plat-s5p/Makefile
Quoted 4 lines
?# Core files
arch/arm/plat-s5p/Makefile +1 -1
-obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o
+obj-y ? ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?+= dev-uart.o dev-onenand.o
Really, always need building dev-onenand for all S5P SoCs?
will be handled in dev-onenand.c file.

Quoted 8 lines

Quoted 4 lines
I would also prefer common style over all file. ifdefs in .c files should be avoided. Just move&rename S5PC110_DEV_ONENAND KConfig entry from mach-s5pv210/Kconfig to plat-s5p/KConfig and use for conditional compilation.
Then how to handle if we use the single kernel for c110 and c210. I can make a single onenand platform resource. then how to handle it at single kernel case?

Single kernel case would need a huge redesign of device resources anyway. I hope such redesign would be ready soon. For the time being I would follow the style of other platform resources in Samsung platform. This would also make the conversion to new approach easier (maybe even automated).

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center