S5PC210: OneNAND: Use the correct DMA address range
Subsystems (2)
PATCH 2/6 S5PC210: OneNAND: Use the correct DMA address range
From: Kyungmin Park <[email protected]>
OneNAND DMA SFR requires the 8KiB mapping.
--- arch/arm/plat-s5p/dev-onenand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
arch/arm/plat-s5p/dev-onenand.c +1 -1
@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = { }, [1 ] = { .start =S5PC110_PA_ONENAND_DMA , - .end =S5PC110_PA_ONENAND_DMA +SZ_2K -1 , + .end =S5PC110_PA_ONENAND_DMA +SZ_8K -1 , .flags =IORESOURCE_MEM , }, };
Signature · 1 line
1.5.3.3
PATCH 2/6 S5PC210: OneNAND: Use the correct DMA address range
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
OneNAND DMA SFR requires the 8KiB mapping.
It would be helpful if you could add the reason why should change.
Just fix the DMA address range? Or for support further SoCs?...
Review
Quoted 6 lines
Signed-off-by Kyungmin Park <[email protected]>--- arch/arm/plat-s5p/dev-onenand.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/arch/arm/plat-s5p/dev-onenand.c
arch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] = {
Quoted 13 lines
index 08b3a3f..4d3eddb 100644
arch/arm/plat-s5p/dev-onenand.c +1
-2@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = { }, [1 ] = { .start =S5PC110_PA_ONENAND_DMA , - .end =S5PC110_PA_ONENAND_DMA +SZ_2K -1 , + .end =S5PC110_PA_ONENAND_DMA +SZ_8K -1 , .flags =IORESOURCE_MEM , }, }; --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
PATCH 2/6 S5PC210: OneNAND: Use the correct DMA address range
Quoted 9 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
OneNAND DMA SFR requires the 8KiB mapping.
It would be helpful if you could add the reason why should change.
Just fix the DMA address range? Or for support further SoCs?...
Of course DMA address range.
In the spec, the final address is INTC_ONENAND_STATUS 0xB060_1068
Thank you,
Kyungmin Park
Quoted 37 lines
Review
Quoted 7 lines
Signed-off-by Kyungmin Park <[email protected]>---
?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)(quoted diff) +0
-0
b/arch/arm/plat-s5p/dev-onenand.carch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] = {
Quoted 13 lines
index 08b3a3f..4d3eddb 100644
arch/arm/plat-s5p/dev-onenand.c +1
-2@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] = { ? ? ? }, ? ? ? [1] = { ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA, - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1, + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1, ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM, ? ? ? }, ?}; --Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd._______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
PATCH 2/6 S5PC210: OneNAND: Use the correct DMA address range
Quoted 8 lines · Kyungmin Park
Quoted 6 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
OneNAND DMA SFR requires the 8KiB mapping.
Quoted 8 lines
Quoted 3 lines
It would be helpful if you could add the reason why should change.
Just fix the DMA address range? Or for support further SoCs?...
Of course DMA address range.
In the spec, the final address is
INTC_ONENAND_STATUS0xB060_1068
I meant should being the reason in the commit message. Could not know correct reason by your comment. Ok...
Quoted 9 lines
Thank you,
Kyungmin ParkQuoted 6 lines
Quoted 6 lines
Signed-off-by Kyungmin Park <[email protected]>---
?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)
Quoted 6 lines
Quoted 6 lines
Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/arm/plat-s5p/dev-onenand.carch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] =
Quoted 4 lines
index 08b3a3f..4d3eddb 100644
arch/arm/plat-s5p/dev-onenand.c +0
-0@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] =
{
Quoted 11 lines
Quoted 11 lines
arch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] =
Quoted 9 lines
arch/arm/plat-s5p/dev-onenand.c +1
-2? ? ? }, ? ? ? [1] = { ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA, - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1, + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1, ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM, ? ? ? }, ?}; --
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
PATCH 2/6 S5PC210: OneNAND: Use the correct DMA address range
Quoted 11 lines · Kukjin Kim
Quoted 10 lines · Kyungmin Park
Quoted 8 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
OneNAND DMA SFR requires the 8KiB mapping.
It would be helpful if you could add the reason why should change.
Quoted 8 lines
Quoted 6 lines
Quoted 1 line
Just fix the DMA address range? Or for support further SoCs?...
Of course DMA address range.
In the spec, the final address is
INTC_ONENAND_STATUS0xB060_1068I meant should being the reason in the commit message. Could not know correct reason by your comment. Ok...
Subject is "Use the correct DMA address range"
Quoted 40 lines
Quoted 10 lines
Thank you,
Kyungmin ParkQuoted 6 lines
Quoted 6 lines
Signed-off-by Kyungmin Park <[email protected]>---
?arch/arm/plat-s5p/dev-onenand.c | ? ?2 +-
?1 files changed, 1 insertions(+), 1 deletions(-)Quoted 6 lines
Quoted 6 lines
Review
Quoted 1 line
(quoted diff) +0
-0
b/arch/arm/plat-s5p/dev-onenand.carch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] =
Quoted 4 lines
index 08b3a3f..4d3eddb 100644
arch/arm/plat-s5p/dev-onenand.c +0
-0@@ -30,7 +30,7 @@ static struct resource s5pc110_onenand_resources[] ={
Quoted 11 lines
Quoted 11 lines
arch/arm/plat-s5p/dev-onenand.c static struct resource s5pc110_onenand_resources[] =
Quoted 9 lines
arch/arm/plat-s5p/dev-onenand.c +1
-2? ? ? }, ? ? ? [1] = { ? ? ? ? ? ? ? .start ?= S5PC110_PA_ONENAND_DMA, - ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_2K - 1, + ? ? ? ? ? ? .end ? ?= S5PC110_PA_ONENAND_DMA + SZ_8K - 1, ? ? ? ? ? ? ? .flags ?= IORESOURCE_MEM, ? ? ? }, ?}; --Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.