9p: potential ERR_PTR() dereference

PATCH New Dan Carpenter 1 participant 1 message Aug 4, 2010

Subsystems (2)

Kernel janitors 9P file system

lore

Share & tools

lore

Dan Carpenter

author

2010-08-04 16:27 UTC #0 lore raw

PATCH 1/1 9p: potential ERR_PTR() dereference

p9_client_walk() can return error values if we run out of space or there is a problem with the network.

Signed-off-by Dan Carpenter <[email protected]>

fs/9p/fid.c +2 -1

index 3585636..6406f89 100644
@@ -242,7 +242,8 @@ struct p9_fid *v9fs_fid_lookup(struct dentry *dentry)
 	}
 	kfree(wnames);
 fid_out:
-	v9fs_fid_add(dentry, fid);
+	if (!IS_ERR(fid))
+		v9fs_fid_add(dentry, fid);
 err_out:
 	up_read(&v9ses->rename_sem);
 	return fid;