rocket: release_region or error path

PATCH New Dan Carpenter 1 participant 1 message Aug 4, 2010

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2010-08-04 16:33 UTC #0 lore raw

PATCH 1/1 rocket: release_region or error path

There was a release_region() missing on the error path.

Signed-off-by Dan Carpenter <[email protected]>

drivers/char/rocket.c +4 -1

index 0e29a23..258bc35 100644
@@ -2334,7 +2334,7 @@ static int __init rp_init(void)
 	ret = tty_register_driver(rocket_driver);
 	if (ret < 0) {
 		printk(KERN_ERR "Couldn't install tty RocketPort driver\n");
-		goto err_tty;
+		goto err_controller;
 	}
 
 #ifdef ROCKET_DEBUG_OPEN

@@ -2369,6 +2369,9 @@ static int __init rp_init(void)
 	return 0;
 err_ttyu:
 	tty_unregister_driver(rocket_driver);
+err_controller:
+	if (controller)
+		release_region(controller, 4);
 err_tty:
 	put_tty_driver(rocket_driver);
 err: