Skip to contentSkip to conversation

isdn: gigaset: add missing unlock

PATCH Applied Dan Carpenter 3 participants 3 messages Aug 6, 2010 – Aug 8, 2010

Subsystems (3)
Networking Network drivers Kernel janitors
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 isdn: gigaset: add missing unlock

We should unlock here. This is the only place where we return from the function with the lock held. The caller isn't expecting it.

Signed-off-by Dan Carpenter <[email protected]>
drivers/isdn/gigaset/capi.c +1 -0
index e5ea344..bcc174e 100644
@@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
 	do {
 		if (bcap->bcnext = ap) {
 			bcap->bcnext = bcap->bcnext->bcnext;
+			spin_unlock_irqrestore(&bcs->aplock, flags);
 			return;
 		}
 		bcap = bcap->bcnext;
Acked-by on v1 1/1
#2 lore raw
In reply to Dan Carpenter

Am 06.08.2010 10:23 schrieb Dan Carpenter:

Quoted 2 lines

We should unlock here. This is the only place where we return from the function with the lock held. The caller isn't expecting it.

Thanks, good catch.

Quoted 1 line
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Tilman Schmidt <[email protected]>
Quoted 13 lines
drivers/isdn/gigaset/capi.c +1 -0
index e5ea344..bcc174e 100644
@@ -1052,6 +1052,7 @@ static inline void remove_appl_from_channel(struct bc_state *bcs,
 	do {
 		if (bcap->bcnext == ap) {
 			bcap->bcnext = bcap->bcnext->bcnext;
+			spin_unlock_irqrestore(&bcs->aplock, flags);
 			return;
 		}
 		bcap = bcap->bcnext;
Signature · 4 lines
Tilman Schmidt                    E-Mail: [email protected]
Bonn, Germany
Diese Nachricht besteht zu 100% aus wiederverwerteten Bits.
Ungeöffnet mindestens haltbar bis: (siehe Rückseite)