bfa: dereferencing before testing

PATCH New Dan Carpenter 1 participant 1 message Aug 7, 2010

Subsystems (3)

SCSI Kernel janitors Brocade BFA FC SCSI driver

lore

Share & tools

lore

Dan Carpenter

author

2010-08-07 22:13 UTC #0 lore raw

PATCH 1/1 bfa: dereferencing before testing

I moved the dereference of "port" after the check to verify it was non-NULL.

Signed-off-by Dan Carpenter <[email protected]>

drivers/scsi/bfa/lport_api.c +2 -1

index 72b3f50..5cd356a 100644
@@ -149,11 +149,12 @@ bfa_fcs_port_get_rport_max_speed(struct bfa_fcs_port_s *port)
 	enum bfa_pport_speed max_speed = 0;
 	struct bfa_pport_attr_s pport_attr;
 	enum bfa_pport_speed pport_speed, rport_speed;
-	bfa_boolean_t     trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
+	bfa_boolean_t trl_enabled;
 
 	if (port = NULL)
 		return 0;
 
+	trl_enabled = bfa_fcport_is_ratelim(port->fcs->bfa);
 	fcs = port->fcs;
 
 	/*