dbgp: cleanup: remove unneeded check
Subsystems (2)
PATCH 1/1 dbgp: cleanup: remove unneeded check
len is always greater than or equal to zero here. First of all, it's type is unsigned and also we only assign it numbers which are greater than or equal to zero.
Removing the check lets us pull everything in an indent level.
Signed-off-by Dan Carpenter <[email protected]>
drivers/usb/gadget/dbgp.c +7 -9
@@ -386,15 +386,13 @@ static int dbgp_setup(struct usb_gadget *gadget, }else goto fail; -if (len >=0 ) { - req->length =min (length, len); - req->zero = len < req->length; -if (data && req->length) -memcpy (req->buf, data, req->length); - - req->complete = dbgp_setup_complete; -return usb_ep_queue (gadget->ep0, req,GFP_ATOMIC ); - } + req->length =min (length, len); + req->zero = len < req->length; +if (data && req->length) +memcpy (req->buf, data, req->length); + + req->complete = dbgp_setup_complete; +return usb_ep_queue (gadget->ep0, req,GFP_ATOMIC ); fail: dev_dbg(&dbgp.gadget->dev,
Quoted 35 lines
len is always greater than or equal to zero here. First of all, it's type is unsigned and also we only assign it numbers which are greater than or equal to zero.
Removing the check lets us pull everything in an indent level.
Signed-off-by Dan Carpenter <[email protected]>drivers/usb/gadget/dbgp.c +7
-9@@ -386,15 +386,13 @@ static int dbgp_setup(struct usb_gadget *gadget, }else goto fail; -if (len >=0 ) { - req->length =min (length, len); - req->zero = len < req->length; -if (data && req->length) -memcpy (req->buf, data, req->length); - - req->complete = dbgp_setup_complete; -return usb_ep_queue (gadget->ep0, req,GFP_ATOMIC ); - } + req->length =min (length, len); + req->zero = len < req->length; +if (data && req->length) +memcpy (req->buf, data, req->length); + + req->complete = dbgp_setup_complete; +return usb_ep_queue (gadget->ep0, req,GFP_ATOMIC ); fail: dev_dbg(&dbgp.gadget->dev,