ip2: remove unneeded NULL check

PATCH In review Dan Carpenter 1 participant 1 message Aug 12, 2010

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2010-08-12 07:51 UTC #0 lore raw

PATCH 1/2 ip2: remove unneeded NULL check

We don't pass NULL tty pointers to the close function, and anyway we already dereferenced it at this point. This check can be removed.

Signed-off-by Dan Carpenter <[email protected]>

drivers/char/ip2/ip2main.c +1 -1

index 07f3ea3..8fa041e 100644
@@ -1650,7 +1650,7 @@ ip2_close( PTTY tty, struct file *pFile )
 	/* disable DSS reporting */
 	i2QueueCommands(PTYPE_INLINE, pCh, 100, 4,
 				CMD_DCD_NREP, CMD_CTS_NREP, CMD_DSR_NREP, CMD_RI_NREP);
-	if ( !tty || (tty->termios->c_cflag & HUPCL) ) {
+	if (tty->termios->c_cflag & HUPCL) {
 		i2QueueCommands(PTYPE_INLINE, pCh, 100, 2, CMD_RTSDN, CMD_DTRDN);
 		pCh->dataSetOut &= ~(I2_DTR | I2_RTS);
 		i2QueueCommands( PTYPE_INLINE, pCh, 100, 1, CMD_PAUSE(25));