usb/uvc_v4l2: cleanup test for end of loop
Subsystems (2)
PATCH 1/1 usb/uvc_v4l2: cleanup test for end of loop
We're trying to test for the the end of the loop here. "format" is never NULL. We don't know what "format->fcc" is because we're past the end of the loop and I think "fmt->fmt.pix.pixelformat" comes from the user so we don't know what that is either. It works, but it's cleaner to just test to see if (i = ARRAY_SIZE(uvc_formats).
Signed-off-by Dan Carpenter <[email protected]>
drivers/usb/gadget/uvc_v4l2.c +1 -1
@@ -94,7 +94,7 @@ uvc_v4l2_set_format(struct uvc_video *video, struct v4l2_format *fmt)break ; } -if (format =NULL || format->fcc != fmt->fmt.pix.pixelformat) { +if (i =ARRAY_SIZE (uvc_formats)) {printk (KERN_INFO "Unsupported format 0x%08x.\n" , fmt->fmt.pix.pixelformat);return -EINVAL ;
Hi Dan,
Thanks for the patch.
Quoted 7 lines · On Thursday 12 August 2010 09:59:58 Dan Carpenter wrote:
We're trying to test for the the end of the loop here. "format" is never NULL. We don't know what "
format->fcc" is because we're past the end of the loop and I think "fmt->fmt.pix.pixelformat" comes from the user so we don't know what that is either. It works, but it's cleaner to just test to see if (i =ARRAY_SIZE(uvc_formats).Signed-off-by Dan Carpenter <[email protected]>
Acked-by Laurent Pinchart <[email protected]>
Quoted 13 lines
drivers/usb/gadget/uvc_v4l2.c +1
-1@@ -94,7 +94,7 @@ uvc_v4l2_set_format(struct uvc_video *video, struct v4l2_format *fmt) break; } -if (format =NULL || format->fcc != fmt->fmt.pix.pixelformat) { +if (i =ARRAY_SIZE (uvc_formats)) {printk (KERN_INFO "Unsupported format 0x%08x.\n" , fmt->fmt.pix.pixelformat);return -EINVAL ;
Signature · 3 lines
Regards, Laurent Pinchart