Skip to contentSkip to conversation

Please pull u-boot-cfi-flash/master

U-Boot Stefan Roese 2 participants 4 messages Aug 12, 2010 – Aug 13, 2010

lore
Share & tools
lore
#0 lore raw

The following changes since commit 69a2a4d9a5884a6f2d04a551308980d452b9b349:

disk/part.c: 'usb storage' avoiding overflow when output capacity (2010-08-10 23:08:55
+0200)

are available in the git repository at:
git://www.denx.de/git/u-boot-cfi-flash.git master

Kim Phillips (1):
cfi_flash: flinfo: allow user interrupt in flash print info fn

Philippe De Muyter (1):
Fix printing & reading of 16-bit CFI device identifiers

 drivers/mtd/cfi_flash.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)
#1 lore raw

Dear Stefan Roese,

Quoted 10 lines · In message <[email protected]> you wrote:

The following changes since commit 69a2a4d9a5884a6f2d04a551308980d452b9b349:

disk/part.c: 'usb storage' avoiding overflow when output capacity (2010-08-10 23:08:55
+0200)

are available in the git repository at:
git://www.denx.de/git/u-boot-cfi-flash.git master

Kim Phillips (1):
cfi_flash: flinfo: allow user interrupt in flash print info fn

Sorry, this patch got a NAK from me. The code needs fixing (actually the existing code should be fixed first, then Kim can add his patch).

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Don't worry about people stealing your ideas. If your ideas are  any
good, you'll have to ram them down people's throats."  - Howard Aiken
#2 lore raw

Hi Wolfgang,

Quoted 5 lines · On Thursday 12 August 2010 23:04:55 Wolfgang Denk wrote:
Quoted 2 lines

Kim Phillips (1):
cfi_flash: flinfo: allow user interrupt in flash print info fn

Sorry, this patch got a NAK from me. The code needs fixing (actually the existing code should be fixed first, then Kim can add his patch).

Would you accept an add-on patch that fixes this issue (I already have such a patch here). I just spotted a minor formatting problem with Kim's patch which I'm fixing in my add-on patch as well.

Just let me know and I'll send the add-on patch to the list.

Cheers,
Stefan

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de

#3 lore raw

Dear Stefan Roese,

Quoted 11 lines · In message <[email protected]> you wrote:
Quoted 5 lines · On Thursday 12 August 2010 23:04:55 Wolfgang Denk wrote:
Quoted 2 lines

Kim Phillips (1):
cfi_flash: flinfo: allow user interrupt in flash print info fn

Sorry, this patch got a NAK from me. The code needs fixing (actually the existing code should be fixed first, then Kim can add his patch).

Would you accept an add-on patch that fixes this issue (I already have such a patch here). I just spotted a minor formatting problem with Kim's patch which I'm fixing in my add-on patch as well.

Yes, that's OK with me.

Quoted 1 line

Just let me know and I'll send the add-on patch to the list.

Thanks.

Best regards,

Wolfgang Denk

Signature · 5 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Gew?hnlich glaubt der Mensch,  wenn er nur Worte h?rt,  es m?sse sich
dabei doch auch was denken lassen.                 -- Goethe, Faust I