Skip to contentSkip to conversation

kconfig: fix warning: ignoring return value, declared with attribute warn_unused_result

PATCH In review Jean Sacren 2 participants 2 messages Aug 12, 2010

Subsystems (2)
Kbuild Kconfig
lore
Share & tools
lore

Jean Sacren

author
#0 lore raw

PATCH 1/1 kconfig: fix warning: ignoring return value, declared with attribute warn_unused_result

Hush up the unnecessary gcc warnings when fwrite() or fgets() are called.

Signed-off-by Jean Sacren <[email protected]>
Cc stable <[email protected]>
---
 scripts/kconfig/conf.c     |    6 ++++--
 scripts/kconfig/confdata.c |    8 +++++---
 scripts/kconfig/expr.c     |    3 ++-
 3 files changed, 11 insertions(+), 6 deletions(-)
scripts/kconfig/conf.c +4 -2
index 9960d1c..beaa533 100644
@@ -77,6 +77,7 @@ static void check_stdin(void)
 
 static int conf_askvalue(struct symbol *sym, const char *def)
 {
+	char *dummy;
 	enum symbol_type type = sym_get_type(sym);
 
 	if (!sym_has_value(sym))

@@ -102,7 +103,7 @@ static int conf_askvalue(struct symbol *sym, const char *def)
 		check_stdin();
 	case ask_all:
 		fflush(stdout);
-		fgets(line, 128, stdin);
+		dummy = fgets(line, 128, stdin);
 		return 1;
 	default:
 		break;

@@ -230,6 +231,7 @@ static int conf_choice(struct menu *menu)
 	struct menu *child;
 	int type;
 	bool is_new;
+	char *dummy;
 
 	sym = menu->sym;
 	type = sym_get_type(sym);

@@ -304,7 +306,7 @@ static int conf_choice(struct menu *menu)
 			check_stdin();
 		case ask_all:
 			fflush(stdout);
-			fgets(line, 128, stdin);
+			dummy = fgets(line, 128, stdin);
 			strip(line);
 			if (line[0] == '?') {
 				print_help(menu);
scripts/kconfig/confdata.c +5 -3
index c4dec80..52c6c3d 100644
@@ -408,6 +408,7 @@ int conf_write(const char *name)
 	time_t now;
 	int use_timestamp = 1;
 	char *env;
+	size_t dummy;
 
 	dirname[0] = 0;
 	if (name && name[0]) {

@@ -505,7 +506,7 @@ int conf_write(const char *name)
 				while (1) {
 					l = strcspn(str, "\"\\");
 					if (l) {
-						fwrite(str, l, 1, out);
+						dummy = fwrite(str, l, 1, out);
 						str += l;
 					}
 					if (!*str)

@@ -680,6 +681,7 @@ int conf_write_autoconf(void)
 	FILE *out, *tristate, *out_h;
 	time_t now;
 	int i, l;
+	size_t dummy;
 
 	sym_clear_all_valid();
 

@@ -756,8 +758,8 @@ int conf_write_autoconf(void)
 			while (1) {
 				l = strcspn(str, "\"\\");
 				if (l) {
-					fwrite(str, l, 1, out);
-					fwrite(str, l, 1, out_h);
+					dummy = fwrite(str, l, 1, out);
+					dummy = fwrite(str, l, 1, out_h);
 					str += l;
 				}
 				if (!*str)
scripts/kconfig/expr.c +2 -1
index d83f232..99a058d 100644
@@ -1087,7 +1087,8 @@ void expr_print(struct expr *e, void (*fn)(void *, struct symbol *, const char *
 
 static void expr_print_file_helper(void *data, struct symbol *sym, const char *str)
 {
-	fwrite(str, strlen(str), 1, data);
+	size_t dummy;
+	dummy = fwrite(str, strlen(str), 1, data);
 }
 
 void expr_fprint(struct expr *e, FILE *out)
Signature · 1 line
1.7.1
#1 lore raw
Quoted 5 lines · Jean Sacren

Hush up the unnecessary gcc warnings when fwrite() or fgets() are called.

Signed-off-by Jean Sacren <[email protected]>
Cc stable <[email protected]>

I actullay liked the first version you posted better than this. But ayway a few comments:
- Please always include the warning you fix.
This makes it much easier to ask google if a patch for the same issue already exists
- Please redo the patch on top of Linus-latest.
We refactored some code and this patch will no longer apply
- Please cc: Mike Frysinger as he sent a patch to fix the same warnings

Sam

Quoted 104 lines
---
 scripts/kconfig/conf.c     |    6 ++++--
 scripts/kconfig/confdata.c |    8 +++++---
 scripts/kconfig/expr.c     |    3 ++-
 3 files changed, 11 insertions(+), 6 deletions(-)
scripts/kconfig/conf.c +4 -2
index 9960d1c..beaa533 100644
@@ -77,6 +77,7 @@ static void check_stdin(void)
 
 static int conf_askvalue(struct symbol *sym, const char *def)
 {
+	char *dummy;
 	enum symbol_type type = sym_get_type(sym);
 
 	if (!sym_has_value(sym))

@@ -102,7 +103,7 @@ static int conf_askvalue(struct symbol *sym, const char *def)
 		check_stdin();
 	case ask_all:
 		fflush(stdout);
-		fgets(line, 128, stdin);
+		dummy = fgets(line, 128, stdin);
 		return 1;
 	default:
 		break;

@@ -230,6 +231,7 @@ static int conf_choice(struct menu *menu)
 	struct menu *child;
 	int type;
 	bool is_new;
+	char *dummy;
 
 	sym = menu->sym;
 	type = sym_get_type(sym);

@@ -304,7 +306,7 @@ static int conf_choice(struct menu *menu)
 			check_stdin();
 		case ask_all:
 			fflush(stdout);
-			fgets(line, 128, stdin);
+			dummy = fgets(line, 128, stdin);
 			strip(line);
 			if (line[0] == '?') {
 				print_help(menu);
scripts/kconfig/confdata.c +5 -3
index c4dec80..52c6c3d 100644
@@ -408,6 +408,7 @@ int conf_write(const char *name)
 	time_t now;
 	int use_timestamp = 1;
 	char *env;
+	size_t dummy;
 
 	dirname[0] = 0;
 	if (name && name[0]) {

@@ -505,7 +506,7 @@ int conf_write(const char *name)
 				while (1) {
 					l = strcspn(str, "\"\\");
 					if (l) {
-						fwrite(str, l, 1, out);
+						dummy = fwrite(str, l, 1, out);
 						str += l;
 					}
 					if (!*str)

@@ -680,6 +681,7 @@ int conf_write_autoconf(void)
 	FILE *out, *tristate, *out_h;
 	time_t now;
 	int i, l;
+	size_t dummy;
 
 	sym_clear_all_valid();
 

@@ -756,8 +758,8 @@ int conf_write_autoconf(void)
 			while (1) {
 				l = strcspn(str, "\"\\");
 				if (l) {
-					fwrite(str, l, 1, out);
-					fwrite(str, l, 1, out_h);
+					dummy = fwrite(str, l, 1, out);
+					dummy = fwrite(str, l, 1, out_h);
 					str += l;
 				}
 				if (!*str)
scripts/kconfig/expr.c +2 -1
index d83f232..99a058d 100644
@@ -1087,7 +1087,8 @@ void expr_print(struct expr *e, void (*fn)(void *, struct symbol *, const char *
 
 static void expr_print_file_helper(void *data, struct symbol *sym, const char *str)
 {
-	fwrite(str, strlen(str), 1, data);
+	size_t dummy;
+	dummy = fwrite(str, strlen(str), 1, data);
 }
 
 void expr_fprint(struct expr *e, FILE *out)
Signature · 5 lines
1.7.1
--
To unsubscribe from this list: send the line "unsubscribe linux-kbuild" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html