kfifo: fix DMA sample driver
PATCH 1/1 kfifo: fix DMA sample driver
The kfifo DMA sample driver is broken. It does not properly initialize the scatterlist, and therefore causes a kernel BUG with CONFIG_DEBUG_SG=y.
Signed-off-by Ira W. Snyder <[email protected]>
--- samples/kfifo/dma-example.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
samples/kfifo/dma-example.c +3 -0
@@ -45,6 +45,9 @@ static int __init example_init(void)printk (KERN_INFO "queue len: %u\n" ,kfifo_len (&fifo)); +/* initialize scatterlist */ +sg_init_table (sg,ARRAY_SIZE (sg)); + ret =kfifo_dma_in_prepare (&fifo, sg,ARRAY_SIZE (sg),FIFO_SIZE );printk (KERN_INFO "DMA sgl entries: %d\n" , ret);
Signature · 1 line
1.7.1
Quoted 6 lines · Ira W. Snyder
The kfifo DMA sample driver is broken. It does not properly initialize the scatterlist, and therefore causes a kernel BUG with
CONFIG_DEBUG_SG=y.Signed-off-by Ira W. Snyder <[email protected]>---
Whoops, forgot to CC Stefani Seibold.
Quoted 20 lines
samples/kfifo/dma-example.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)samples/kfifo/dma-example.c +3
-0@@ -45,6 +45,9 @@ static int __init example_init(void)printk (KERN_INFO "queue len: %u\n" ,kfifo_len (&fifo)); +/* initialize scatterlist */ +sg_init_table (sg,ARRAY_SIZE (sg)); + ret =kfifo_dma_in_prepare (&fifo, sg,ARRAY_SIZE (sg),FIFO_SIZE );printk (KERN_INFO "DMA sgl entries: %d\n" , ret);Signature · 1 line
1.7.1