regulator/ab8500: move dereference below the check for NULL

PATCH Applied Dan Carpenter 4 participants 4 messages Aug 14, 2010

Subsystems (2)

Kernel janitors Voltage and current regulator framework

lore

Share & tools

lore

Dan Carpenter

author

2010-08-14 09:03 UTC #0 lore raw

PATCH 1/1 regulator/ab8500: move dereference below the check for NULL

I moved the dereference of "ab8500" below the check for NULL.

Signed-off-by Dan Carpenter <[email protected]>

drivers/regulator/ab8500.c +2 -1

index dc3f1a4..cc7cbaf 100644
@@ -344,13 +344,14 @@ static inline struct ab8500_regulator_info *find_regulator_info(int id)
 static __devinit int ab8500_regulator_probe(struct platform_device *pdev)
 {
 	struct ab8500 *ab8500 = dev_get_drvdata(pdev->dev.parent);
-	struct ab8500_platform_data *pdata = dev_get_platdata(ab8500->dev);
+	struct ab8500_platform_data *pdata;
 	int i, err;
 
 	if (!ab8500) {
 		dev_err(&pdev->dev, "null mfd parent\n");
 		return -EINVAL;
 	}
+	pdata = dev_get_platdata(ab8500->dev);
 
 	/* register all regulators */
 	for (i = 0; i < ARRAY_SIZE(ab8500_regulator_info); i++) {

Mark Brown

Acked-by on v1 1/1

2010-08-14 09:36 UTC #1 lore raw

Quoted 3 lines · Dan Carpenter

I moved the dereference of "ab8500" below the check for NULL.
Signed-off-by Dan Carpenter <[email protected]>

Acked-by Mark Brown <[email protected]>

Sundar R IYER

2010-08-14 09:57 UTC #2 lore raw

Quoted 7 lines · Mark Brown

Quoted 3 lines · Dan Carpenter
I moved the dereference of "ab8500" below the check for NULL.
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Mark Brown <[email protected]>

Thanx!

Regards,
Sundar

Liam Girdwood

Applied

2010-08-14 11:15 UTC #3 lore raw

In reply to Mark Brown

Quoted 7 lines · Mark Brown

Quoted 3 lines · Dan Carpenter
I moved the dereference of "ab8500" below the check for NULL.
Signed-off-by Dan Carpenter <[email protected]>
Acked-by Mark Brown <[email protected]>

Applied.

Thanks

Liam

Signature · 3 lines

Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk