cyber2000fb: palette corruption at higher clocks

Hello,
I'm implementing EDID support for cyber2000fb and found a weird bug in cyber2000fb driver. My monitor EDID reports 1280x1024@75Hz as best mode. When this mode is set, console palette is not set properly - sometimes the background is white, sometimes yellow and text colors are also messed up. This does not happen at 1280x1024@60Hz.

When I run "reset", it fixes the palette. But when I run it immediately after loading the driver (i.e. "modprobe cyber2000fb mode_option80x1024-8@75 && reset"), it does not help. "sleep 0.6" needs to be added before "reset" to make it work.

It seems that the HW needs some time before setting the palette - maybe the PLL needs more time to lock at higher speeds? Does anyone have some HW docs to check this? This patch fixes the problem but without knowing what register to check for PLL lock(?), the delay might be excessive.

@@ -506,6 +506,9 @@ static void cyber2000fb_set_timing(struc
 	cyber2000_grphw(0xb9, 0x80, cfb);
 	cyber2000_grphw(0xb9, 0x00, cfb);
 
+	/* wait (for the PLL?) to avoid palette corruption at higher clocks */
+	msleep(1000);
+
 	cfb->ramdac_ctrl = hw->ramdac;
 	cyber2000fb_write_ramdac_ctrl(cfb);
 

Ondrej Zary