Skip to contentSkip to conversation

compiler warnings in 2.6.35.2

DISCUSSION Chris Frey 4 participants 10 messages Aug 17, 2010 – Aug 18, 2010 Driver core

lore
Share & tools
lore

Chris Frey

author
#0 lore raw

Hi,

When compiling the latest 2.6.35.2 I get a ton of warnings like the following. Similar warnings were present in 2.6.35, and I assumed a stable point release may have tackled them already. But maybe they are peculiar to my setup. Warning below.

- Chris

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

#1 lore raw

From: Chris Frey <[email protected]>
Date: Mon, Aug 16, 2010 at 10:12:52PM -0400

Quoted 11 lines

Hi,

When compiling the latest 2.6.35.2 I get a ton of warnings like the following. Similar warnings were present in 2.6.35, and I assumed a stable point release may have tackled them already. But maybe they are peculiar to my setup. Warning below.

- Chris

Quoted 7 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

Which compiler version are you using?

Signature · 2 lines
Regards/Gruss,
    Boris.
author
#2 lore raw
Quoted 11 lines · Borislav Petkov

From: Chris Frey <[email protected]>
Date: Mon, Aug 16, 2010 at 10:12:52PM -0400

Quoted 7 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

Quoted 1 line

Which compiler version are you using?

GCC 3.3

- Chris

#3 lore raw

From: Chris Frey <[email protected]>
Date: Tue, Aug 17, 2010 at 02:28:01AM -0400

Quoted 11 lines
Quoted 9 lines
Quoted 7 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

Which compiler version are you using?

GCC 3.3

Any chance to upgrade to a 4.x version?

Signature · 2 lines
Regards/Gruss,
    Boris.
author
#4 lore raw
Quoted 11 lines · Borislav Petkov

From: Chris Frey <[email protected]>
Date: Tue, Aug 17, 2010 at 02:28:01AM -0400

Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Which compiler version are you using?

GCC 3.3

Any chance to upgrade to a 4.x version?

I could, but Documentation/Changes says gcc 3.2 is the minimum, so I hoped 3.3 would be sufficient.

As for the first warning, doesn't it just need include/linux/kobject.h to be included for the enum type?

As for the second warning, I'm not sure I even understand it.

- Chris

#5 lore raw

From: Chris Frey <[email protected]>
Date: Tue, Aug 17, 2010 at 11:53:33AM -0400

Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 8 lines
Quoted 7 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type /home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h: In function `__static_cpu_has':
/home/cdfrey/kernel/git/linux/arch/x86/include/asm/cpufeature.h:315: warning: asm operand 1 probably doesn't match constraints

Quoted 8 lines
Quoted 5 lines
Quoted 3 lines
Quoted 1 line

Which compiler version are you using?

GCC 3.3

Any chance to upgrade to a 4.x version?

I could, but Documentation/Changes says gcc 3.2 is the minimum, so I hoped 3.3 would be sufficient.

This is actually something we're looking to change now:
http://lkml.indiana.edu/hypermail/linux/kernel/1005.2/01239.html

@hpa: there are some gcc3.x users left, obviously.

Quoted 3 lines

As for the first warning, doesn't it just need include/linux/kobject.h to be included for the enum type?

This is a gcc 3.x problem AFAIK.

Quoted 1 line

As for the second warning, I'm not sure I even understand it.

Ditto.

So why do you want to stay with 3.x anyway?

Signature · 2 lines
Regards/Gruss,
Boris.
#7 lore raw

From: Anca Emanuel <[email protected]>
Date: Tue, Aug 17, 2010 at 08:15:21PM +0300

Quoted 10 lines · Borislav Petkov
Quoted 1 line

So why do you want to stay with 3.x anyway?

Read this: http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.36-rc1-maverick/BUILD.LOG
Search for warnings.
I tried to complile myself (using ubuntu 10.10 with latest updates),
but failed at some staging driver. After uncheked the staging drivers, still failure.
I'm using kernel 2.6.36-rc1 from
http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.36-rc1-maverick/

Can you please elaborate a bit more, what are you trying to show here?

Signature · 2 lines
Regards/Gruss,
    Boris.
#8 lore raw
Quoted 14 lines · Borislav Petkov

From: Anca Emanuel <[email protected]>
Date: Tue, Aug 17, 2010 at 08:15:21PM +0300

Quoted 10 lines · Borislav Petkov
Quoted 1 line

So why do you want to stay with 3.x anyway?

Read this: http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.36-rc1-maverick/BUILD.LOG
Search for warnings.
I tried to complile myself (using ubuntu 10.10 with latest updates),
but failed at some staging driver. After uncheked the staging drivers, still failure.
I'm using kernel 2.6.36-rc1 from
http://kernel.ubuntu.com/~kernel-ppa/mainline/v2.6.36-rc1-maverick/

Quoted 6 lines

Can you please elaborate a bit more, what are you trying to show here?

--
Regards/Gruss,
   Boris.

Steps to reproduce:
1. Install Ubuntu 10.04, and upgrade to 10.10
2. Use this tutorial to compile the kernel:
https://wiki.ubuntu.com/KernelTeam/GitKernelBuild

There is a lot of compiler warnings, and this problem is not new. I think that is enough for this moment.

( If you can boot from it please show how did you do it )

#9 lore raw
In reply to Chris Frey
Quoted 11 lines · Chris Frey

Hi,

When compiling the latest 2.6.35.2 I get a ton of warnings like the following. Similar warnings were present in 2.6.35, and I assumed a stable point release may have tackled them already. But maybe they are peculiar to my setup. Warning below.

- Chris

Quoted 5 lines

CC mm/swap.o
In file included from include/linux/kobject.h:21,

                 from include/linux/sched.h:91,
                 from mm/swap.c:17:

include/linux/sysfs.h:183: warning: parameter has incomplete type

Known issue, will show up in a future .35.y kernel release. The patch is below if you need it now.

thanks,

greg k-h

Quoted 1 line

From [email protected] Thu Aug 12 13:40:21 2010

From: David Howells <[email protected]>
Subject: kobject: Break the kobject namespace defs into their own header
To: [email protected], [email protected]
Cc: [email protected], [email protected],
David Howells <[email protected]>
Date: Wed, 11 Aug 2010 15:01:02 +0100
Message-ID: <[email protected]>

Break the kobject namespace defs into their own header to avoid a header file inclusion ordering problem between linux/sysfs.h and linux/kobject.h.

This fixes the build breakage on older versions of gcc.

---
 include/linux/kobject.h    |   35 ----------------------------
 include/linux/kobject_ns.h |   56 +++++++++++++++++++++++++++++++++++++++++++++
 include/linux/sysfs.h      |    1 
 3 files changed, 58 insertions(+), 34 deletions(-)
include/linux/kobject.h +1 -34
@@ -22,6 +22,7 @@
 #include <linux/compiler.h>
 #include <linux/spinlock.h>
 #include <linux/kref.h>
+#include <linux/kobject_ns.h>
 #include <linux/kernel.h>
 #include <linux/wait.h>
 #include <asm/atomic.h>
@@ -136,42 +137,8 @@ struct kobj_attribute {
 
 extern const struct sysfs_ops kobj_sysfs_ops;
 
-/*
- * Namespace types which are used to tag kobjects and sysfs entries.
- * Network namespace will likely be the first.
- */
-enum kobj_ns_type {
-	KOBJ_NS_TYPE_NONE = 0,
-	KOBJ_NS_TYPE_NET,
-	KOBJ_NS_TYPES
-};
-
 struct sock;
 
-/*
- * Callbacks so sysfs can determine namespaces
- *   @current_ns: return calling task's namespace
- *   @netlink_ns: return namespace to which a sock belongs (right?)
- *   @initial_ns: return the initial namespace (i.e. init_net_ns)
- */
-struct kobj_ns_type_operations {
-	enum kobj_ns_type type;
-	const void *(*current_ns)(void);
-	const void *(*netlink_ns)(struct sock *sk);
-	const void *(*initial_ns)(void);
-};
-
-int kobj_ns_type_register(const struct kobj_ns_type_operations *ops);
-int kobj_ns_type_registered(enum kobj_ns_type type);
-const struct kobj_ns_type_operations *kobj_child_ns_ops(struct kobject *parent);
-const struct kobj_ns_type_operations *kobj_ns_ops(struct kobject *kobj);
-
-const void *kobj_ns_current(enum kobj_ns_type type);
-const void *kobj_ns_netlink(enum kobj_ns_type type, struct sock *sk);
-const void *kobj_ns_initial(enum kobj_ns_type type);
-void kobj_ns_exit(enum kobj_ns_type type, const void *ns);
-
-
 /**
  * struct kset - a set of kobjects of a specific type, belonging to a specific subsystem.
  *
include/linux/kobject_ns.h new file +56 -0

56 lines not on this page · raw message

include/linux/sysfs.h +1 -0
@@ -16,6 +16,7 @@
 #include <linux/errno.h>
 #include <linux/list.h>
 #include <linux/lockdep.h>
+#include <linux/kobject_ns.h>
 #include <asm/atomic.h>
 
 struct kobject;