Skip to contentSkip to conversation

Introduce barrier2(a, b) (was: Re: [PATCH tip/core/rcu 08/10] rcu: Add a TINY_PREEMPT_RCU)

RFC Mathieu Desnoyers 1 participant 1 message Aug 17, 2010

lore
Share & tools
lore
#0 lore raw

(re-threaded because this looks like a whole new topic here)

Quoted 15 lines · * Lai Jiangshan ([email protected]) wrote:
Quoted 14 lines · Paul E. McKenney
Quoted 11 lines · Mathieu Desnoyers

--(t->rcu_read_lock_nesting)

could be split in two distinct operations:

read t->rcu_read_lock_nesting
decrement t->rcu_read_lock_nesting

Note that in order to know the result required to pass the sequence point "&&" (the test), we only need to perform the read, not the decrement. AFAIU, gcc would be in its rights to move the t->rcu_read_lock_nesting update after the volatile access.

Quoted 5 lines
Quoted 2 lines

I will run this by some compiler experts.

We can just use "read and decrement statements" instead of "--" to avoid dependency from compilers.

Maybe it is time to introduce a more specific class of compiler barriers so developers won't be tempted to use volatile accesses. I propose:

#define barrier2(a, b) __asm__ __volatile__("": "+rm"(a), "+rm"(b))

(Disclaimer: the barrier2() above should be run through compiler experts to ensure that it does the same as a "memory" clobber applied specifically to "a" and "b")

I assume you are proposing something like:

read t->rcu_read_lock_nesting
decrement t->rcu_read_lock_nesting
barrier(); /* some nice comment */
read "special" value
...

I agree that explicitly coding the barrier() forces us to document the need for compiler ordering here. This would be a bit more verbose, and IMHO good in this case. Volatile accesses "work", but does not do a very good documentation job. We could argue, in favor of volatile, that they only apply ordering to the volatile accesses, not all other accesses around, which is a weaker constraint and therefore does not limit compiler optimisations as much as barrier().

With something like barrier2(), we can do the following, which does the best of both worlds: specific compiler ordering (without volatiles!!) and good documentation. Moreover, it does not order with respect to other volatile accesses we don't care about.

void __rcu_read_unlock(void)

{
	struct task_struct *t = current;
	barrier();  /* needed if we ever invoke rcu_read_unlock in rcutiny.c */
	if (--t->rcu_read_lock_nesting == 0) {
		/*
		 * Update rcu_read_lock_nesting before reading
		 * rcu_read_unlock_special so we don't miss a
		 * preemption.
		 */
		barrier2(t->rcu_read_lock_nesting, t->rcu_read_unlock_special);
		if (unlikely(t->rcu_read_unlock_special))
			rcu_read_unlock_special(t);
	}
#ifdef CONFIG_PROVE_LOCKING
	WARN_ON_ONCE(t->rcu_read_lock_nesting < 0);

#endif /* #ifdef CONFIG_PROVE_LOCKING */
}

Thoughts ?

Thanks,

Mathieu

Signature · 4 lines
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com