vlan: Match underlying dev carrier on vlan add
Subsystems (2)
PATCH 1/1 vlan: Match underlying dev carrier on vlan add
When adding a new vlan, if the underlying interface has no carrier, then the newly added vlan interface should also have no carrier. At present, this is not true - the newly added vlan is added with carrier up. Fix by checking state of real device.
Signed-off-by Phil Oester <[email protected]>
net/8021q/vlan_dev.c +2 -1
@@ -510,7 +510,8 @@ static int vlan_dev_open(struct net_device *dev)if (vlan->flags &VLAN_FLAG_GVRP )vlan_gvrp_request_join (dev); -netif_carrier_on (dev); +if (netif_carrier_ok (real_dev)) +netif_carrier_on (dev);return 0 ; clear_allmulti:
From: Phil Oester <[email protected]>
Date: Tue, 17 Aug 2010 21:45:08 -0700
Quoted 6 lines
When adding a new vlan, if the underlying interface has no carrier, then the newly added vlan interface should also have no carrier. At present, this is not true - the newly added vlan is added with carrier up. Fix by checking state of real device.
Signed-off-by Phil Oester <[email protected]>
Applied, thanks Phil.