Skip to contentSkip to conversation

savevm: Reset last block info at beginning of each save

PATCH RESEND In review Alex Williamson 2 participants 2 messages Aug 18, 2010

lore
Share & tools
lore

Alex Williamson

author
#0 lore raw

PATCH RESEND 1/1 savevm: Reset last block info at beginning of each save

If we save more than once we need to reset the last block info or else only the first save has the actual block info and each subsequent save will only use continue flags, making them unloadable independently.

Found-by Miguel Di Ciurcio Filho <[email protected]>
Signed-off-by Alex Williamson <[email protected]>

---

 arch_init.c |    7 +++++--
 1 files changed, 5 insertions(+), 2 deletions(-)
arch_init.c +5 -2
index 47bb4b2..e0bd18c 100644
@@ -104,10 +104,11 @@ static int is_dup_page(uint8_t *page, uint8_t ch)
     return 1;
 }
 
+static RAMBlock *last_block;
+static ram_addr_t last_offset;
+
 static int ram_save_block(QEMUFile *f)
 {
-    static RAMBlock *last_block = NULL;
-    static ram_addr_t last_offset = 0;
     RAMBlock *block = last_block;
     ram_addr_t offset = last_offset;
     ram_addr_t current_addr;

@@ -231,6 +232,8 @@ int ram_save_live(Monitor *mon, QEMUFile *f, int stage, void *opaque)
     if (stage == 1) {
         RAMBlock *block;
         bytes_transferred = 0;
+        last_block = NULL;
+        last_offset = 0;
 
         /* Make sure all dirty bits are set */
         QLIST_FOREACH(block, &ram_list.blocks, next) {