Skip to contentSkip to conversation

send.2, recv.2: Fixed type of msg_controllen in struct msghdr

PATCH In review Nicholas Hunt 2 participants 2 messages Aug 19, 2010 – Aug 29, 2010 Man-pages: manual pages for Linux -- Sections 2, 3, 4, 5, and 7

lore
Share & tools
lore

Nicholas Hunt

author
#0 lore raw

PATCH 1/1 send.2, recv.2: Fixed type of msg_controllen in struct msghdr

Hello,

This patch fixes the type of msg_controllen in the struct msghdr definition given in send.2 and recv.2 to match the definition in glibc and the kernel. Applies cleanly to the current head of git (sha hash:
55d56b71...).

-Nick

man2/recv.2 +1 -1
index 9431b5c..d5eaf33 100644
@@ -304,7 +304,7 @@ struct msghdr {
     struct iovec *msg_iov;        /* scatter/gather array */
     size_t        msg_iovlen;     /* # elements in msg_iov */
     void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */
     int           msg_flags;      /* flags on received message */
 };
 .fi
man2/send.2 +1 -1
index c99b77a..c9e76b0 100644
@@ -250,7 +250,7 @@ struct msghdr {
     struct iovec *msg_iov;        /* scatter/gather array */
     size_t        msg_iovlen;     /* # elements in msg_iov */
     void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */
     int           msg_flags;      /* flags on received message */
 };
 .fi
Signature · 3 lines
Computer Science and Engineering, University of Washington
E-mail   : [email protected]
PGP Key  : http://students.washington.edu/nhunt/cs.asc
#1 lore raw

Hello Nicholas,

Quoted 6 lines · Nicholas Hunt

Hello,

This patch fixes the type of msg_controllen in the struct msghdr definition given in send.2 and recv.2 to match the definition in glibc and the kernel. Applies cleanly to the current head of git (sha hash:
55d56b71...).

This was already a know issue, see
http://sourceware.org/bugzilla/show_bug.cgi?id=2448
See also the NOTES on each page.

However, your patch is probably still a good idea. I applied it for man-pages 2.26.

Thanks,

Michael

Quoted 34 lines
(quoted diff) +0 -1
-Nick
man2/recv.2 +0 -0
index 9431b5c..d5eaf33 100644
@@ -304,7 +304,7 @@ struct msghdr {

    struct iovec *msg_iov;        /* scatter/gather array */ size_t        msg_iovlen;     /* # elements in msg_iov */ void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */ int           msg_flags;      /* flags on received message */ };
 .fi

man2/send.2 +0 -0
index c99b77a..c9e76b0 100644
@@ -250,7 +250,7 @@ struct msghdr {

    struct iovec *msg_iov;        /* scatter/gather array */ size_t        msg_iovlen;     /* # elements in msg_iov */ void         *msg_control;    /* ancillary data, see below */
-    socklen_t     msg_controllen; /* ancillary data buffer len */
+    size_t        msg_controllen; /* ancillary data buffer len */ int           msg_flags;      /* flags on received message */ };
 .fi

--
Computer Science and Engineering, University of Washington E-mail   : [email protected] PGP Key  : http://students.washington.edu/nhunt/cs.asc

Signature · 7 lines
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface" http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html