Skip to contentSkip to conversation

commit a37c36f4 breaks several non-85xx boards

U-Boot Wolfgang Denk 3 participants 4 messages Aug 18, 2010 – Aug 19, 2010

lore
Share & tools
lore
#0 lore raw

Dear Kim,

your commit a37c36f4: "powerpc/8xxx: query feature reporting register for num cores on unknown cpus" breaks a number of boards with error messages like here:

cpu.c: In function 'cpu_numcores':
cpu.c:113: error: 'CONFIG_SYS_MPC85xx_PIC_ADDR' undeclared (first use in this function) cpu.c:113: error: (Each undeclared identifier is reported only once cpu.c:113: error: for each function it appears in.)
cpu.c:118: error: 'MPC85xx_PICFRR_NCPU_MASK' undeclared (first use in this function) cpu.c:119: error: 'MPC85xx_PICFRR_NCPU_SHIFT' undeclared (first use in this function) make[1]: *** [/work/wd/tmp-ppc/arch/powerpc/cpu/mpc8xxx/cpu.o] Error 1
make: *** [/work/wd/tmp-ppc/arch/powerpc/cpu/mpc8xxx/lib8xxx.a] Error 2

Affected board configurations: MPC8610HPCD, MPC8641HPCN, MPC8641HPCN_36BIT, XPEDITE5170, sbc8641d.

Please fix.

Thanks in advance.

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Another war ... must it always be so?  How many comrades have we lost
in this way? ...  Obedience.  Duty.  Death, and more death ...
	-- Romulan Commander, "Balance of Terror", stardate 1709.2
#1 lore raw
Quoted 5 lines · On Wed, 18 Aug 2010 23:50:26 +0200 Wolfgang Denk <[email protected]> wrote:

your commit a37c36f4: "powerpc/8xxx: query feature reporting register for num cores on unknown cpus" breaks a number of boards with error messages like here:

Please fix.

I posted a fix when you first brought this up. Whilst I sent it as a reply to the thread, it's turns up on its own in the archives:

http://lists.denx.de/pipermail/u-boot/2010-August/075176.html

And here Kumar applies it:

http://lists.denx.de/pipermail/u-boot/2010-August/075756.html

It just hasn't reached his public tree yet.

Thanks,

Kim

#2 lore raw
Quoted 16 lines · Kim Phillips
Quoted 5 lines · On Wed, 18 Aug 2010 23:50:26 +0200 Wolfgang Denk <[email protected]> wrote:

your commit a37c36f4: "powerpc/8xxx: query feature reporting register for num cores on unknown cpus" breaks a number of boards with error messages like here:

Please fix.

I posted a fix when you first brought this up. Whilst I sent it as a reply to the thread, it's turns up on its own in the archives:

http://lists.denx.de/pipermail/u-boot/2010-August/075176.html

And here Kumar applies it:

Quoted 7 lines

http://lists.denx.de/pipermail/u-boot/2010-August/075756.html

It just hasn't reached his public tree yet.

Thanks,

Kim

Sorry, I had a few other fixes I was queuing up for a pull request.

- k

#3 lore raw

Dear Kumar Gala,

Quoted 2 lines · In message <[email protected]> you wrote:

Sorry, I had a few other fixes I was queuing up for a pull request.

Please do, as I want to get a -rc1 out asap (tonight?)

Best regards,

Wolfgang Denk

Signature · 6 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of COBOL cripples the mind; its teaching  should,  therefore,
be regarded as a criminal offence.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5