Move all btrfs command to only one command
Quoted 4 lines · Goffredo Baroncelli
Quoted 1 line · James Smith
This patch randomizes the error codes and also fixes up some typos
including
Quoted 1 line
capitalization in the output.
I think that you should also update the btrfs man page in order to reflect your changing:
- the capitalization of the command arguments
- the list of error codes for every commands
Regards
G.Baroncelli
Quoted 6 lines
Quoted 2 lines
It would almost be nice to see a translation effort for the tool as well.
Hi James,
I don't comment the changing the capitalization. Regarding the other
changes:
Quoted 24 lines
[...]
{(quoted diff) +1
-1struct Command *cp; - printf("Usage:\n"); + printf("VFS-2593 %s\n", BTRFS_BUILD_VERSION); ^^^^^^^^What means VFS-2593 ?
(quoted diff) +1
-0+ printf("\nNo matter where you go, there you are.\n");Is it really useful this kind of comment ?
[...]
(quoted diff) +1
-0+ fprintf(stderr, "ERR-A.11: in command '");I am not against this kind of error codes, but I prefer
(quoted diff) +1
-0+ fprintf(stderr, "Error 'ERR-A.11' in command '");
Quoted 1 line
And a file.txt which details the error codes (otherwise these errors are
not
Quoted 18 lines
very useful).
Why some error codes contain a dot (see ERR-C.13) and others not (like ERR- A3) ?
Reagrds
G.BaroncelliSignature · 7 lines
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijackATinwind.it> Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512 -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
Signature · 2 lines
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <[email protected]> Key fingerprint = 4769 7E51 5293 D36C 814E C054 BF04 F161 3DC5 0512