Skip to contentSkip to conversation

i915: 2.6.36-rc2 hoses my Intel display

DISCUSSION Jonathan Corbet 3 participants 10 messages Aug 23, 2010 – Aug 26, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

So I decided to fire up -rc2 today to see what would happen...the results are best described by the attached images. Something is clearly scrambled between my hardware and the i915 driver. Display with X is hosed, but things go weird before X gets a chance to run (it is worth noting that the initial output from the kernel is legible).

FWIW, my hardware is:

00:02.1 Display controller: Intel Corporation 82Q35 Express Integrated Graphics Controller (rev 02)
Subsystem: Dell OptiPlex 755
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
Region 0: Memory at fea80000 (32-bit, non-prefetchable) [size=512K]
Capabilities: [d0] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA PME(D0-,D1-,D2-,D3hot-,D3cold-)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-

What else can I provide to help track this one down?

Thanks,

jon

#1 lore raw
Quoted 5 lines · On Mon, 23 Aug 2010 11:01:45 -0600 Jonathan Corbet <[email protected]> wrote:

So I decided to fire up -rc2 today to see what would happen...the results are best described by the attached images. Something is clearly scrambled between my hardware and the i915 driver. Display with X is hosed, but things go weird before X gets a chance to run (it is worth noting that the initial output from the kernel is legible).

I went ahead and bisected the problem, which was added between -rc1 and -rc2. The end result is this:

32aad86fe88e7323d4fc5e9e423abcee0d55a03d is the first bad commit commit 32aad86fe88e7323d4fc5e9e423abcee0d55a03d

Author: Chris Wilson <[email protected]>
Date:   Wed Aug 4 13:50:25 2010 +0100

drm/i915/sdvo: Propagate errors from reading/writing control bus.

I don't know the driver or the hardware and can't begin to guess what went wrong in that patch, but, hopefully, the information is useful to somebody. Please let me know if there's anything else I can do to help track this down.

Thanks,

jon

#2 lore raw
Quoted 2 lines · Jonathan Corbet

I went ahead and bisected the problem, which was added between -rc1 and -rc2. The end result is this:

Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which i2c_transfer() failed.

drivers/gpu/drm/i915/intel_sdvo.c +7 -2
index 093e914..6afc7cf 100644
@@ -269,7 +269,7 @@ static bool intel_sdvo_read_byte(struct intel_sdvo *intel_sdvo, u8 addr, u8 *ch)
 		return true;
 	}
 
-	DRM_DEBUG_KMS("i2c transfer returned %d\n", ret);
+	WARN(1, "i2c transfer failed, ret=%d\n", ret);
 	return false;
 }
 
@@ -284,8 +284,13 @@ static bool intel_sdvo_write_byte(struct intel_sdvo *intel_sdvo, int addr, u8 ch
 			.buf = out_buf,
 		}
 	};
+	int ret;
+
+	if ((ret = i2c_transfer(intel_sdvo->base.i2c_bus, msgs, 1)) == 1)
+		return true;
 
-	return i2c_transfer(intel_sdvo->base.i2c_bus, msgs, 1) == 1;
+	WARN(1, "i2c transfer failed, ret=%d\n", ret);
+	return false;
 }
 
 #define SDVO_CMD_NAME_ENTRY(cmd) {cmd, #cmd}
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#3 lore raw
Quoted 3 lines · On Mon, 23 Aug 2010 23:36:55 +0100 Chris Wilson <[email protected]>…

Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which i2c_transfer() failed.

OK, I tried it, but neither warning triggers.

Don't know if it helps or not, but I tried booting with drm.debug=0x05. The result was truly vast amounts of stuff like this:

Aug 23 17:20:59 bike kernel: m:drm_ioctl], pid=2032, cmd=0x6458

nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x645 m:drm_ioctl], pid=2032, cmd=0x6458 m:drm_ioctl], pid=2032, cmd=0x6458, m:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458 m:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458 m:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458 m:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458 m:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458, m:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, cmd=0x6458 nm:drm_ioctl], pid=2032, c

The above is one line from the system log; I took the liberty of wrapping it for readability.

jon

#4 lore raw
Quoted 8 lines · Jonathan Corbet
Quoted 3 lines · On Mon, 23 Aug 2010 23:36:55 +0100 Chris Wilson <[email protected]>…

Taking the patch at face value, the cause should be a mistake in error handling. So the first step would be to identify which i2c_transfer() failed.

OK, I tried it, but neither warning triggers.

Sigh, that sounds like I screwed the patch up instead. Thanks.

Quoted 5 lines

Don't know if it helps or not, but I tried booting with drm.debug=0x05. The result was truly vast amounts of stuff like this:

Aug 23 17:20:59 bike kernel: m:drm_ioctl], pid=2032, cmd=0x6458

nm:drm_ioctl], pid=2032, cmd=0x6458, nm:drm_ioctl], pid=2032, cmd=0x645

[snip]

Quoted 3 lines

The above is one line from the system log; I took the liberty of wrapping it for readability.

Hmm, probably bailing out of the ioctl before hitting the newline. drm.debug=0x4 should print the right information for this bug.

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#5 lore raw
Quoted 1 line · On Tue, 24 Aug 2010 00:37:52 +0100 Chris Wilson <[email protected]>…

drm.debug=0x4 should print the right information for this bug.

That doesn't seem to give me any output at all.

One thing I noticed, though, is that I occasionally get something like:

Aug 23 17:43:14 bike kernel: [  142.920185] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, expect flickering: entries required = 51, available = 28.

They seem to come in threes, for whatever that's worth.

Thanks,

jon

#6 lore raw
Quoted 5 lines · Jonathan Corbet
Quoted 1 line · On Tue, 24 Aug 2010 00:37:52 +0100 Chris Wilson <[email protected]>…

drm.debug=0x4 should print the right information for this bug.

Quoted 7 lines

That doesn't seem to give me any output at all.

One thing I noticed, though, is that I occasionally get something like:

Aug 23 17:43:14 bike kernel: [  142.920185] [drm:intel_calculate_wm] *ERROR* Insufficient FIFO for plane, expect flickering: entries required = 51, available = 28.

They seem to come in threes, for whatever that's worth.

In threes. Hmm, one for primary, cursor and self-refresh. drm.debug=0xe would be interesting to see what the pixel clock is.

Can you grab one before the bad commit and one after? If there is a change that may help pin-point the mistake. Or indicate further problems...

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#7 lore raw
Quoted 5 lines · On Tue, 24 Aug 2010 00:55:54 +0100 Chris Wilson <[email protected]>…

In threes. Hmm, one for primary, cursor and self-refresh. drm.debug=0xe would be interesting to see what the pixel clock is.

Can you grab one before the bad commit and one after? If there is a change that may help pin-point the mistake. Or indicate further problems...

OK, three files attached; drm.good is from 2.6.35, drm.bad is from 2.6.36-rc2. I also stripped the times and did a diff, in case that's useful.

If you'd like output from right around the bad commit, say the word; that will take a bit of building time (I didn't keep all those bisect kernels around) but I can do it.

Thanks,

jon

drm.bad.notime renamed from drm.good.notime +106 -92
@@ -1,36 +1,42 @@
+[drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
+[drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
+[drm:intel_sdvo_detect], SDVO response 1 0
+[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
+[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:drm_crtc_helper_set_config], 
-[drm:drm_crtc_helper_set_config], crtc: ffff8800be143000 3 fb: ffff8800bc1744b0 connectors: ffff8800be1054e0 num_connectors: 1 (x, y) (0, 0)
-[drm:drm_crtc_helper_set_config], setting connector 8 crtc to ffff8800be143000
+#connectors=1 (x y) (0 0)
+to [CRTC:3]
 [drm:i915_driver_open], 
 [drm:drm_crtc_helper_set_config], 
-[drm:drm_crtc_helper_set_config], crtc: ffff8800be143000 3 fb: ffff8800bc1744b0 connectors: ffff8800be1054e0 num_connectors: 1 (x, y) (0, 0)
-[drm:drm_crtc_helper_set_config], setting connector 8 crtc to ffff8800be143000
+#connectors=1 (x y) (0 0)
+to [CRTC:3]
 [drm:drm_crtc_helper_set_config], 
-[drm:drm_crtc_helper_set_config], crtc: ffff8800be144000 4 fb: ffff8800bc1744b0 connectors: ffff8800be105500 num_connectors: 0 (x, y) (0, 0)
+#connectors=0 (x y) (0 0)
 [drm:drm_crtc_helper_set_config], crtc has no fb, full mode set
-[drm:drm_crtc_helper_set_config], setting connector 8 crtc to ffff8800be143000
+to [CRTC:3]
+[drm:i915_get_vblank_counter], trying to get vblank count for disabled pipe 1
 [drm:intel_update_watermarks], plane A (pipe 0) clock: 154000
 [drm:i9xx_get_fifo_size], FIFO size - (0x00001d9c) A: 28
 [drm:i9xx_get_fifo_size], FIFO size - (0x00001d9c) B: 31
-[drm:intel_calculate_wm], FIFO entries required for mode: 48
-[drm:intel_calculate_wm], FIFO watermark level: -22
+[drm:intel_calculate_wm], FIFO entries required for mode: 49
+[drm:intel_calculate_wm], FIFO watermark level: -23
+*ERROR* Insufficient FIFO for plane, expect flickering: entries required = 51, available = 28.
 [drm:intel_calculate_wm], FIFO entries required for mode: 0
 [drm:intel_calculate_wm], FIFO watermark level: 29
 [drm:i9xx_update_wm], FIFO watermarks - A: 1, B: 29
-[drm:i9xx_update_wm], self-refresh entries: 60
-[drm:i9xx_update_wm], Setting FIFO watermarks - A: 1, B: 29, C: 2, SR 35
-[drm:i915_get_vblank_counter], trying to get vblank count for disabled pipe 1
+[drm:i9xx_update_wm], self-refresh entries: 120
+[drm:i9xx_update_wm], Setting FIFO watermarks - A: 1, B: 29, C: 2, SR 1
 [drm:i915_driver_open], 
-[drm:drm_mode_getresources], Counted 2 2 2
-[drm:drm_mode_getresources], Counted 2 2 2
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+ENCODERS[2]
+ENCODERS[2]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
@@ -38,7 +44,9 @@
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+e1000e: eth0 NIC Link is Up 100 Mbps Full Duplex, Flow Control: RX/TX
+e1000e 0000:00:19.0: eth0: 10/100 speed: disabling TSO
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -52,17 +60,15 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-e1000e: eth0 NIC Link is Up 100 Mbps Full Duplex, Flow Control: RX/TX
-e1000e 0000:00:19.0: eth0: 10/100 speed: disabling TSO
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
@@ -70,7 +76,7 @@
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -84,23 +90,24 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
+init[1]: rc-local.service: main process exited, code=exited, status=208
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -114,33 +121,33 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_addfb], [FB:25]
+[drm:drm_mode_setcrtc], [CRTC:3]
+[drm:drm_mode_setcrtc], [CONNECTOR:8:DVI-D-1]
 [drm:drm_crtc_helper_set_config], 
-[drm:drm_crtc_helper_set_config], crtc: ffff8800be143000 3 fb: ffff8800bca67cc0 connectors: ffff8800b9a3ddd8 num_connectors: 1 (x, y) (0, 0)
-[drm:drm_crtc_helper_set_config], setting connector 8 crtc to ffff8800be143000
+#connectors=1 (x y) (0 0)
+to [CRTC:3]
 [drm:intel_pipe_set_base], Writing base 01800000 00000000 0 0 4096
+[drm:intel_update_fbc], 
+[drm:intel_wait_for_vblank], vblank wait timed out
 [drm:intel_crtc_cursor_set], 
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
-[drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
-[drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
-[drm:intel_sdvo_detect], SDVO response 1 0
-[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -154,15 +161,15 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
@@ -170,7 +177,7 @@
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -184,15 +191,15 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
@@ -200,7 +207,7 @@
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -214,15 +221,15 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 5:
-[drm:drm_helper_probe_single_connector_modes], VGA-1
-[drm:drm_helper_probe_single_connector_modes], VGA-1 is disconnected
-[drm:drm_mode_getconnector], connector id 8:
-[drm:drm_helper_probe_single_connector_modes], DVI-D-1
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:5:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:5:VGA-1]
+disconnected
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
+[drm:drm_helper_probe_single_connector_modes], [CONNECTOR:8:DVI-D-1]
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
@@ -230,7 +237,7 @@
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
-[drm:drm_helper_probe_single_connector_modes], Probed modes for DVI-D-1
+probed modes :
 [drm:drm_mode_debug_printmodeline], Modeline 10:"1920x1200" 60 154000 1920 1968 2000 2080 1200 1203 1209 1235 0x48 0x9
 [drm:drm_mode_debug_printmodeline], Modeline 11:"1600x1200" 60 162000 1600 1664 1856 2160 1200 1201 1204 1250 0x40 0x5
 [drm:drm_mode_debug_printmodeline], Modeline 13:"1680x1050" 60 146250 1680 1784 1960 2240 1050 1053 1059 1089 0x40 0x6
@@ -244,10 +251,17 @@
 [drm:drm_mode_debug_printmodeline], Modeline 17:"640x480" 75 31500 640 656 720 840 480 481 484 500 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 18:"640x480" 60 25200 640 656 752 800 480 490 492 525 0x40 0xa
 [drm:drm_mode_debug_printmodeline], Modeline 19:"720x400" 70 28320 720 738 846 900 400 412 414 449 0x40 0x6
-[drm:drm_mode_getconnector], connector id 8:
+[drm:drm_mode_getconnector], [CONNECTOR:8:?]
 [drm:intel_gpu_idle_timer], idle timer fired, downclocking
 [drm:intel_crtc_idle_timer], idle timer fired, downclocking
+[drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
+[drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
+[drm:intel_sdvo_detect], SDVO response 1 0
+[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
+[drm:intel_sdvo_debug_write], SDVOB: W: 7A 02                      (SDVO_CMD_SET_CONTROL_BUS_SWITCH)
 [drm:intel_gpu_idle_timer], idle timer fired, downclocking
+[drm:intel_gpu_idle_timer], idle timer fired, downclocking
+[drm:intel_crtc_idle_timer], idle timer fired, downclocking
 [drm:intel_sdvo_debug_write], SDVOB: W: 0B                         (SDVO_CMD_GET_ATTACHED_DISPLAYS)
 [drm:intel_sdvo_debug_response], SDVOB: R: 01 00                   (Success)
 [drm:intel_sdvo_detect], SDVO response 1 0
#8 lore raw
Quoted 12 lines · Jonathan Corbet
Quoted 5 lines · On Tue, 24 Aug 2010 00:55:54 +0100 Chris Wilson <[email protected]>…

In threes. Hmm, one for primary, cursor and self-refresh. drm.debug=0xe would be interesting to see what the pixel clock is.

Can you grab one before the bad commit and one after? If there is a change that may help pin-point the mistake. Or indicate further problems...

OK, three files attached; drm.good is from 2.6.35, drm.bad is from 2.6.36-rc2. I also stripped the times and did a diff, in case that's useful.

[snip]

Quoted 5 lines

-[drm:intel_calculate_wm], FIFO entries required for mode: 48 -[drm:intel_calculate_wm], FIFO watermark level: -22
+[drm:intel_calculate_wm], FIFO entries required for mode: 49 +[drm:intel_calculate_wm], FIFO watermark level: -23
+*ERROR* Insufficient FIFO for plane, expect flickering: entries required = 51, available = 28.

Quoted 8 lines

[drm:intel_calculate_wm], FIFO entries required for mode: 0 [drm:intel_calculate_wm], FIFO watermark level: 29 [drm:i9xx_update_wm], FIFO watermarks - A: 1, B: 29
-[drm:i9xx_update_wm], self-refresh entries: 60 -[drm:i9xx_update_wm], Setting FIFO watermarks - A: 1, B: 29, C: 2, SR 35 -[drm:i915_get_vblank_counter], trying to get vblank count for disabled pipe 1 +[drm:i9xx_update_wm], self-refresh entries: 120 +[drm:i9xx_update_wm], Setting FIFO watermarks - A: 1, B: 29, C: 2, SR 1

I'm going to focus on this since this could account for the on-screen corruption. Here we suddenly double the computed minimal FIFO size for self-refresh and due to a separate bug program a minimal low watermark.

That should addressed with
http://cgit.freedesktop.org/~ickle/linux-2.6/commit/?h=drm-testing&id=30c127264ef9729bcef1d9901718f9a8a47be6a4
however that patch isn't quite ready yet since Jesse pointed out that some chipsets do indeed want a high-watermark instead of the low-watermark used, at least, for gen3+.

The question though is why that bad commit would cause a doubling of the SR. Thanks for the diff, I now know that I need to look more closely at the mode-fixup for SDVO.

Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
#9 lore raw
In reply to Jonathan Corbet
Quoted 20 lines · On poniedziałek, 23 sierpnia 2010 o 19:01:45 Jonathan Corbet wrote:

So I decided to fire up -rc2 today to see what would happen...the results are best described by the attached images. Something is clearly scrambled between my hardware and the i915 driver. Display with X is hosed, but things go weird before X gets a chance to run (it is worth noting that the initial output from the kernel is legible).

FWIW, my hardware is:

00:02.1 Display controller: Intel Corporation 82Q35 Express Integrated Graphics Controller (rev 02) Subsystem: Dell OptiPlex 755
Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr-
Stepping- SERR- FastB2B- DisINTx- Status: Cap+ 66MHz- UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort- <TAbort- <MAbort- >SERR- <PERR- INTx-
Latency: 0
Region 0: Memory at fea80000 (32-bit, non-prefetchable) [size=512K]
Capabilities: [d0] Power Management version 2
Flags: PMEClk- DSI+ D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot-,D3cold-) Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-

Quoted 1 line

What else can I provide to help track this one down?

I created a Bugzilla entry at
https://bugzilla.kernel.org/show_bug.cgi?id=17151
for your bug report, please add your address to the CC list in there, thanks!

Signature · 2 lines
Maciej Rutecki
http://www.maciek.unixy.pl