Skip to contentSkip to conversation

Process -trace using QemuOptsList

PATCH In review Prerna Saxena 2 participants 2 messages Aug 27, 2010

lore
Share & tools
lore

Prerna Saxena

author
#0 lore raw

PATCH v2 1/1 Process -trace using QemuOptsList

[PATCH] Add -trace file FILENAME switch to qemu startup command.
This processes the argument using QemuOptsList

Signed-off-by Prerna Saxena <[email protected]>
---
 qemu-config.c |   18 ++++++++++++++++++
 qemu-config.h |    3 +++
 vl.c          |    5 ++++-
 3 files changed, 25 insertions(+), 1 deletions(-)
qemu-config.c +18 -0
index 95abe61..9106511 100644
@@ -294,6 +294,21 @@ QemuOptsList qemu_mon_opts = {
     },
 };
 
+#ifdef CONFIG_SIMPLE_TRACE
+QemuOptsList qemu_trace_opts = {
+    .name = "trace",
+    .implied_opt_name = "trace",
+    .head = QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head),
+    .desc = {
+        {
+            .name = "file",
+            .type = QEMU_OPT_STRING,
+        },
+        { /* end if list */ }
+    },
+};
+#endif
+
 QemuOptsList qemu_cpudef_opts = {
     .name = "cpudef",
     .head = QTAILQ_HEAD_INITIALIZER(qemu_cpudef_opts.head),

@@ -352,6 +367,9 @@ static QemuOptsList *vm_config_groups[] = {
     &qemu_global_opts,
     &qemu_mon_opts,
     &qemu_cpudef_opts,
+#ifdef CONFIG_SIMPLE_TRACE
+    &qemu_trace_opts,
+#endif
     NULL,
 };
qemu-config.h +3 -0
index dca69d4..4db2fb5 100644
@@ -14,6 +14,9 @@ extern QemuOptsList qemu_rtc_opts;
 extern QemuOptsList qemu_global_opts;
 extern QemuOptsList qemu_mon_opts;
 extern QemuOptsList qemu_cpudef_opts;
+#ifdef CONFIG_SIMPLE_TRACE
+extern QemuOptsList qemu_trace_opts;
+#endif
 
 QemuOptsList *qemu_find_opts(const char *group);
 int qemu_set_option(const char *str);
vl.c +4 -1
index 99664e9..0ff04e9 100644
@@ -2599,7 +2599,10 @@ int main(int argc, char **argv, char **envp)
                 break;
 #ifdef CONFIG_SIMPLE_TRACE
             case QEMU_OPTION_trace:
-                trace_file = optarg;
+                opts = qemu_opts_parse(&qemu_trace_opts, optarg, 0);
+                if (opts) {
+                    trace_file = qemu_opt_get(opts, "file");
+                }
                 break;
 #endif
             case QEMU_OPTION_readconfig:
Signature · 10 lines
1.7.2.1



-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India
#1 lore raw
Quoted 5 lines · Prerna Saxena

[PATCH] Add -trace file FILENAME switch to qemu startup command.
This processes the argument using QemuOptsList

Signed-off-by Prerna Saxena <[email protected]>

Thanks, I will merge this for tracing v2.

Stefan