ARM: Samsung S3C: Move/use the S3C common GPIO IRQ type

PATCH In review Kyungmin Park 2 participants 5 messages Aug 30, 2010 – Sep 1, 2010

Subsystems (3)

Arm (32-bit) Arm sub-architectures Arm Samsung Exynos

lore

Share & tools

lore

Kyungmin Park

author

2010-08-30 11:47 UTC #0 lore raw

PATCH 3/3 ARM: Samsung S3C: Move/use the S3C common GPIO IRQ type

From: Kyungmin Park <[email protected]>

Samsung S3C series have the common GPIO IRQ type for all S3C series.

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s3c64xx/irq-eint.c                  |   12 ++++++------
 arch/arm/plat-s3c24xx/irq.c                       |   14 +++++++-------
 arch/arm/plat-s5p/irq-eint.c                      |    2 --
 arch/arm/plat-samsung/include/plat/gpio-core.h    |    6 ++++++
 arch/arm/plat-samsung/include/plat/regs-irqtype.h |   21 ---------------------
 5 files changed, 19 insertions(+), 36 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-irqtype.h

arch/arm/mach-s3c64xx/irq-eint.c +6 -6

index 5682d6a..c079147 100644
@@ -21,8 +21,8 @@
 
 #include <asm/hardware/vic.h>
 
-#include <plat/regs-irqtype.h>
 #include <mach/regs-gpio.h>
+#include <plat/gpio-core.h>
 #include <plat/gpio-cfg.h>
 
 #include <mach/map.h>

@@ -85,23 +85,23 @@ static int s3c_irq_eint_set_type(unsigned int irq, unsigned int type)
 		break;
 
 	case IRQ_TYPE_EDGE_RISING:
-		newvalue = S3C2410_EXTINT_RISEEDGE;
+		newvalue = S3C_GPIO_EDGE_RISING;
 		break;
 
 	case IRQ_TYPE_EDGE_FALLING:
-		newvalue = S3C2410_EXTINT_FALLEDGE;
+		newvalue = S3C_GPIO_EDGE_FALLING;
 		break;
 
 	case IRQ_TYPE_EDGE_BOTH:
-		newvalue = S3C2410_EXTINT_BOTHEDGE;
+		newvalue = S3C_GPIO_EDGE_BOTH;
 		break;
 
 	case IRQ_TYPE_LEVEL_LOW:
-		newvalue = S3C2410_EXTINT_LOWLEV;
+		newvalue = S3C_GPIO_LEVEL_LOW;
 		break;
 
 	case IRQ_TYPE_LEVEL_HIGH:
-		newvalue = S3C2410_EXTINT_HILEV;
+		newvalue = S3C_GPIO_LEVEL_HIGH;
 		break;
 
 	default:

arch/arm/plat-s3c24xx/irq.c +7 -7

index ad0d44e..e1a6fe5 100644
@@ -23,12 +23,12 @@
 #include <linux/interrupt.h>
 #include <linux/ioport.h>
 #include <linux/sysdev.h>
+#include <linux/gpio.h>
 
 #include <asm/irq.h>
 #include <asm/mach/irq.h>
 
-#include <plat/regs-irqtype.h>
-
+#include <plat/gpio-core.h>
 #include <plat/cpu.h>
 #include <plat/pm.h>
 #include <plat/irq.h>

@@ -201,23 +201,23 @@ s3c_irqext_type(unsigned int irq, unsigned int type)
 			break;
 
 		case IRQ_TYPE_EDGE_RISING:
-			newvalue = S3C2410_EXTINT_RISEEDGE;
+			newvalue = S3C_GPIO_EDGE_RISING;
 			break;
 
 		case IRQ_TYPE_EDGE_FALLING:
-			newvalue = S3C2410_EXTINT_FALLEDGE;
+			newvalue = S3C_GPIO_EDGE_FALLING;
 			break;
 
 		case IRQ_TYPE_EDGE_BOTH:
-			newvalue = S3C2410_EXTINT_BOTHEDGE;
+			newvalue = S3C_GPIO_EDGE_BOTH;
 			break;
 
 		case IRQ_TYPE_LEVEL_LOW:
-			newvalue = S3C2410_EXTINT_LOWLEV;
+			newvalue = S3C_GPIO_LEVEL_LOW;
 			break;
 
 		case IRQ_TYPE_LEVEL_HIGH:
-			newvalue = S3C2410_EXTINT_HILEV;
+			newvalue = S3C_GPIO_LEVEL_HIGH;
 			break;
 
 		default:

arch/arm/plat-s5p/irq-eint.c +0 -2

index 4e0d94b..02d6ea2 100644
@@ -19,8 +19,6 @@
 
 #include <asm/hardware/vic.h>
 
-#include <plat/regs-irqtype.h>
-
 #include <mach/map.h>
 #include <plat/cpu.h>
 #include <plat/pm.h>

arch/arm/plat-samsung/include/plat/gpio-core.h +6 -0

index c8681e0..2aef589 100644
@@ -14,6 +14,12 @@
 #define GPIOCON_OFF	(0x00)
 #define GPIODAT_OFF	(0x04)
 
+#define S3C_GPIO_LEVEL_LOW		(0x00)
+#define S3C_GPIO_LEVEL_HIGH		(0x01)
+#define S3C_GPIO_EDGE_FALLING		(0x02)
+#define S3C_GPIO_EDGE_RISING		(0x04)
+#define S3C_GPIO_EDGE_BOTH		(0x06)
+
 #define S5P_GPIO_LEVEL_LOW		(0x00)
 #define S5P_GPIO_LEVEL_HIGH		(0x01)
 #define S5P_GPIO_EDGE_FALLING		(0x02)

arch/arm/plat-samsung/include/plat/regs-irqtype.h deleted +0 ~~-21~~

deleted file mode 100644
index c63cd3f..0000000
@@ -1,21 +0,0 @@
-/* arch/arm/plat-s3c/include/plat/regs-irqtype.h
- *
- * Copyright 2008 Simtec Electronics
- *      Ben Dooks <[email protected]>
- *      http://armlinux.simtec.co.uk/
- *
- * S3C - IRQ detection types.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- */
-
-/* values for S3C2410_EXTINT0/1/2 and other cpus in the series, including
- * the S3C64XX
-*/
-#define S3C2410_EXTINT_LOWLEV	 (0x00)
-#define S3C2410_EXTINT_HILEV	 (0x01)
-#define S3C2410_EXTINT_FALLEDGE	 (0x02)
-#define S3C2410_EXTINT_RISEEDGE	 (0x04)
-#define S3C2410_EXTINT_BOTHEDGE	 (0x06)

Signature · 1 line

1.5.3.3

Kukjin Kim

2010-08-30 12:09 UTC #1 lore raw

Quoted 5 lines · Kyungmin Park

From: Kyungmin Park <[email protected]>
Samsung S3C series have the common GPIO IRQ type for all S3C series.

I can't agree with your changing name. Why do you want to change the name? If you want to move S3C2410_EXTINT_XXX from regs-irqtype.h, just move without any changes.

But I'm still thinking why should we move the external interrupt definitions to plat/gpio-core.h...

Quoted 7 lines

Signed-off-by Kyungmin Park <[email protected]>

---
 arch/arm/mach-s3c64xx/irq-eint.c                  |   12 ++++++------
 arch/arm/plat-s3c24xx/irq.c                       |   14 +++++++-------
 arch/arm/plat-s5p/irq-eint.c                      |    2 --
 arch/arm/plat-samsung/include/plat/gpio-core.h    |    6 ++++++
 arch/arm/plat-samsung/include/plat/regs-irqtype.h |   21

---------------------

Review

Quoted 4 lines

 5 files changed, 19 insertions(+), 36 deletions(-)
 delete mode 100644 arch/arm/plat-samsung/include/plat/regs-irqtype.h

(quoted diff) +0 -0

b/arch/arm/mach-s3c64xx/irq-eint.c

arch/arm/mach-s3c64xx/irq-eint.c static int s3c_irq_eint_set_type(unsigned int irq,

Quoted 14 lines

index 5682d6a..c079147 100644

arch/arm/mach-s3c64xx/irq-eint.c +1 -1

@@ -21,8 +21,8 @@
 
 #include <asm/hardware/vic.h>
 
-#include <plat/regs-irqtype.h>
 #include <mach/regs-gpio.h>
+#include <plat/gpio-core.h>
 #include <plat/gpio-cfg.h>
 
 #include <mach/map.h>

@@ -85,23 +85,23 @@ static int s3c_irq_eint_set_type(unsigned int irq,

unsigned

Quoted 34 lines

arch/arm/mach-s3c64xx/irq-eint.c +5 -5

 int type)
 		break;
 
 	case IRQ_TYPE_EDGE_RISING:
-		newvalue = S3C2410_EXTINT_RISEEDGE;
+		newvalue = S3C_GPIO_EDGE_RISING;
 		break;
 
 	case IRQ_TYPE_EDGE_FALLING:
-		newvalue = S3C2410_EXTINT_FALLEDGE;
+		newvalue = S3C_GPIO_EDGE_FALLING;
 		break;
 
 	case IRQ_TYPE_EDGE_BOTH:
-		newvalue = S3C2410_EXTINT_BOTHEDGE;
+		newvalue = S3C_GPIO_EDGE_BOTH;
 		break;
 
 	case IRQ_TYPE_LEVEL_LOW:
-		newvalue = S3C2410_EXTINT_LOWLEV;
+		newvalue = S3C_GPIO_LEVEL_LOW;
 		break;
 
 	case IRQ_TYPE_LEVEL_HIGH:
-		newvalue = S3C2410_EXTINT_HILEV;
+		newvalue = S3C_GPIO_LEVEL_HIGH;
 		break;

arch/arm/mach-s3c64xx/irq-eint.c +0 -0

 	default:

arch/arm/plat-s3c24xx/irq.c +0 -0

index ad0d44e..e1a6fe5 100644

arch/arm/plat-s3c24xx/irq.c line 27

Quoted 5 lines

arch/arm/plat-s3c24xx/irq.c +1 -0

@@ -23,12 +23,12 @@
 #include <linux/interrupt.h>
 #include <linux/ioport.h>
 #include <linux/sysdev.h>
+#include <linux/gpio.h>

Why need this inclusion?

Review

Quoted 52 lines

arch/arm/plat-s3c24xx/irq.c +6 -7

 #include <asm/irq.h>
 #include <asm/mach/irq.h>
 
-#include <plat/regs-irqtype.h>
-
+#include <plat/gpio-core.h>
 #include <plat/cpu.h>
 #include <plat/pm.h>
 #include <plat/irq.h>

@@ -201,23 +201,23 @@ s3c_irqext_type(unsigned int irq, unsigned int type)
 			break;
 
 		case IRQ_TYPE_EDGE_RISING:
-			newvalue = S3C2410_EXTINT_RISEEDGE;
+			newvalue = S3C_GPIO_EDGE_RISING;
 			break;
 
 		case IRQ_TYPE_EDGE_FALLING:
-			newvalue = S3C2410_EXTINT_FALLEDGE;
+			newvalue = S3C_GPIO_EDGE_FALLING;
 			break;
 
 		case IRQ_TYPE_EDGE_BOTH:
-			newvalue = S3C2410_EXTINT_BOTHEDGE;
+			newvalue = S3C_GPIO_EDGE_BOTH;
 			break;
 
 		case IRQ_TYPE_LEVEL_LOW:
-			newvalue = S3C2410_EXTINT_LOWLEV;
+			newvalue = S3C_GPIO_LEVEL_LOW;
 			break;
 
 		case IRQ_TYPE_LEVEL_HIGH:
-			newvalue = S3C2410_EXTINT_HILEV;
+			newvalue = S3C_GPIO_LEVEL_HIGH;
 			break;
 
 		default:

arch/arm/plat-s5p/irq-eint.c +0 -2

index 4e0d94b..02d6ea2 100644
@@ -19,8 +19,6 @@
 
 #include <asm/hardware/vic.h>
 
-#include <plat/regs-irqtype.h>
-
 #include <mach/map.h>
 #include <plat/cpu.h>
 #include <plat/pm.h>

(quoted diff) +0 -0

b/arch/arm/plat-

Quoted 5 lines

samsung/include/plat/gpio-core.h
index c8681e0..2aef589 100644

arch/arm/plat-samsung/include/plat/gpio-core.h line 22

Quoted 9 lines

arch/arm/plat-samsung/include/plat/gpio-core.h +6 -0

@@ -14,6 +14,12 @@
 #define GPIOCON_OFF	(0x00)
 #define GPIODAT_OFF	(0x04)
 
+#define S3C_GPIO_LEVEL_LOW		(0x00)
+#define S3C_GPIO_LEVEL_HIGH		(0x01)
+#define S3C_GPIO_EDGE_FALLING		(0x02)
+#define S3C_GPIO_EDGE_RISING		(0x04)
+#define S3C_GPIO_EDGE_BOTH		(0x06)
+

GPIO_LELVEL? GPIO_EDGE?...

I think EXTINT_LEVEL_XXX and EXTINT_EDGE_XXX are more clear.

Review

Quoted 4 lines

arch/arm/plat-samsung/include/plat/gpio-core.h +0 -0
 #define S5P_GPIO_LEVEL_LOW		(0x00)
 #define S5P_GPIO_LEVEL_HIGH		(0x01)
 #define S5P_GPIO_EDGE_FALLING		(0x02)
(quoted diff) +0 -0

b/arch/arm/plat-

Quoted 18 lines

samsung/include/plat/regs-irqtype.h
deleted file mode 100644
index c63cd3f..0000000

arch/arm/plat-samsung/include/plat/regs-irqtype.h deleted +0 ~~-12~~

@@ -1,21 +0,0 @@
-/* arch/arm/plat-s3c/include/plat/regs-irqtype.h
- *
- * Copyright 2008 Simtec Electronics
- *      Ben Dooks <[email protected]>
- *      http://armlinux.simtec.co.uk/
- *
- * S3C - IRQ detection types.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- */

arch/arm/plat-samsung/include/plat/regs-irqtype.h

Quoted 10 lines

arch/arm/plat-samsung/include/plat/regs-irqtype.h deleted +0 ~~-10~~

-
-/* values for S3C2410_EXTINT0/1/2 and other cpus in the series, including
- * the S3C64XX
-*/
-#define S3C2410_EXTINT_LOWLEV	 (0x00)
-#define S3C2410_EXTINT_HILEV	 (0x01)
-#define S3C2410_EXTINT_FALLEDGE	 (0x02)
-#define S3C2410_EXTINT_RISEEDGE	 (0x04)
-#define S3C2410_EXTINT_BOTHEDGE	 (0x06)
--

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

author

2010-08-30 13:40 UTC #2 lore raw

Quoted 9 lines · Kukjin Kim

Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Samsung S3C series have the common GPIO IRQ type for all S3C series.
I can't agree with your changing name. Why do you want to change the name? If you want to move S3C2410_EXTINT_XXX from regs-irqtype.h, just move without any changes.

As S5P series change the name conversion. I will also modify the s3c series.

Quoted 3 lines

But I'm still thinking why should we move the external interrupt definitions to plat/gpio-core.h...

To use the GPIO interrupt. these definitions are used both external interrupt and GPIO interrupt.

Quoted 139 lines

Quoted 8 lines
Signed-off-by Kyungmin Park <[email protected]>
---
?arch/arm/mach-s3c64xx/irq-eint.c ? ? ? ? ? ? ? ? ?| ? 12 ++++++------
?arch/arm/plat-s3c24xx/irq.c ? ? ? ? ? ? ? ? ? ? ? | ? 14 +++++++-------
?arch/arm/plat-s5p/irq-eint.c ? ? ? ? ? ? ? ? ? ? ?| ? ?2 --
?arch/arm/plat-samsung/include/plat/gpio-core.h ? ?| ? ?6 ++++++
?arch/arm/plat-samsung/include/plat/regs-irqtype.h | ? 21
---------------------
Review
Quoted 4 lines
?5 files changed, 19 insertions(+), 36 deletions(-) ?delete mode 100644 arch/arm/plat-samsung/include/plat/regs-irqtype.h
(quoted diff) +0 -0
b/arch/arm/mach-s3c64xx/irq-eint.c
arch/arm/mach-s3c64xx/irq-eint.c static int s3c_irq_eint_set_type(unsigned int irq,
Quoted 14 lines
index 5682d6a..c079147 100644
arch/arm/mach-s3c64xx/irq-eint.c +0 -0
@@ -21,8 +21,8 @@
 
?#include <asm/hardware/vic.h>
-#include <plat/regs-irqtype.h>
?#include <mach/regs-gpio.h>
+#include <plat/gpio-core.h>
?#include <plat/gpio-cfg.h>
?#include <mach/map.h>
arch/arm/mach-s3c64xx/irq-eint.c +0 -0
@@ -85,23 +85,23 @@ static int s3c_irq_eint_set_type(unsigned int irq,
unsigned
Quoted 34 lines
arch/arm/mach-s3c64xx/irq-eint.c +0 -0
 int type)
 ? ? ? ? ? ? ? break;
 
? ? ? case IRQ_TYPE_EDGE_RISING:
- ? ? ? ? ? ? newvalue = S3C2410_EXTINT_RISEEDGE;
+ ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_RISING;
? ? ? ? ? ? ? break;
? ? ? case IRQ_TYPE_EDGE_FALLING:
- ? ? ? ? ? ? newvalue = S3C2410_EXTINT_FALLEDGE;
+ ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_FALLING;
? ? ? ? ? ? ? break;
? ? ? case IRQ_TYPE_EDGE_BOTH:
- ? ? ? ? ? ? newvalue = S3C2410_EXTINT_BOTHEDGE;
+ ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_BOTH;
? ? ? ? ? ? ? break;
? ? ? case IRQ_TYPE_LEVEL_LOW:
- ? ? ? ? ? ? newvalue = S3C2410_EXTINT_LOWLEV;
+ ? ? ? ? ? ? newvalue = S3C_GPIO_LEVEL_LOW;
? ? ? ? ? ? ? break;
? ? ? case IRQ_TYPE_LEVEL_HIGH:
- ? ? ? ? ? ? newvalue = S3C2410_EXTINT_HILEV;
+ ? ? ? ? ? ? newvalue = S3C_GPIO_LEVEL_HIGH;
? ? ? ? ? ? ? break;
? ? ? default:
arch/arm/plat-s3c24xx/irq.c +0 -0
index ad0d44e..e1a6fe5 100644
@@ -23,12 +23,12 @@
Quoted 5 lines
?#include <linux/interrupt.h>
?#include <linux/ioport.h>
?#include <linux/sysdev.h>
+#include <linux/gpio.h>
Why need this inclusion?
Quoted 51 lines
?#include <asm/irq.h>
?#include <asm/mach/irq.h>
arch/arm/plat-s3c24xx/irq.c +1 -2
-#include <plat/regs-irqtype.h>
-
+#include <plat/gpio-core.h>
?#include <plat/cpu.h>
?#include <plat/pm.h>
?#include <plat/irq.h>
arch/arm/plat-s3c24xx/irq.c +0 -0
@@ -201,23 +201,23 @@ s3c_irqext_type(unsigned int irq, unsigned int type)
 ? ? ? ? ? ? ? ? ? ? ? break;
 
? ? ? ? ? ? ? case IRQ_TYPE_EDGE_RISING:
- ? ? ? ? ? ? ? ? ? ? newvalue = S3C2410_EXTINT_RISEEDGE;
+ ? ? ? ? ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_RISING; ? ? ? ? ? ? ? ? ? ? ? break;
? ? ? ? ? ? ? case IRQ_TYPE_EDGE_FALLING:
- ? ? ? ? ? ? ? ? ? ? newvalue = S3C2410_EXTINT_FALLEDGE;
+ ? ? ? ? ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_FALLING; ? ? ? ? ? ? ? ? ? ? ? break;
? ? ? ? ? ? ? case IRQ_TYPE_EDGE_BOTH:
- ? ? ? ? ? ? ? ? ? ? newvalue = S3C2410_EXTINT_BOTHEDGE;
+ ? ? ? ? ? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_BOTH; ? ? ? ? ? ? ? ? ? ? ? break;
? ? ? ? ? ? ? case IRQ_TYPE_LEVEL_LOW:
- ? ? ? ? ? ? ? ? ? ? newvalue = S3C2410_EXTINT_LOWLEV;
+ ? ? ? ? ? ? ? ? ? ? newvalue = S3C_GPIO_LEVEL_LOW; ? ? ? ? ? ? ? ? ? ? ? break;
? ? ? ? ? ? ? case IRQ_TYPE_LEVEL_HIGH:
- ? ? ? ? ? ? ? ? ? ? newvalue = S3C2410_EXTINT_HILEV;
+ ? ? ? ? ? ? ? ? ? ? newvalue = S3C_GPIO_LEVEL_HIGH; ? ? ? ? ? ? ? ? ? ? ? break;
? ? ? ? ? ? ? default:
arch/arm/plat-s5p/irq-eint.c +0 -0
index 4e0d94b..02d6ea2 100644
@@ -19,8 +19,6 @@
 
?#include <asm/hardware/vic.h>
arch/arm/plat-s5p/irq-eint.c +0 -2
-#include <plat/regs-irqtype.h>
-
?#include <mach/map.h>
?#include <plat/cpu.h>
?#include <plat/pm.h>
Review
Quoted 1 line
(quoted diff) +0 -0
b/arch/arm/plat-
Quoted 5 lines
samsung/include/plat/gpio-core.h
index c8681e0..2aef589 100644
arch/arm/plat-samsung/include/plat/gpio-core.h line 22
Quoted 9 lines
arch/arm/plat-samsung/include/plat/gpio-core.h +6 -0
@@ -14,6 +14,12 @@
 ?#define GPIOCON_OFF ?(0x00)
 ?#define GPIODAT_OFF ?(0x04)
 
+#define S3C_GPIO_LEVEL_LOW ? ? ? ? ? (0x00)
+#define S3C_GPIO_LEVEL_HIGH ? ? ? ? ?(0x01)
+#define S3C_GPIO_EDGE_FALLING ? ? ? ? ? ? ? ?(0x02)
+#define S3C_GPIO_EDGE_RISING ? ? ? ? (0x04)
+#define S3C_GPIO_EDGE_BOTH ? ? ? ? ? (0x06)
+
GPIO_LELVEL? GPIO_EDGE?...

Quoted 1 line

I think EXTINT_LEVEL_XXX and EXTINT_EDGE_XXX are more clear.

? ? ? case IRQ_TYPE_EDGE_BOTH:
? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_BOTH;

Don't you it's more clear?

Quoted 49 lines

Review
Quoted 5 lines
arch/arm/plat-samsung/include/plat/gpio-core.h +0 -0
 ?#define S5P_GPIO_LEVEL_LOW ? ? ? ? ? (0x00)
 ?#define S5P_GPIO_LEVEL_HIGH ? ? ? ? ?(0x01)
 ?#define S5P_GPIO_EDGE_FALLING ? ? ? ? ? ? ? ?(0x02)
(quoted diff) +0 -0
b/arch/arm/plat-
Quoted 18 lines
samsung/include/plat/regs-irqtype.h
deleted file mode 100644
index c63cd3f..0000000
arch/arm/plat-samsung/include/plat/regs-irqtype.h deleted +0 ~~-12~~
@@ -1,21 +0,0 @@
-/* arch/arm/plat-s3c/include/plat/regs-irqtype.h
- *
- * Copyright 2008 Simtec Electronics
- * ? ? ?Ben Dooks <[email protected]>
- * ? ? ?http://armlinux.simtec.co.uk/
- *
- * S3C - IRQ detection types.
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License version 2 as
- * published by the Free Software Foundation.
- */
arch/arm/plat-samsung/include/plat/regs-irqtype.h
Quoted 10 lines
arch/arm/plat-samsung/include/plat/regs-irqtype.h deleted +0 ~~-10~~
-
-/* values for S3C2410_EXTINT0/1/2 and other cpus in the series, including
- * the S3C64XX
-*/
-#define S3C2410_EXTINT_LOWLEV ? ? ? ? (0x00)
-#define S3C2410_EXTINT_HILEV ?(0x01)
-#define S3C2410_EXTINT_FALLEDGE ? ? ? (0x02)
-#define S3C2410_EXTINT_RISEEDGE ? ? ? (0x04)
-#define S3C2410_EXTINT_BOTHEDGE ? ? ? (0x06)
--
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo at vger.kernel.org
More majordomo info at ?http://vger.kernel.org/majordomo-info.html Please read the FAQ at ?http://www.tux.org/lkml/

Kukjin Kim

2010-08-31 23:49 UTC #3 lore raw

Quoted 9 lines · Kyungmin Park

Quoted 7 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Samsung S3C series have the common GPIO IRQ type for all S3C series.
I can't agree with your changing name. Why do you want to change the

name?

Quoted 3 lines

Quoted 2 lines
If you want to move S3C2410_EXTINT_XXX from regs-irqtype.h, just move without any changes.
As S5P series change the name conversion. I will also modify the s3c

series.

Quoted 1 line

I think that we don’t need to change for it.
And as you see, there is no difference between S3C2410_XXX and S3C_XXX.

Quoted 2 lines

Quoted 2 lines
But I'm still thinking why should we move the external interrupt

definitions

Quoted 9 lines

Quoted 1 line
to plat/gpio-core.h...
To use the GPIO interrupt. these definitions are used both external interrupt and GPIO interrupt.
Quoted 3 lines
Quoted 3 lines
Signed-off-by Kyungmin Park <[email protected]>
---

(snip)

Quoted 9 lines

arch/arm/plat-samsung/include/plat/gpio-core.h line 22

Quoted 7 lines

arch/arm/plat-samsung/include/plat/gpio-core.h +6 -0

+#define S3C_GPIO_LEVEL_LOW           (0x00)
+#define S3C_GPIO_LEVEL_HIGH          (0x01)
+#define S3C_GPIO_EDGE_FALLING                (0x02)
+#define S3C_GPIO_EDGE_RISING         (0x04)
+#define S3C_GPIO_EDGE_BOTH           (0x06)
+

GPIO_LELVEL? GPIO_EDGE?...

Quoted 7 lines

Quoted 1 line
I think EXTINT_LEVEL_XXX and EXTINT_EDGE_XXX are more clear.
case IRQ_TYPE_EDGE_BOTH:
newvalue = S3C_GPIO_EDGE_BOTH;
Don't you it's more clear?

I don't think so, I meant that it is used for external interrupt not gpio. And it used currently for external interrupt.

So, I said that no need to change it now.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

Kyungmin Park

author

2010-09-01 02:10 UTC #4 lore raw

Quoted 44 lines · Kukjin Kim

Quoted 9 lines · Kyungmin Park
Quoted 7 lines · Kukjin Kim
Quoted 5 lines · Kyungmin Park
From: Kyungmin Park <[email protected]>
Samsung S3C series have the common GPIO IRQ type for all S3C series.
I can't agree with your changing name. Why do you want to change the
name?
Quoted 3 lines
Quoted 2 lines
If you want to move S3C2410_EXTINT_XXX from regs-irqtype.h, just move without any changes.
As S5P series change the name conversion. I will also modify the s3c
series.
Quoted 1 line
I think that we don?t need to change for it.
And as you see, there is no difference between S3C2410_XXX and S3C_XXX.
Quoted 2 lines
Quoted 2 lines
But I'm still thinking why should we move the external interrupt
definitions
Quoted 9 lines
Quoted 1 line
to plat/gpio-core.h...
To use the GPIO interrupt. these definitions are used both external interrupt and GPIO interrupt.
Quoted 3 lines
Quoted 3 lines
Signed-off-by Kyungmin Park <[email protected]>
---
(snip)
Quoted 11 lines
Quoted 10 lines
Review
Quoted 7 lines
(quoted diff) +6 -0
+#define S3C_GPIO_LEVEL_LOW ? ? ? ? ? (0x00)
+#define S3C_GPIO_LEVEL_HIGH ? ? ? ? ?(0x01)
+#define S3C_GPIO_EDGE_FALLING ? ? ? ? ? ? ? ?(0x02)
+#define S3C_GPIO_EDGE_RISING ? ? ? ? (0x04)
+#define S3C_GPIO_EDGE_BOTH ? ? ? ? ? (0x06)
+
GPIO_LELVEL? GPIO_EDGE?...
I think EXTINT_LEVEL_XXX and EXTINT_EDGE_XXX are more clear.

Quoted 7 lines

Quoted 5 lines
?? ? ? case IRQ_TYPE_EDGE_BOTH:
?? ? ? ? ? ? newvalue = S3C_GPIO_EDGE_BOTH;
Don't you it's more clear?
I don't think so, I meant that it is used for external interrupt not gpio. And it used currently for external interrupt.

I also don't think so. GPIO interrupt has the same function and no need to bind these name to external interrupt.

At the spec. no difference between external interrupt and gpios. As you don't use the GPIO interrupts. don't say it's for external interrupt.

Quoted 12 lines

So, I said that no need to change it now.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.