Skip to contentSkip to conversation

Clean up acct module.

PATCH New Dominick Grift 2 participants 2 messages Sep 3, 2010 – Sep 9, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Clean up acct module.

---
:100644 100644 e81367c... 99ff9aa... M policy/modules/admin/acct.fc
:100644 100644 e66c296... 1a5c801... M policy/modules/admin/acct.if

 policy/modules/admin/acct.fc |    1 -
 policy/modules/admin/acct.if |   11 ++++++-----
 2 files changed, 6 insertions(+), 6 deletions(-)
policy/modules/admin/acct.fc +0 -1
index e81367c..99ff9aa 100644
@@ -1,4 +1,3 @@
-
 /etc/cron\.(daily|monthly)/acct -- gen_context(system_u:object_r:acct_exec_t,s0)
 
 /sbin/accton		--	gen_context(system_u:object_r:acct_exec_t,s0)
policy/modules/admin/acct.if +6 -5
index e66c296..1a5c801 100644
@@ -1,8 +1,9 @@
-## <summary>Berkeley process accounting</summary>
+## <summary>Berkeley process accounting.</summary>
 
 ########################################
 ## <summary>
-##	Transition to the accounting management domain.
+##	Execute a domain transition to run
+##	accounting management tools.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -21,7 +22,7 @@ interface(`acct_domtrans',`
 
 ########################################
 ## <summary>
-##	Execute accounting management tools in the caller domain.
+##	Execute accounting management tools.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -40,7 +41,7 @@ interface(`acct_exec',`
 
 ########################################
 ## <summary>
-##	Execute accounting management data in the caller domain.
+##	Execute accounting management data.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
@@ -61,7 +62,7 @@ interface(`acct_exec_data',`
 
 ########################################
 ## <summary>
-##	Create, read, write, and delete process accounting data.
+##	Manage accounting data.
 ## </summary>
 ## <param name="domain">
 ##	<summary>
Signature · 9 lines
1.7.2.1

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
Url : http://oss.tresys.com/pipermail/refpolicy/attachments/20100903/23931dfd/attachment.bin 
#1 lore raw

PATCH 1/1 Clean up acct module.

Quoted 33 lines · Dominick Grift
policy/modules/admin/acct.if +5 -4
@@ -1,8 +1,9 @@
-##<summary>Berkeley process accounting</summary>
+##<summary>Berkeley process accounting.</summary>
 
  ########################################
  ##<summary>
-##	Transition to the accounting management domain.
+##	Execute a domain transition to run
+##	accounting management tools.
  ##</summary>
  ##<param name="domain">
  ##	<summary>
@@ -21,7 +22,7 @@ interface(`acct_domtrans',`
 
  ########################################
  ##<summary>
-##	Execute accounting management tools in the caller domain.
+##	Execute accounting management tools.
  ##</summary>
  ##<param name="domain">
  ##	<summary>
@@ -40,7 +41,7 @@ interface(`acct_exec',`
 
  ########################################
  ##<summary>
-##	Execute accounting management data in the caller domain.
+##	Execute accounting management data.
  ##</summary>
  ##<param name="domain">
  ##	<summary>

policy/modules/admin/acct.if interface(`acct_exec_data',` · line 68

Quoted 8 lines
policy/modules/admin/acct.if +1 -1
@@ -61,7 +62,7 @@ interface(`acct_exec_data',`
 
  ########################################
  ##<summary>
-##	Create, read, write, and delete process accounting data.
+##	Manage accounting data.
  ##</summary>
  ##<param name="domain">
  ##	<summary>

This one makes it worse, in my opinion. I prefer to keep the "create, read, write, and delete" so that people that aren't as familiar with what we mean by "manage" have an idea of what it means by the docs.

Signature · 3 lines
Chris PeBenito
Tresys Technology, LLC
www.tresys.com | oss.tresys.com