Skip to contentSkip to conversation

gdbsx: use MTF flag for HVM guests for single step

PATCH New Mukesh Rathor 1 participant 1 message Sep 4, 2010

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 gdbsx: use MTF flag for HVM guests for single step

The attached patch first tries the MTF flag for HVM guest single step, reverting to manually setting the TF flag if MTF fails.

Tested on 4.0.1. Compile tested on unstable.

thanks,
Mukesh

Signed-off-by [email protected]
tools/debugger/gdbsx/xg/xg_main.c +14 -0
diff -r 1831912d4109 tools/debugger/gdbsx/xg/xg_main.c
@@ -158,6 +158,7 @@
 
 
 /*
+ * Precondition: domctl global struct must be filled 
  * Returns : 0 Success, failure otherwise with errno set
  */
 static int
@@ -366,6 +367,19 @@
     union vcpu_guest_context_any anyc;
     int sz = sizeof(anyc);
 
+    /* first try the MTF for hvm guest. otherwise do manually */
+    if (_hvm_guest) {
+        domctl.u.debug_op.vcpu = which_vcpu;
+        domctl.u.debug_op.op = setit ? XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_ON :
+                                       XEN_DOMCTL_DEBUG_OP_SINGLE_STEP_OFF;
+
+        if (_domctl_hcall(XEN_DOMCTL_debug_op, NULL, 0) == 0) {
+            XGTRC("vcpu:%d:MTF success setit:%d\n", which_vcpu, setit);
+            return 0;
+        }
+        XGTRC("vcpu:%d:MTF failed. setit:%d\n", which_vcpu, setit);
+    }
+
     memset(&anyc, 0, sz);
     domctl.u.vcpucontext.vcpu = (uint16_t)which_vcpu;
     set_xen_guest_handle(domctl.u.vcpucontext.ctxt, &anyc.ctxt);

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel