i915: enable AVI infoframe for intel_hdmi.c
Subsystems (2)
PATCH 1/1 i915: enable AVI infoframe for intel_hdmi.c
This patch enables the sending of AVI infoframes in drivers/gpu/drm/i915/intel_hdmi.c.
My receiver currently loses sync when the HDMI output on my computer (DG45FC motherboard) is switched from 800x600 (the BIOS resolution) to 1920x1080 as part of the boot. Fixable by switching inputs on the receiver a couple of times.
With this patch, my receiver has not lost sync yet (> 40 tries).
I'm not sure that the general approach is sound, which is why I'm sending this out for some feedback and review (in particular, is the SDVOB and SDVOC handling in intel_hdmi_set_avi_infoframe() correct?).
Regards,
David Härdeman
--- drivers/gpu/drm/i915/i915_reg.h | 16 +++++++ drivers/gpu/drm/i915/intel_hdmi.c | 90 +++++++++++++++++++++++++++++++++++++ 2 files changed, 106 insertions(+), 0 deletions(-)
drivers/gpu/drm/i915/i915_reg.h +16 -0
@@ -1330,6 +1330,22 @@#define LVDS_B0B3_POWER_DOWN (0 << 2)#define LVDS_B0B3_POWER_UP (3 << 2) +/* Video Data Island Packet control */ +#define VIDEO_DIP_DATA 0x61178 +#define VIDEO_DIP_CTL 0x61170 +#define VIDEO_DIP_ENABLE (1 << 31) +#define VIDEO_DIP_PORT_B (1 << 29) +#define VIDEO_DIP_PORT_C (2 << 29) +#define VIDEO_DIP_ENABLE_AVI (1 << 21) +#define VIDEO_DIP_ENABLE_VENDOR (2 << 21) +#define VIDEO_DIP_ENABLE_SPD (8 << 21) +#define VIDEO_DIP_SELECT_AVI (0 << 19) +#define VIDEO_DIP_SELECT_VENDOR (1 << 19) +#define VIDEO_DIP_SELECT_SPD (3 << 19) +#define VIDEO_DIP_FREQ_ONCE (0 << 16) +#define VIDEO_DIP_FREQ_VSYNC (1 << 16) +#define VIDEO_DIP_FREQ_2VSYNC (2 << 16) +/* Panel power sequencing */ #define PP_STATUS 0x61200#define PP_ON (1 << 31)
drivers/gpu/drm/i915/intel_hdmi.c +90 -0
108 lines not on this page · raw message
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 8 lines · David Härdeman
This patch enables the sending of AVI infoframes in
drivers/gpu/drm/i915/intel_hdmi.c.My receiver currently loses sync when the HDMI output on my computer (DG45FC motherboard) is switched from 800x600 (the BIOS resolution) to 1920x1080 as part of the boot. Fixable by switching inputs on the receiver a couple of times.
Quoted 5 lines
With this patch, my receiver has not lost sync yet (> 40 tries).
I'm not sure that the general approach is sound, which is why I'm sending this out for some feedback and review (in particular, is the SDVOB and SDVOC handling in
intel_hdmi_set_avi_infoframe()correct?).
Oh, more code duplication... I thought I recognised this, we do this for SDVO HDMI but not integrated HDMI.
Can you move the dip_infoframe helper functions into intel_hdmi.c and call them from intel_sdvo.c? And then we can take a closer look at sdvox. -Chris
Signature · 1 line
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/intel-gfx