Skip to contentSkip to conversation

Illuminators control

PATCH In review Jean-Francois Moine 2 participants 2 messages Sep 11, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 Illuminators control

Hi,

This new proposal cancels the previous patch 'Illuminators and status LED controls'.

Cheers.

Signature · 2 lines
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/
#1 lore raw
Quoted 8 lines · On Saturday, September 11, 2010 10:24:26 Jean-Francois Moine wrote:

Hi,

This new proposal cancels the previous patch 'Illuminators and status LED controls'.

Cheers.

Documentation/DocBook/v4l/controls.xml +3 -0
index 8408caa..4226a9e 100644
@@ -312,10 +312,17 @@ minimum value disables backlight compensation.</entry>
 	    information and bits 24-31 must be zero.</entry>
 	  </row>
 	  <row>
+	    <entry><constant>V4L2_CID_ILLUMINATORS_0</constant>
+		<constant>V4L2_CID_ILLUMINATORS_1</constant></entry>
+	    <entry>oolean</entry>
 

Typo: 'oolean' -> boolean :-)

+ <entry>Switch on or off the illuminator 0 or 1 of the device
+ (usually a microscope).</entry>
+ </row>
+ <row>
<entry><constant>V4L2_CID_LASTP1</constant></entry> <entry></entry>
<entry>End of the predefined control IDs (currently
-<constant>V4L2_CID_BG_COLOR</constant> + 1).</entry> +<constant>V4L2_CID_ILLUMINATORS_1</constant> + 1).</entry>
</row>
<row>
<entry><constant>V4L2_CID_PRIVATE_BASE</constant></entry>

I would recommend naming these controls ILLUMINATOR_1 and _2 instead of _0 and _1. The average end-user starts counting at 1, not 0.

Regards,

Hans

Signature · 1 line
Hans Verkuil - video4linux developer - sponsored by TANDBERG, part of Cisco