Skip to contentSkip to conversation

2.6.32.y needs ACPI workaround on ASUS K50IJ

PATCH Paolo Ornati 2 participants 2 messages Sep 12, 2010 – Sep 23, 2010 ACPI

lore
Share & tools
lore
#0 lore raw

Hello,

ASUS K50IJ needs the following ACPI workaround on 2.6.32.y (2.6.33+ is fine).

Since many distros are based / basing on 2.6.32.y i think it makes sense to include the fix in the upstream stable tree :)

------------------------------------------

commit 81074e90f5c150ca70ab8dfcc77860cbe76f364d

Author: Zhang Rui <[email protected]>
Date:   Mon Dec 21 16:13:15 2009 +0800
    ACPI: disable _OSI(Windows 2009) on Asus K50IJ
    
    Fix a win7 compability issue on Asus K50IJ.
    
    Here is the _BCM method of this laptop:
                        Method (_BCM, 1, NotSerialized)
                        {
                            If (LGreaterEqual (OSFG, OSVT))
                            {
                                If (LNotEqual (OSFG, OSW7))
                                {
                                    Store (One, BCMD)
                                    Store (GCBL (Arg0), Local0)
                                    Subtract (0x0F, Local0, LBTN)
                                    ^^^SBRG.EC0.STBR ()
                                    ...
                                }
                                Else
                                {
                                    DBGR (0x0B, Zero, Zero, Arg0)
                                    Store (Arg0, LBTN)
                                    ^^^SBRG.EC0.STBR ()
                                    ...
                                }
                            }
                        }
    LBTN is used to store the index of the brightness level in the _BCL.
    GCBL is a method that convert the percentage value to the index value.
    If _OSI(Windows 2009) is not disabled, LBTN is stored a percentage
    value which is surely beyond the end of _BCL package.
    
    http://bugzilla.kernel.org/show_bug.cgi?id=14753
    
    Signed-off-by: Zhang Rui <[email protected]>
    Signed-off-by: Len Brown <[email protected]>
drivers/acpi/blacklist.c +14 -0
index 23e5a05..2815df6 100644
@@ -185,6 +185,12 @@ static int __init dmi_disable_osi_vista(const struct dmi_system_id *d)
 	acpi_osi_setup("!Windows 2006");
 	return 0;
 }
+static int __init dmi_disable_osi_win7(const struct dmi_system_id *d)
+{
+	printk(KERN_NOTICE PREFIX "DMI detected: %s\n", d->ident);
+	acpi_osi_setup("!Windows 2009");
+	return 0;
+}
 
 static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 	{
@@ -211,6 +217,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
 		},
 	},
+	{
+	.callback = dmi_disable_osi_win7,
+	.ident = "ASUS K50IJ",
+	.matches = {
+		     DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK Computer Inc."),
+		     DMI_MATCH(DMI_PRODUCT_NAME, "K50IJ"),
+		},
+	},
 
 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
Signature · 2 lines
	Paolo Ornati
	Linux 2.6.35.4 on x86_64
#1 lore raw
Quoted 7 lines · Paolo Ornati

Hello,

ASUS K50IJ needs the following ACPI workaround on 2.6.32.y (2.6.33+ is fine).

Since many distros are based / basing on 2.6.32.y i think it makes sense to include the fix in the upstream stable tree :)

Now queued up.

thanks,

greg k-h