hwmon: (w83795) Fix LSB reading of fan
Subsystems (2)
PATCH 16/36 hwmon: (w83795) Fix LSB reading of fan
Misplaced parentheses caused the wrong register value to be read, resulting in random LSB for fan speed values and limits.
Signed-off-by Jean Delvare <[email protected]>
--- drivers/hwmon/w83795.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/hwmon/w83795.c +5 -2
@@ -272,7 +272,7 @@ static inline u16 in_to_reg(u8 index, u1static inline unsigned long fan_from_reg (u16 val) { -if ((val >=0xff0 ) || (val =0 )) +if ((val =0xfff ) || (val =0 ))return 0 ;return 1350000UL / val; }
@@ -456,7 +456,7 @@ static struct w83795_data *w83795_updatecontinue ; data->fan[i] =w83795_read (client,W83795_REG_FAN (i)) <<4 ; data->fan[i] |- (w83795_read (client,W83795_REG_VRLSB >>4 )) &0x0F ; + (w83795_read (client,W83795_REG_VRLSB ) >>4 ) &0x0F ; }/* Update temperature */
@@ -1940,11 +1940,11 @@ static int w83795_probe(struct i2c_clien data->fan_min[i] w83795_read(client, W83795_REG_FAN_MIN_HL(i)) << 4; data->fan_min[i] |- (w83795_read(client, W83795_REG_FAN_MIN_LSB(i) >> -W83795_REG_FAN_MIN_LSB_SHIFT (i))) &0x0F ; + (w83795_read(client, W83795_REG_FAN_MIN_LSB(i)) >> + W83795_REG_FAN_MIN_LSB_SHIFT(i)) & 0x0F; data->fan[i] = w83795_read(client, W83795_REG_FAN(i)) << 4; data->fan[i] |- (w83795_read(client, W83795_REG_VRLSB >> 4)) & 0x0F; + (w83795_read(client, W83795_REG_VRLSB) >> 4) & 0x0F; }/* temperature and limits */
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors