Skip to contentSkip to conversation

infiniband: nes_cm: remove unneeded variable

PATCH Applied Dan Carpenter 3 participants 3 messages Sep 15, 2010 – Sep 29, 2010

Subsystems (2)
Kernel janitors InfiniBand
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 infiniband: nes_cm: remove unneeded variable

Just a small cleanup. The "passive_state" variable isn't used any more
after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/nes/nes_cm.c +1 -2
index 61e0efd..5c8d34c 100644
@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
 {
 
 	int	reset = 0;	/* whether to send reset in case of err.. */
-	int	passive_state;
 	atomic_inc(&cm_resets_recvd);
 	nes_debug(NES_DBG_CM, "Received Reset, cm_node = %p, state = %u."
 			" refcnt=%d\n", cm_node, cm_node->state,

@@ -1439,7 +1438,7 @@ static void handle_rst_pkt(struct nes_cm_node *cm_node, struct sk_buff *skb,
 		active_open_err(cm_node, skb, reset);
 		break;
 	case NES_CM_STATE_MPAREQ_RCVD:
-		passive_state = atomic_add_return(1, &cm_node->passive_state);
+		atomic_inc(&cm_node->passive_state);
 		dev_kfree_skb_any(skb);
 		break;
 	case NES_CM_STATE_ESTABLISHED:
#1 lore raw
Quoted 21 lines

-----Original Message-----
From: Dan Carpenter [mailto:[email protected]]
Sent: Wednesday, September 15, 2010 11:33 AM
To: Latif, Faisal
Cc: Tung, Chien Tin; Roland Dreier; Or Gerlitz; linux- [email protected]; [email protected]
Subject: [patch] infiniband: nes_cm: remove unneeded variable

Just a small cleanup. The "passive_state" variable isn't used any more
after: dae58728dc "RDMA/nes: Fix double CLOSE event indication crash"

Signed-off-by Dan Carpenter <[email protected]>
drivers/infiniband/hw/nes/nes_cm.c +0 -0
index 61e0efd..5c8d34c 100644

drivers/infiniband/hw/nes/nes_cm.c static void handle_rst_pkt(struct nes_cm_node · line 1424

Quoted 1 line
drivers/infiniband/hw/nes/nes_cm.c +0 -0
@@ -1424,7 +1424,6 @@ static void handle_rst_pkt(struct nes_cm_node
 *cm_node, struct sk_buff *skb,

This is fine.

Thanks
Faisal