Skip to contentSkip to conversation

default CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y

PATCH In review Roland McGrath 2 participants 3 messages Sep 18, 2010 – Sep 21, 2010

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 default CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS=y

The userland ELF tools have been coping with partial-segments core files for a few years now. Multiple distro builds are now setting this option. It behooves everyone who ever deals with core files to have more info dumped in there, especially as more and more people's compilers are producing build IDs. Make it the default.

Anyone using older tools confused by these core files can configure this option off, or just change /proc/PID/coredump_filter after boot.

---
 fs/Kconfig.binfmt |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
fs/Kconfig.binfmt +2 -2
index bb4cc5b..79e2ca7 100644
@@ -42,7 +42,7 @@ config BINFMT_ELF_FDPIC
 
 config CORE_DUMP_DEFAULT_ELF_HEADERS
 	bool "Write ELF core dumps with partial segments"
-	default n
+	default y
 	depends on BINFMT_ELF && ELF_CORE
 	help
 	  ELF core dump files describe each memory mapping of the crashed
@@ -60,7 +60,7 @@ config CORE_DUMP_DEFAULT_ELF_HEADERS
 	  inherited.  See Documentation/filesystems/proc.txt for details.
 
 	  This config option changes the default setting of coredump_filter
-	  seen at boot time.  If unsure, say N.
+	  seen at boot time.  If unsure, say Y.
 
 config BINFMT_FLAT
 	bool "Kernel support for flat binaries"
#1 lore raw
Quoted 5 lines · Roland McGrath

The userland ELF tools have been coping with partial-segments core files for a few years now.  Multiple distro builds are now setting this option.  It behooves everyone who ever deals with core files to have more info dumped in there, especially as more and more people's compilers are producing build IDs.  Make it the default.

Ok, I can do this next merge window, but it's not appropriate for my tree now.

So either Andrew tracks this, or you'll need to re-send it when we're not in the -rc phase.

Linus

#2 lore raw

I can never keep track of your cycles. I just post changes when I have them. For this item, my only hope is that it gets in one of these days. So it would be nice if Andrew can queue it to be merged whenever is appropriate.

Thanks,
Roland