cross keyword for automake warnings
PATCH 1/1 cross keyword for automake warnings
each of the following two patches adds the "cross" keyword to the command line option --warnings of the automake utility.
that feature is merely a dummy right now as it's not yet used by the tool. it improves consistency for the commandline parameters of the tools from that sector. it further helps the oe build to not fail when e.g. a tool from the autoconf collection blindly tries to pass along "--warnings=cross" to automake.
consider this as a systematic change that paves the way for more whilst reducing need for complexity (like filtering that) in the callers area.
two versions are appended.
i only ran the one for 1.10.x on my build testbed.
regards, Alex.
Signature · 2 lines
GRATIS: Spider-Man 1-3 sowie 300 weitere Videos! Jetzt freischalten! http://portal.gmx.net/de/go/maxdome
aclocal.in +1 -0
@@ -887,6 +887,7 @@ -W, --warnings=CATEGORY report the warnings falling in CATEGORY Warning categories include: + `cross' cross compilation issues `syntax' dubious syntactic constructs (default) `unsupported' unknown macros (default) `all' all the warnings (default)
lib/Automake/ChannelDefs.pm +6 -0
@@ -90,6 +90,10 @@ Internal errors. Use C<&prog_error> to send messages over this channel. +=item C<cross> + +cross compilation issues + =item C<gnu> Warnings related to GNU Coding Standards.
@@ -142,6 +146,7 @@ "####################\n"), footer => "\nPlease contact <bug-automake\@gnu.org>."; +register_channel 'cross', type => 'warning'; register_channel 'gnu', type => 'warning'; register_channel 'obsolete', type => 'warning', silent => 1; register_channel 'override', type => 'warning', silent => 1;
@@ -165,6 +170,7 @@ sub usage () { print "Warning categories include: + `cross' cross compilation issues `gnu' GNU coding standards (default in gnu and gnits modes) `obsolete' obsolete features or constructions `override' user redefinitions of Automake rules or variables
aclocal.in +1 -0
@@ -890,6 +890,7 @@ -W, --warnings=CATEGORY report the warnings falling in CATEGORY Warning categories include: + `cross' cross compilation issues `syntax' dubious syntactic constructs (default) `unsupported' unknown macros (default) `all' all the warnings (default)
doc/aclocal-1.11.1 +3 -0
@@ -47,6 +47,9 @@ report the warnings falling in CATEGORY .SS "Warning categories include:" .TP +`cross' +cross compilation issues +.TP `syntax' dubious syntactic constructs (default) .TP
lib/Automake/ChannelDefs.pm +7 -1
@@ -150,6 +150,7 @@ footer => "\nPlease contact <bug-automake\@gnu.org>.", uniq_part => UP_NONE, ordered => 0; +register_channel 'cross', type => 'warning'; register_channel 'gnu', type => 'warning'; register_channel 'obsolete', type => 'warning', silent => 1; register_channel 'override', type => 'warning', silent => 1;
@@ -175,6 +176,7 @@ sub usage () { print "Warning categories include: + `cross' cross compilation issues `gnu' GNU coding standards (default in gnu and gnits modes) `obsolete' obsolete features or constructions `override' user redefinitions of Automake rules or variables
@@ -262,7 +264,11 @@ $has_no = 1; } - if ($cat eq 'all') + if ($cat eq 'cross') + { + setup_channel_type 'warning', silent => $has_no; + } + elsif ($cat eq 'all') { setup_channel_type 'warning', silent => $has_no; }
Am Dienstag, den 28.09.2010, 19:45 +0200 schrieb Alexander Stohr:
Quoted 1 line
each of the following two patches adds the "cross" keyword to the command line option --warnings of the automake utility.
[…]
Quoted 1 line
i only ran the one for 1.10.x on my build testbed.
If I understand you correctly your patches are actually for upstream Automake and you just wanted to inform the OE folks? Do you want to have comments? It is not exactly clear for me.
Anyway, since your patches are not applicable to the OE repository, I set the state to »Not Applicable«.
pwclient update -s "not applicable" 3086
Thanks,
Paul