Skip to contentSkip to conversation

DMI: log system, BIOS, and board information

PATCH Superseded Bjorn Helgaas 2 participants 3 messages Sep 29, 2010 Dmi/smbios support

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 DMI: log system, BIOS, and board information

Put basic system information in the dmesg log. There are lots of dmesg logs on the web, and it would be useful if they contained this information for debugging platform problems.

DMI often doesn't supply a board name, but I assume the others are pretty standard.

---

 drivers/firmware/dmi_scan.c |   15 ++++++++++++++-
 1 files changed, 14 insertions(+), 1 deletions(-)
drivers/firmware/dmi_scan.c +14 -1
index b3d22d6..ea6719f 100644
@@ -364,6 +364,7 @@ static void __init dmi_decode(const struct dmi_header *dm, void *dummy)
 static int __init dmi_present(const char __iomem *p)
 {
 	u8 buf[15];
+	const char *board, *label = " board ";
 
 	memcpy_fromio(buf, p, 15);
 	if ((memcmp(buf, "_DMI_", 5) == 0) && dmi_checksum(buf)) {
@@ -381,8 +382,20 @@ static int __init dmi_present(const char __iomem *p)
 			       buf[14] >> 4, buf[14] & 0xF);
 		else
 			printk(KERN_INFO "DMI present.\n");
-		if (dmi_walk_early(dmi_decode) == 0)
+		if (dmi_walk_early(dmi_decode) == 0) {
+			board = dmi_get_system_info(DMI_BOARD_NAME);
+			if (!board) {
+				board = "";
+				label = "";
+			}
+			printk(KERN_DEBUG "DMI: %s %s BIOS %s %s%s%s\n",
+			       dmi_get_system_info(DMI_SYS_VENDOR),
+			       dmi_get_system_info(DMI_PRODUCT_NAME),
+			       dmi_get_system_info(DMI_BIOS_VERSION),
+			       dmi_get_system_info(DMI_BIOS_DATE),
+			       label, board);
 			return 0;
+		}
 	}
 	return 1;
 }
#1 lore raw
Quoted 7 lines · On Wed, 29 Sep 2010 12:24:02 -0600 Bjorn Helgaas <[email protected]> wrote:

Put basic system information in the dmesg log. There are lots of dmesg logs on the web, and it would be useful if they contained this information for debugging platform problems.

DMI often doesn't supply a board name, but I assume the others are pretty standard.

You need to filter the characters before printing them in the log. Some platforms contain binary garbage.

So NAK.

It's also the wrong thing in most cases because the key data is in sysfs so your bug capturing tool can collect it.

#2 lore raw
Quoted 7 lines · Alan Cox
Quoted 5 lines · On Wed, 29 Sep 2010 12:24:02 -0600 Bjorn Helgaas <[email protected]> wrote:

Put basic system information in the dmesg log. There are lots of dmesg logs on the web, and it would be useful if they contained this information for debugging platform problems.

Quoted 5 lines
Quoted 2 lines

DMI often doesn't supply a board name, but I assume the others are pretty standard.

You need to filter the characters before printing them in the log. Some platforms contain binary garbage.

Oh, good point. Filtering sounds feasible in concept, at least.

Quoted 2 lines

It's also the wrong thing in most cases because the key data is in sysfs so your bug capturing tool can collect it.

Sure, there's no question that this information and a lot more is easily available elsewhere.

Most of the bug reports I see are not generated by bug capturing tools; they're generated by Joe User posting a dmesg log. For many platform issues, it would be quite useful if that log already contained a hint about what platform it is. The collection of dmesg logs on the web + Google indexing + a platform ID would be a great help in locating similar failures and contacting testers.

Bjorn