ARM: S5PC210: I2C devices support and Universal board updates

The following changes since commit aff078a9da27e0effb2a149834089e5788943d4b:
?Marek Szyprowski (1):
? ? ? ?ARM: S5PV210: Enable USB HSOTG gadget build

Kyungmin Park (7):
? ? ?ARM: S5PC210: Universal OneNAND support
? ? ?ARM: S5PC110: Fix wrong interrupt I2C2 number
? ? ?ARM: Samsung: Use the correct I2C2 interrupt
? ? ?ARM: S5PC210: I2C1/2 support
? ? ?ARM: S5PC210: I2C0/1 devices support on Universal board ? ? ?ARM: S5PC210: Define the more I2C{3,4,5,6,7} address & interrupt ? ? ?ARM: S5PC210: I2C{3, 4, 5, 6, 7} device support

?arch/arm/mach-s5pv210/include/mach/irqs.h ? | ? ?4 +-
?arch/arm/mach-s5pv310/Kconfig ? ? ? ? ? ? ? | ? 18 +++++++
?arch/arm/mach-s5pv310/Makefile ? ? ? ? ? ? ?| ? ?5 ++
?arch/arm/mach-s5pv310/include/mach/irqs.h ? | ? ?7 +++
?arch/arm/mach-s5pv310/include/mach/map.h ? ?| ? 11 ++++-
?arch/arm/mach-s5pv310/mach-universal_c210.c | ? 16 ++++++
?arch/arm/mach-s5pv310/setup-i2c3.c ? ? ? ? ?| ? 25 ++++++++++
?arch/arm/mach-s5pv310/setup-i2c4.c ? ? ? ? ?| ? 25 ++++++++++
?arch/arm/mach-s5pv310/setup-i2c5.c ? ? ? ? ?| ? 25 ++++++++++
?arch/arm/mach-s5pv310/setup-i2c6.c ? ? ? ? ?| ? 25 ++++++++++
?arch/arm/mach-s5pv310/setup-i2c7.c ? ? ? ? ?| ? 25 ++++++++++
?arch/arm/plat-s5p/Kconfig ? ? ? ? ? ? ? ? ? | ? 25 ++++++++++
?arch/arm/plat-s5p/Makefile ? ? ? ? ? ? ? ? ?| ? ?5 ++
?arch/arm/plat-s5p/dev-i2c3.c ? ? ? ? ? ? ? ?| ? 67 +++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c4.c ? ? ? ? ? ? ? ?| ? 67 +++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c5.c ? ? ? ? ? ? ? ?| ? 67 +++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c6.c ? ? ? ? ? ? ? ?| ? 67 +++++++++++++++++++++++++++
?arch/arm/plat-s5p/dev-i2c7.c ? ? ? ? ? ? ? ?| ? 67 +++++++++++++++++++++++++++
?arch/arm/plat-samsung/dev-i2c2.c ? ? ? ? ? ?| ? ?4 +-
?arch/arm/plat-samsung/include/plat/iic.h ? ?| ? ?5 ++

?20 files changed, 554 insertions(+), 6 deletions(-) ?create mode 100644 arch/arm/mach-s5pv310/setup-i2c3.c ?create mode 100644 arch/arm/mach-s5pv310/setup-i2c4.c ?create mode 100644 arch/arm/mach-s5pv310/setup-i2c5.c ?create mode 100644 arch/arm/mach-s5pv310/setup-i2c6.c ?create mode 100644 arch/arm/mach-s5pv310/setup-i2c7.c ?create mode 100644 arch/arm/plat-s5p/dev-i2c3.c ?create mode 100644 arch/arm/plat-s5p/dev-i2c4.c ?create mode 100644 arch/arm/plat-s5p/dev-i2c5.c ?create mode 100644 arch/arm/plat-s5p/dev-i2c6.c ?create mode 100644 arch/arm/plat-s5p/dev-i2c7.c

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Hi,

I think we made some conclusion. first apply the current style and improve it later for consistency.

Quoted 3 lines · Kyungmin Park

Hi,

Hi,

Quoted 3 lines

I think we made some conclusion. first apply the current style and improve it later for consistency.

Yeah, we should decide for this.

However, it's expected following problem with current I2C style.

Suppose A board want to use only I2C0, 1, 2, 3, 4, 7 as I2C and B board want to use all of I2C channels as I2C. If use one kernel image for A and B, maybe selected all I2C channels. It can be happened the some problem about I2C5 and I2C6 on A board when it used for other purpose.

Of course can happen regardless of number of I2C channel, but if more I2C channels, the probability can be increased.

Anyway I know Mr. Han is preparing I2C patches for it and almost done. How about continuing discussion for this after submitting it?

I think we have some time that talk about this issue.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <[email protected]>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel at lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Quoted 3 lines

I think we made some conclusion. first apply the current style and improve it later for consistency.

Yeah, we should decide for this.

However, it's expected following problem with current I2C style.

Suppose A board want to use only I2C0, 1, 2, 3, 4, 7 as I2C and B board want to use all of I2C channels as I2C. If use one kernel image for A and B, maybe selected all I2C channels. It can be happened the some problem about I2C5 and I2C6 on A board when it used for other purpose.

Of course can happen regardless of number of I2C channel, but if more I2C channels, the probability can be increased.

Anyway I know Mr. Han is preparing I2C patches for it and almost done. How about continuing discussion for this after submitting it?

I think we have some time that talk about this issue.

Quoted 6 lines · Kukjin Kim

Quoted 3 lines · Kyungmin Park

Hi,

Hi,

Quoted 8 lines

Quoted 3 lines

I think we made some conclusion. first apply the current style and improve it later for consistency.

Yeah, we should decide for this.

However, it's expected following problem with current I2C style.

Suppose A board want to use only I2C0, 1, 2, 3, 4, 7 as I2C and B board

Quoted 2 lines

to use all of I2C channels as I2C. If use one kernel image for A and B, maybe selected all I2C channels. It can be happened the some problem

Quoted 1 line

I2C5 and I2C6 on A board when it used for other purpose.

It's handled by platform_device id. Even though turn on all I2C. A board don't register 5 or 6 then no configure any GPIOs.

Quoted 2 lines

Of course can happen regardless of number of I2C channel, but if more

Quoted 7 lines

channels, the probability can be increased.

Anyway I know Mr. Han is preparing I2C patches for it and almost done. How about continuing discussion for this after submitting it?

I think we have some time that talk about this issue.