hwmon: (pcf8591) Register as a hwmon device
PATCH 1/2 hwmon: (pcf8591) Register as a hwmon device
Register PCF8591 devices as hwmon devices. There's little point in implementing the standard sysfs interface if we don't register it in a way libsensors will pick it.
Signed-off-by Jean Delvare <[email protected]>
Cc Aurelien Jarno <[email protected]>
--- drivers/hwmon/pcf8591.c | 11 +++++++++++ 1 file changed, 11 insertions(+)
drivers/hwmon/pcf8591.c +11 -0
@@ -23,6 +23,7 @@#include <linux/slab.h> #include <linux/i2c.h> #include <linux/mutex.h> +#include <linux/hwmon.h> /* Addresses to scan */ static const unsigned short normal_i2c[] = {0x48 ,0x49 ,0x4a ,0x4b ,0x4c ,
@@ -71,6 +72,7 @@ MODULE_PARM_DESC(input_mode,#define REG_TO_SIGNED (reg) (((reg) & 0x80)?((reg) - 256):(reg))struct pcf8591_data { +struct device *hwmon_dev;struct mutex update_lock;u8 control;
@@ -221,6 +223,12 @@ static int pcf8591_probe(struct i2c_clie goto exit_sysfs_remove; } + data->hwmon_dev =hwmon_device_register (&client->dev); +if (IS_ERR (data->hwmon_dev)) { + err =PTR_ERR (data->hwmon_dev); + goto exit_sysfs_remove; + } +return 0 ; exit_sysfs_remove:
@@ -234,6 +242,9 @@ exit:static int pcf8591_remove (struct i2c_client *client) { +struct pcf8591_data *data =i2c_get_clientdata (client); + +hwmon_device_unregister (data->hwmon_dev);sysfs_remove_group (&client->dev.kobj, &pcf8591_attr_group_opt);sysfs_remove_group (&client->dev.kobj, &pcf8591_attr_group);kfree (i2c_get_clientdata (client));
Signature · 6 lines
Jean Delvare _______________________________________________ lm-sensors mailing list [email protected] http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
Re: [lm-sensors] [PATCH 1/2] hwmon: (pcf8591) Register as a hwmon
Quoted 6 lines · Jean Delvare
Register PCF8591 devices as hwmon devices. There's little point in implementing the standard sysfs interface if we don't register it in a way libsensors will pick it.
Signed-off-by Jean Delvare <[email protected]>Cc Aurelien Jarno <[email protected]>
Reviewed-by Guenter Roeck <[email protected]>
_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors