Staging: bcm: mocro expansion bug

PATCH New Dan Carpenter 1 participant 1 message Oct 8, 2010

Subsystems (2)

Staging Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2010-10-08 12:56 UTC #0 lore raw

PATCH 1/1 Staging: bcm: mocro expansion bug

The WIMAX_MAX_MTU macro is used in drivers/staging/bcm/CmHost.c like this:

    if (Adapter->PackInfo[uiSearchRuleIndex].uiMaxBucketSize < WIMAX_MAX_MTU * 8)

The multiplication by eight has precedence over the addition so the macro needs parenthesis to work.

Signed-off-by Dan Carpenter <[email protected]>

drivers/staging/bcm/Macros.h +1 -1

index 6ee1480..0241234 100644
@@ -231,7 +231,7 @@ typedef enum _E_PHS_DSC_ACTION
 
 #define MAX_PENDING_CTRL_PACKET (MAX_CTRL_QUEUE_LEN-10)
 
-#define WIMAX_MAX_MTU 					MTU_SIZE + ETH_HLEN
+#define WIMAX_MAX_MTU			(MTU_SIZE + ETH_HLEN)
 #define AUTO_LINKUP_ENABLE              0x2
 #define AUTO_SYNC_DISABLE              	0x1
 #define AUTO_FIRM_DOWNLOAD              0x1