mmc: fix cb710 kconfig dependency warning
PATCH 1/1 mmc: fix cb710 kconfig dependency warning
From: Randy Dunlap <[email protected]>
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig +1 -1
@@ -394,7 +394,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" - depends on PCI + depends on PCI && MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash
Hi Randy,
Quoted 15 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix kconfig dependency warning to satisfy dependencies:
warning: (
MMC_CB710&& MMC && PCI) selectsCB710_COREwhich has unmet direct dependencies (MISC_DEVICES&& PCI)Signed-off-by Randy Dunlap <[email protected]>Cc <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig config MMC_TMIO · line 400
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-1@@ -394,7 +394,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" - depends on PCI + depends on PCI && MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash
Thanks very much, pushed to mmc-next.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
Quoted 13 lines · Randy Dunlap
Fix kconfig dependency warning to satisfy dependencies:
warning: (
MMC_CB710&& MMC && PCI) selectsCB710_COREwhich has unmet direct dependencies (MISC_DEVICES&& PCI)Signed-off-by Randy Dunlap <[email protected]>Cc <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mmc/host/Kconfig config MMC_TMIO · line 400
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-1@@ -394,7 +394,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" - depends on PCI + depends on PCI && MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash
Is this really necessary? MISC_DEVICES is only a submenu enabler, not a real dependency.
Maybe just select MISC_DEVICES instead? User/developer should not have to know that for this specific MMC controller he has to first enable some other device burried somewhere in the config tree.
Best Regards,
Michał Mirosław
Quoted 26 lines · Michał Mirosław
Quoted 13 lines · Randy Dunlap
Fix kconfig dependency warning to satisfy dependencies:
warning: (
MMC_CB710&& MMC && PCI) selectsCB710_COREwhich has unmet direct dependencies (MISC_DEVICES&& PCI)Signed-off-by Randy Dunlap <[email protected]>Cc <[email protected]>--- drivers/mmc/host/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)drivers/mmc/host/Kconfig config MMC_TMIO · line 400
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-1@@ -394,7 +394,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" - depends on PCI + depends on PCI && MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 FlashIs this really necessary?
MISC_DEVICESis only a submenu enabler, not a real dependency.
Quoted 3 lines
Maybe just select
MISC_DEVICESinstead? User/developer should not have to know that for this specific MMC controller he has to first enable some other device burried somewhere in the config tree.
Yes, I'll resubmit using "select". (like I did with another mmc + memstick patch)
thanks,
Signature · 2 lines
~Randy *** Remember to use Documentation/SubmitChecklist when testing your code ***
PATCH v2 1/1 mmc: fix cb710 kconfig dependency warning
In reply to Michał MirosławFrom: Randy Dunlap <[email protected]>
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_CB710 && MMC && PCI) selects CB710_CORE which has unmet direct dependencies (MISC_DEVICES && PCI)
--- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/Kconfig +1 -0
@@ -395,6 +395,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" depends on PCI + select MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash
Hi,
Quoted 15 lines · Randy Dunlap
From: Randy Dunlap <[email protected]>
Fix kconfig dependency warning to satisfy dependencies:
warning: (
MMC_CB710&& MMC && PCI) selectsCB710_COREwhich has unmet direct dependencies (MISC_DEVICES&& PCI)Signed-off-by Randy Dunlap <[email protected]>Cc <[email protected]>--- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/Kconfig config MMC_TMIO
Quoted 8 lines
drivers/mmc/host/Kconfig +1
-1@@ -395,6 +395,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" depends on PCI + select MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash --
Thanks, carrying this version in mmc-next now.
Signature · 2 lines
Chris Ball <[email protected]> <http://printf.net/> One Laptop Per Child
Quoted 12 lines · Randy Dunlap
Fix kconfig dependency warning to satisfy dependencies:
warning: (MMC_CB710&& MMC && PCI) selectsCB710_COREwhich has unmet direct dependencies (MISC_DEVICES&& PCI)Signed-off-by Randy Dunlap <[email protected]>Cc <[email protected]>--- drivers/mmc/host/Kconfig | 1 + 1 file changed, 1 insertion(+)
drivers/mmc/host/Kconfig config MMC_TMIO · line 401
Quoted 7 lines
drivers/mmc/host/Kconfig +1
-0@@ -395,6 +395,7 @@ config MMC_TMIO config MMC_CB710 tristate "ENE CB710 MMC/SD Interface support" depends on PCI + select MISC_DEVICES select CB710_CORE help This option enables support for MMC/SD part of ENE CB710/720 Flash
It would be better, thoughm if MISC_DEVICES was some kind of ghost config entry that needs no selecting or depending on as it is used only for users convenience - config tree decoration maybe.
Best Regards,
Michał Mirosław