Skip to contentSkip to conversation

xfs: eliminate kconfig dependency warning

PATCH In review Randy Dunlap 3 participants 8 messages Oct 14, 2010 XFS filesystem

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xfs: eliminate kconfig dependency warning

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

---
 fs/xfs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/xfs/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config XFS_FS
 	tristate "XFS filesystem support"
-	depends on BLOCK
+	depends on BLOCK && NETWORK_FILESYSTEMS
 	select EXPORTFS
 	help
 	  XFS is a high performance journaling filesystem which originated
#1 lore raw
Quoted 14 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

---
 fs/xfs/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

fs/xfs/Kconfig line 6

Quoted 7 lines
fs/xfs/Kconfig +1 -1
@@ -1,6 +1,6 @@
 config XFS_FS
 	tristate "XFS filesystem support"
-	depends on BLOCK
+	depends on BLOCK && NETWORK_FILESYSTEMS
 	select EXPORTFS
 	help
 	  XFS is a high performance journaling filesystem which originated

This looks wrong to me. IIUC, this means if you turn of network filesystem support (e.g no NFS, CIFS, etc), you can't select XFS even though it is a local filesystem.

EXPORTFS functionality actually has use for local filesystems - the open-by-handle interfaces in XFS are what uses it, and there are patches about that make this generic for most filesystems. Hence it seems to me that the correct thing to do is separate EXPORTFS from NETWORK_FILESYSTEMS, not make local filesystems depend on a user selecting network filesystem support....

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#2 lore raw
In reply to Randy Dunlap
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

I'm not entirely sure what this gibberish means, but I'm pretty sure it does not make sense.

EXPORTFS is a small module that doesn't have any dependencie, and it's needed by XFS for the by-handle operation, and by nfsd for the same thing. It has absolutely nothing to do with networking or network filesystems (as in network filesystem clients).

#3 lore raw
Quoted 7 lines · Christoph Hellwig
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

Quoted 8 lines

I'm not entirely sure what this gibberish means, but I'm pretty sure it does not make sense.

EXPORTFS is a small module that doesn't have any dependencie, and it's needed by XFS for the by-handle operation, and by nfsd for the same thing. It has absolutely nothing to do with networking or network filesystems (as in network filesystem clients).

Thanks, Dave and Christoph. I'll look elsewhere for the glitch.

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#4 lore raw
In reply to Christoph Hellwig
Quoted 7 lines · Christoph Hellwig
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

Quoted 7 lines

I'm not entirely sure what this gibberish means, but I'm pretty sure it does not make sense.

EXPORTFS is a small module that doesn't have any dependencie, and it's needed by XFS for the by-handle operation, and by nfsd for the same thing. It has absolutely nothing to do with networking or network filesystems (as in network filesystem clients).

The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu, under the kconfig symbol NETWORK_FILESYSTEMS.

Dave Chinner wrote:

| EXPORTFS functionality actually has use for local filesystems - the
| open-by-handle interfaces in XFS are what uses it, and there are patches
| about that make this generic for most filesystems. Hence it seems to
| me that the correct thing to do is separate EXPORTFS from
| NETWORK_FILESYSTEMS, not make local filesystems depend on a user
| selecting network filesystem support....

Agreed. Is that Kconfig change also part of the "patches about"?

thanks,

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#5 lore raw
Quoted 11 lines · Randy Dunlap
Quoted 10 lines · Christoph Hellwig
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

I'm not entirely sure what this gibberish means, but I'm pretty sure it does not make sense.

Quoted 7 lines
Quoted 4 lines

EXPORTFS is a small module that doesn't have any dependencie, and it's needed by XFS for the by-handle operation, and by nfsd for the same thing. It has absolutely nothing to do with networking or network filesystems (as in network filesystem clients).

The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu, under the kconfig symbol NETWORK_FILESYSTEMS.

Thanks for the explanation, Randy.

Quoted 9 lines

Dave Chinner wrote:

| EXPORTFS functionality actually has use for local filesystems - the
| open-by-handle interfaces in XFS are what uses it, and there are patches
| about that make this generic for most filesystems. Hence it seems to
| me that the correct thing to do is separate EXPORTFS from
| NETWORK_FILESYSTEMS, not make local filesystems depend on a user
| selecting network filesystem support....

Agreed. Is that Kconfig change also part of the "patches about"?

I can't remember exactly what it does with the kconfig symbols. Information about the patch series (including a link to the git repo storing the changes) is here:

http://marc.info/?l=linux-fsdevel&m=128627415827161&w=2

Cheers,

Dave.

Signature · 2 lines
Dave Chinner
[email protected]
#6 lore raw
Quoted 30 lines · Dave Chinner
Quoted 11 lines · Randy Dunlap
Quoted 10 lines · Christoph Hellwig
Quoted 5 lines · Randy Dunlap

From: Randy Dunlap <[email protected]>

Fix kconfig dependency warning to satisfy dependencies:

warning: (XFS_FS && BLOCK || NFSD && NETWORK_FILESYSTEMS && INET && FILE_LOCKING && BKL) selects EXPORTFS which has unmet direct dependencies (NETWORK_FILESYSTEMS)

I'm not entirely sure what this gibberish means, but I'm pretty sure it does not make sense.

Quoted 7 lines
Quoted 4 lines

EXPORTFS is a small module that doesn't have any dependencie, and it's needed by XFS for the by-handle operation, and by nfsd for the same thing. It has absolutely nothing to do with networking or network filesystems (as in network filesystem clients).

The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu, under the kconfig symbol NETWORK_FILESYSTEMS.

Thanks for the explanation, Randy.

Quoted 8 lines

Dave Chinner wrote:

| EXPORTFS functionality actually has use for local filesystems - the
| open-by-handle interfaces in XFS are what uses it, and there are patches
| about that make this generic for most filesystems. Hence it seems to
| me that the correct thing to do is separate EXPORTFS from
| NETWORK_FILESYSTEMS, not make local filesystems depend on a user
| selecting network filesystem support....
Quoted 7 lines
Quoted 1 line

Agreed. Is that Kconfig change also part of the "patches about"?

I can't remember exactly what it does with the kconfig symbols. Information about the patch series (including a link to the git repo storing the changes) is here:

http://marc.info/?l=linux-fsdevel&m=128627415827161&w=2

That patch series does not modify any Kconfig files. That change can be done separately and at another time.

Thanks for the pointer.

Signature · 2 lines
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
#7 lore raw
In reply to Randy Dunlap
Quoted 2 lines · Randy Dunlap

The (kconfig) warning/problem is that exportfs is in the Networking Filesystems menu, under the kconfig symbol NETWORK_FILESYSTEMS.

That's the culprit. exportfs is just a helper library and should not depend on anthing. Looks like on of the various Kconfig patches broke that. Moving out of NETWORK_FILESYSTEMS will fix it.