a.out: Fix module build failure
Subsystems (2)
PATCH 1/1 a.out: Fix module build failure
The recent aout fix causes a modular build failure on x86 (allmodconfig):
ERROR: "dump_seek" [fs/binfmt_aout.ko] undefined!
ERROR: "dump_write" [fs/binfmt_aout.ko] undefined!
Export these symbols.
Signed-off-by Ingo Molnar <[email protected]>
---
fs/exec.c +2 -0
@@ -2024,6 +2024,7 @@ int dump_write(struct file *file, const void *addr, int nr) {return access_ok (VERIFY_READ , addr, nr) && file->f_op->write (file, addr, nr, &file->f_pos) == nr; } +EXPORT_SYMBOL_GPL (dump_write);int dump_seek (struct file *file,loff_t off) {
@@ -2052,3 +2053,4 @@ int dump_seek(struct file *file, loff_t off) }return ret; } +EXPORT_SYMBOL_GPL (dump_seek);
Quoted 3 lines · Ingo Molnar
The recent aout fix causes a modular build failure on x86 (allmodconfig):
Yeah, Tetsuo Handa reported the same.
I pushed out a fix - obviously pretty much the same as yours - except that I don't think it is worth the _GPL thing (that wasn't how it worked before, and the other binfmt-related functions are just regular EXPORT_SYMBOL's too).
Linus