mark irq9 active high in DSDT
Quoted 8 lines · Kevin O'Connor
Quoted 5 lines · Gleb Natapov
In PIIX4 SCI (irq9) is active high. Seabios marks it so in interrupt override table, but some OSes (FreeBSD) require the same information to be present in DSDT too. Make it so.
Signed-off-by Gleb Natapov<[email protected]>Thanks.
How do we manage the stable series wrt this issue?
qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly.
There are several paths we could take:
- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of seabios for both 0.12.z and 0.13.z
The third option is the most "correct" from a release engineering point of view, but involves more work for everyone. The fourth is quick pain relief but is a little forky.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 8 lines · Avi Kivity
How do we manage the stable series wrt this issue?
qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly.
There are several paths we could take:
Quoted 8 lines
- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of seabios for both 0.12.z and 0.13.zThe third option is the most "correct" from a release engineering point of view, but involves more work for everyone.
I'm okay with making tags and branches of seabios for bug fixes. So far qemu/kvm has just grabbed various builds of seabios - is it worthwhile to branch off of the seabios-0.6.1 version - which would mean qemu/kvm would pull in additional changes beyond the bug fix above?
-Kevin
Quoted 15 lines · Kevin O'Connor
Quoted 14 lines · Avi Kivity
How do we manage the stable series wrt this issue?
qemu-kvm-0.12.5 has a regression within the stable series that this patch fixes. qemu 0.12.5 does not, but only because it does not emulate polarity in the I/O APIC correctly.
There are several paths we could take:
- do nothing, bug is fixed in mainline
- release a seabios 0.x.1 for qemu 0.13.1 with this patch
- same, plus seabios 0.y.1 for qemu 0.12.6 with this patch
- skip qemu (which is not truly affected), patch qemu-kvm's copy of seabios for both 0.12.z and 0.13.z
Quoted 8 lines
Quoted 2 lines
The third option is the most "correct" from a release engineering point of view, but involves more work for everyone.
I'm okay with making tags and branches of seabios for bug fixes. So far qemu/kvm has just grabbed various builds of seabios - is it worthwhile to branch off of the seabios-0.6.1 version - which would mean qemu/kvm would pull in additional changes beyond the bug fix above?
qemu 0.12 is based on 0.5.1-stable, appears to be an untagged commit qemu 0.13 is based on 17d3e46511, doesn't appear to be a part of a branch or a tag?
git-wise, tags are more important than branches. You can always retrofit a branch to a tag (and you can always retrofit a tag to a commit hash). For the qemu git repositories, neither matter so much since the commit is recorded in git; but the distro people really like nice stable tags with lots of digits and dots in them.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 7 lines · Avi Kivity
Quoted 5 lines
I'm okay with making tags and branches of seabios for bug fixes. So far qemu/kvm has just grabbed various builds of seabios - is it worthwhile to branch off of the seabios-0.6.1 version - which would mean qemu/kvm would pull in additional changes beyond the bug fix above?
Quoted 5 lines
qemu 0.12 is based on 0.5.1-stable, appears to be an untagged commit qemu 0.13 is based on
17d3e46511, doesn't appear to be a part of a branch or a tag?git-wise, tags are more important than branches. You can always retrofit a branch to a tag (and you can always retrofit a tag to a commit hash). For the qemu git repositories, neither matter so much since the commit is recorded in git; but the distro people really like nice stable tags with lots of digits and dots in them.
On the last kvm conf call Anthony said that he'll be happy to include an updated seabios with qemu 0.13.1, so a new release would be appreciated.
Signature · 1 line
error compiling committee.c: too many arguments to function
Quoted 3 lines · Avi Kivity
On the last kvm conf call Anthony said that he'll be happy to include an updated seabios with qemu 0.13.1, so a new release would be appreciated.
I branched and tagged "rel-0.6.1.1". It only has 6d5a2172 cherry-picked into it.
-Kevin