Skip to contentSkip to conversation

parisc: Changes to ref refs/heads/next

git Kyle McMartin 1 participant 1 message Oct 22, 2010

lore
Share & tools
lore
#0 lore raw

New commits:
commit 338e4fab3d41aa14264e10ce505a7c908633cdad

Author: Julia Lawall <[email protected]>
Date:   Wed Oct 20 15:55:45 2010 -0700
    drivers/char/agp/parisc-agp.c: eliminate memory leak
    
    alloc_pci_dev allocates some memory, so that memory should be freed before
    leaving the function in an error case.
    
    A simplified version of the semantic match that finds this problem is:
    (http://coccinelle.lip6.fr/)
    
    // <smpl>
    @r exists@
    local idexpression x;
    expression E;
    identifier f1;
    iterator I;
    @@
    
    x = alloc_pci_dev(...);
    <... when != x
         when != true (x == NULL || ...)
         when != if (...) { <+...x...+> }
         when != I (...) { <+...x...+> }
    (
     x == NULL
    |
     x == E
    |
     x->f1
    )
    ...>
    * return ...;
    // </smpl>
    
    Signed-off-by: Julia Lawall <[email protected]>
    Dan Carpenter <[email protected]>
    Dave Airlie <[email protected]>
    Cc: Helge Deller <[email protected]>
    Cc: "James E.J. Bottomley" <[email protected]>
    Signed-off-by: Andrew Morton <[email protected]>
    Signed-off-by: Kyle McMartin <[email protected]>