Skip to contentSkip to conversation

pcmcia/cm4000: fix error code

PATCH In review Nicolas Kaiser 2 participants 2 messages Oct 22, 2010 – Oct 26, 2010 Char and misc drivers

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 pcmcia/cm4000: fix error code

I'm assuming it's not intended to instantly change the error code from -ENODEV to -EIO, is it?

---
 drivers/char/pcmcia/cm4000_cs.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)
drivers/char/pcmcia/cm4000_cs.c +2 -1
index d962f25..777181a 100644
@@ -979,8 +979,9 @@ static ssize_t cmm_read(struct file *filp, __user char *buf, size_t count,
 		if (dev->flags0 & 1) {
 			set_bit(IS_CMM_ABSENT, &dev->flags);
 			rc = -ENODEV;
+		} else {
+			rc = -EIO;
 		}
-		rc = -EIO;
 		goto release_io;
 	}
 
Signature · 1 line
1.7.2.2
Acked-by on v1 1/1
#1 lore raw
Quoted 4 lines · Nicolas Kaiser

I'm assuming it's not intended to instantly change the error code from -ENODEV to -EIO, is it?

Signature · 4 lines
- Harald Welte <[email protected]>           http://laforge.gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)