Skip to contentSkip to conversation

Fix QIB early error reporting prints

PATCH In review Jason Gunthorpe 3 participants 3 messages Oct 22, 2010 – Oct 23, 2010 2 messages not in the archive InfiniBand

lore
Share & tools
lore

Jason Gunthorpe

author
#0 lore raw

PATCH 1/1 Fix QIB early error reporting prints

Noticed this odd looking thing in dmesg:

ib_qib 0000:02:00.0: <3>ib_qib: Unable to enable pcie error reporting: -5

Which is due to a bad use of dev_info.

Signed-off-by Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
 drivers/infiniband/hw/qib/qib.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/qib/qib.h +1 -1
index 3593983..0268326 100644
@@ -1402,7 +1402,7 @@ extern struct mutex qib_mutex;
  */
 #define qib_early_err(dev, fmt, ...) \
 	do { \
-		dev_info(dev, KERN_ERR QIB_DRV_NAME ": " fmt, ##__VA_ARGS__); \
+		dev_err(dev, fmt, ##__VA_ARGS__); \
 	} while (0)
 
 #define qib_dev_err(dd, fmt, ...) \
Signature · 6 lines
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 20101022204124.GB30241-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org

Acked-by
#2 lore raw
Acked-by Ralph Campbell <[email protected]>

________________________________________
From: Jason Gunthorpe [jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org]
Sent: Friday, October 22, 2010 1:41 PM
To: Ralph Campbell; RDMA list
Subject: [PATCH] [IB/QIB] Fix QIB early error reporting prints

Noticed this odd looking thing in dmesg:

ib_qib 0000:02:00.0: <3>ib_qib: Unable to enable pcie error reporting: -5

Which is due to a bad use of dev_info.

Signed-off-by Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
 drivers/infiniband/hw/qib/qib.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
drivers/infiniband/hw/qib/qib.h +1 -1
index 3593983..0268326 100644
@@ -1402,7 +1402,7 @@ extern struct mutex qib_mutex;
  */
 #define qib_early_err(dev, fmt, ...) \
        do { \
-               dev_info(dev, KERN_ERR QIB_DRV_NAME ": " fmt, ##__VA_ARGS__); \
+               dev_err(dev, fmt, ##__VA_ARGS__); \
        } while (0)
 
 #define qib_dev_err(dd, fmt, ...) \

--
1.6.0.4

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

A message that is not in the archive (sent off-list or not yet received): 35AAF1E4A771E142979F27B51793A488873ABE076E-HolNjIBXvBOXx9kJd3VG2h2eb7JE58TQ@public.gmane.org