Skip to contentSkip to conversation

perf: off by one in perf_swevent_init()

PATCH In review Dan Carpenter 2 participants 4 messages Oct 24, 2010 – Dec 16, 2010 Kernel janitors

lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH 1/1 perf: off by one in perf_swevent_init()

The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.

Signed-off-by Dan Carpenter <[email protected]>
kernel/perf_event.c +1 -1
index f309e80..c45396d 100644
@@ -4687,7 +4687,7 @@ static int perf_swevent_init(struct perf_event *event)
 		break;
 	}
 
-	if (event_id > PERF_COUNT_SW_MAX)
+	if (event_id >= PERF_COUNT_SW_MAX)
 		return -ENOENT;
 
 	if (!event->parent) {
author
#3 lore raw

[tip:perf/urgent] perf: Fix off by one in perf_swevent_init()

In reply to Dan Carpenter
Commit-ID:  ce677831a4abd0f9f957c90ac6f6a0d0472bafb4
Gitweb:     http://git.kernel.org/tip/ce677831a4abd0f9f957c90ac6f6a0d0472bafb4
Author:     Dan Carpenter <[email protected]>
AuthorDate: Sun, 24 Oct 2010 21:50:42 +0200
Committer:  Ingo Molnar <[email protected]>
CommitDate: Thu, 16 Dec 2010 11:14:31 +0100

perf: Fix off by one in perf_swevent_init()

The perf_swevent_enabled[] array has PERF_COUNT_SW_MAX elements.

Signed-off-by Dan Carpenter <[email protected]>
Signed-off-by Peter Zijlstra <[email protected]>

LKML-Reference: <20101024195041.GT5985@bicker>

Signed-off-by Ingo Molnar <[email protected]>
---
 kernel/perf_event.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
kernel/perf_event.c +1 -1
index 7b87017..2870fee 100644
@@ -4719,7 +4719,7 @@ static int perf_swevent_init(struct perf_event *event)
 		break;
 	}
 
-	if (event_id > PERF_COUNT_SW_MAX)
+	if (event_id >= PERF_COUNT_SW_MAX)
 		return -ENOENT;
 
 	if (!event->parent) {