MIPS: MT: Fix build error iFPU affinity code

PATCH In review Ralf Baechle 3 participants 3 messages Oct 24, 2010 – Oct 25, 2010 MIPS

lore

Share & tools

lore

Ralf Baechle

author

2010-10-24 21:24 UTC #0 lore raw

PATCH 1/1 MIPS: MT: Fix build error iFPU affinity code

Quoted 5 lines

commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
Author: KOSAKI Motohiro <[email protected]>
Date:   Fri Oct 15 04:21:18 2010 +0900
security: remove unused parameter from security_task_setscheduler()

broke the build of arch/mips/kernel/mips-mt-fpaff.c. The function arguments were unnecessary, not the semicolon ...

Signed-off-by Ralf Baechle <[email protected]>

 arch/mips/kernel/mips-mt-fpaff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

arch/mips/kernel/mips-mt-fpaff.c +1 -1

index 9a526ba..802e616 100644
@@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
 	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
 		goto out_unlock;
 
-	retval = security_task_setscheduler(p)
+	retval = security_task_setscheduler(p);
 	if (retval)
 		goto out_unlock;

KOSAKI Motohiro

2010-10-25 00:40 UTC #1 lore raw

Quoted 19 lines

Quoted 5 lines
commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
Author: KOSAKI Motohiro <[email protected]>
Date:   Fri Oct 15 04:21:18 2010 +0900
security: remove unused parameter from security_task_setscheduler()
broke the build of arch/mips/kernel/mips-mt-fpaff.c. The function arguments were unnecessary, not the semicolon ...
Signed-off-by Ralf Baechle <[email protected]>
 arch/mips/kernel/mips-mt-fpaff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
arch/mips/kernel/mips-mt-fpaff.c +0 -0
index 9a526ba..802e616 100644

arch/mips/kernel/mips-mt-fpaff.c asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len, · line 109

Quoted 8 lines

arch/mips/kernel/mips-mt-fpaff.c +1 -1

@@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
 	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
 		goto out_unlock;
 
-	retval = security_task_setscheduler(p)
+	retval = security_task_setscheduler(p);
 	if (retval)
 		goto out_unlock;

Agh! Thank you for fixing this!

James Morris

Acked-by on v1 1/1

2010-10-25 10:15 UTC #2 lore raw

In reply to Ralf Baechle

Quoted 6 lines · Ralf Baechle

Quoted 5 lines
commit b0ae19811375031ae3b3fecc65b702a9c6e5cc28
Author: KOSAKI Motohiro <[email protected]>
Date:   Fri Oct 15 04:21:18 2010 +0900
security: remove unused parameter from security_task_setscheduler()

Quoted 7 lines

broke the build of arch/mips/kernel/mips-mt-fpaff.c. The function arguments were unnecessary, not the semicolon ...
Signed-off-by Ralf Baechle <[email protected]>
 arch/mips/kernel/mips-mt-fpaff.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

Acked-by James Morris <[email protected]>

Quoted 15 lines

arch/mips/kernel/mips-mt-fpaff.c +1 -1

index 9a526ba..802e616 100644
@@ -103,7 +103,7 @@ asmlinkage long mipsmt_sys_sched_setaffinity(pid_t pid, unsigned int len,
 	if (!check_same_owner(p) && !capable(CAP_SYS_NICE))
 		goto out_unlock;
 
-	retval = security_task_setscheduler(p)
+	retval = security_task_setscheduler(p);
 	if (retval)
 		goto out_unlock;

Signature · 2 lines

James Morris
<[email protected]>