ext4: fix unbalanced mutex unlock
PATCH 1/1 ext4: fix unbalanced mutex unlock
Although the mutex isn't locked yet, if ext4_li_request_new fails, the mutex would get unlocked on the error path.
Signed-off-by Nicolas Kaiser <[email protected]>
--- fs/ext4/super.c | 6 ++---- 1 files changed, 2 insertions(+), 4 deletions(-)
fs/ext4/super.c +2 -4
@@ -2915,10 +2915,8 @@ static int ext4_register_li_request(struct super_block *sb, } elr =ext4_li_request_new (sb, first_not_zeroed); -if (!elr) { - ret = -ENOMEM ; - goto out; - } +if (!elr) +return -ENOMEM ;mutex_lock (&ext4_li_mtx);
Signature · 1 line
1.7.2.2
Ted Ts'o
maintainerQuoted 4 lines · Nicolas Kaiser
Although the mutex isn't locked yet, if
ext4_li_request_newfails, the mutex would get unlocked on the error path.Signed-off-by Nicolas Kaiser <[email protected]>
Nice catch, thanks!! I've applied a fix to the ext4 patch queue.
- Ted
* "Ted Ts'o" <[email protected]>:
Quoted 5 lines · Nicolas Kaiser
Quoted 2 lines
Although the mutex isn't locked yet, if
ext4_li_request_newfails, the mutex would get unlocked on the error path.Nice catch, thanks!! I've applied a fix to the ext4 patch queue.
Thanks for augmenting the patch - looks good to me :)
Best regards,
Nicolas Kaiser