misc/apds9802als: signedness bug in als_sensing_range_store()

PATCH New Dan Carpenter 1 participant 1 message Oct 28, 2010

Subsystems (2)

Kernel janitors Char and misc drivers

lore

Share & tools

lore

Dan Carpenter

author

2010-10-28 04:41 UTC #0 lore raw

PATCH 1/1 misc/apds9802als: signedness bug in als_sensing_range_store()

The error handling breaks if "ret_val" is unsigned here.

Signed-off-by Dan Carpenter <[email protected]>

drivers/misc/apds9802als.c +1 -1

index f9b91ba..0ed0935 100644
@@ -123,7 +123,7 @@ static ssize_t als_sensing_range_store(struct device *dev,
 {
 	struct i2c_client *client = to_i2c_client(dev);
 	struct als_data *data = i2c_get_clientdata(client);
-	unsigned int ret_val;
+	int ret_val;
 	unsigned long val;
 
 	if (strict_strtoul(buf, 10, &val))