dma/intel_mid_dma: remove unneeded null check

PATCH New Dan Carpenter 1 participant 1 message Oct 28, 2010

Subsystems (2)

Kernel janitors dmaengine

lore

Share & tools

lore

Dan Carpenter

author

2010-10-28 13:41 UTC #0 lore raw

PATCH 1/1 dma/intel_mid_dma: remove unneeded null check

Smatch complains because we dereference "mid" before checking it. It turns out that "mid" is always a valid pointer here so we can just remove the check.

Signed-off-by Dan Carpenter <[email protected]>

drivers/dma/intel_mid_dma.c +0 -5

index 338bc4e..41941d0 100644
@@ -1021,11 +1021,6 @@ static irqreturn_t intel_mid_dma_interrupt(int irq, void *data)
 
 	/*DMA Interrupt*/
 	pr_debug("MDMA:Got an interrupt on irq %d\n", irq);
-	if (!mid) {
-		pr_err("ERR_MDMA:null pointer mid\n");
-		return -EINVAL;
-	}
-
 	pr_debug("MDMA: Status %x, Mask %x\n", tfr_status, mid->intr_mask);
 	tfr_status &= mid->intr_mask;
 	if (tfr_status) {